Skip to content

Commit b16e05e

Browse files
committed
Added unit tests to check for BASE64 and proper handling
There is a still an error when the library is initialized with something like `bASe64`. It is not setting it. From the code this looks like the unintended behavior. But then I don't understand why theother test case works when `EmBed` is given. This too should fail as per my reading of the code. Going to trace through a bit more to see why that isn't failing and what I may be missing.
1 parent c87bb45 commit b16e05e

File tree

1 file changed

+21
-2
lines changed

1 file changed

+21
-2
lines changed

utest/test/keywords/test_screen_shot.py

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
SCREENSHOT_FILE_NAME = "selenium-screenshot-{index}.png"
99
ELEMENT_FILE_NAME = "selenium-element-screenshot-{index}.png"
1010
EMBED = "EMBED"
11-
11+
BASE64 = "BASE64"
1212

1313
@pytest.fixture(scope="module")
1414
def screen_shot():
@@ -35,11 +35,21 @@ def test_screen_shotdir_embeded(screen_shot):
3535
assert screen_shot._decide_embedded("other.psn") == (False, None)
3636

3737

38+
def test_screen_shotdir_return_base64(screen_shot):
39+
screen_shot.ctx.screenshot_root_directory = BASE64
40+
assert screen_shot._decide_embedded(SCREENSHOT_FILE_NAME) == (True, BASE64)
41+
assert screen_shot._decide_embedded(SCREENSHOT_FILE_NAME.upper()) == (True, BASE64)
42+
assert screen_shot._decide_embedded(ELEMENT_FILE_NAME) == (True, BASE64)
43+
assert screen_shot._decide_embedded(ELEMENT_FILE_NAME.upper()) == (True, BASE64)
44+
assert screen_shot._decide_embedded("other.psn") == (False, None)
45+
46+
3847
def test_file_name_embeded(screen_shot):
39-
assert screen_shot._decide_embedded(EMBED) == (True, EMBED)
4048
assert screen_shot._decide_embedded("other.psn") == (False, None)
4149
screen_shot.ctx.screenshot_root_directory = EMBED
4250
assert screen_shot._decide_embedded(EMBED) == (True, EMBED)
51+
screen_shot.ctx.screenshot_root_directory = BASE64
52+
assert screen_shot._decide_embedded(BASE64) == (True, BASE64)
4353

4454

4555
def test_screenshot_path_embedded(screen_shot):
@@ -56,6 +66,12 @@ def test_sl_init_embed():
5666
sl = SeleniumLibrary(screenshot_root_directory=EMBED)
5767
assert sl.screenshot_root_directory == EMBED
5868

69+
sl = SeleniumLibrary(screenshot_root_directory="bAsE64")
70+
assert sl.screenshot_root_directory == BASE64
71+
72+
sl = SeleniumLibrary(screenshot_root_directory=BASE64)
73+
assert sl.screenshot_root_directory == BASE64
74+
5975

6076
def test_sl_init_not_embed():
6177
sl = SeleniumLibrary(screenshot_root_directory=None)
@@ -76,6 +92,9 @@ def test_sl_set_screenshot_directory():
7692
sl.set_screenshot_directory(EMBED)
7793
assert sl.screenshot_root_directory == EMBED
7894

95+
sl.set_screenshot_directory(BASE64)
96+
assert sl.screenshot_root_directory == BASE64
97+
7998
sl.set_screenshot_directory("EEmBedD")
8099
assert "EEmBedD" in sl.screenshot_root_directory
81100
assert len("EEmBedD") < len(sl.screenshot_root_directory)

0 commit comments

Comments
 (0)