Skip to content

Commit dff49b8

Browse files
committed
Fixed accepteance test
1 parent 0ef02dc commit dff49b8

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

atest/acceptance/1-plugin/OpenBrowserExample.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,20 +16,20 @@ def __init__(self, ctx):
1616
def open_browser(self, url, browser='firefox', alias=None,
1717
remote_url=False, desired_capabilities=None,
1818
ff_profile_dir=None, options=None, service_log_path=None,
19-
extra_dictionary=None):
19+
extra_dictionary=None, executable_path=None):
2020
self._new_creator.extra_dictionary = extra_dictionary
2121
browser_manager = BrowserManagementKeywords(self.ctx)
2222
browser_manager._make_driver = self._make_driver
2323
browser_manager.open_browser(url, browser=browser, alias=alias,
2424
remote_url=remote_url, desired_capabilities=desired_capabilities,
2525
ff_profile_dir=ff_profile_dir, options=options,
26-
service_log_path=service_log_path)
26+
service_log_path=service_log_path, executable_path=None)
2727

2828
def _make_driver(self, browser, desired_capabilities=None, profile_dir=None,
29-
remote=None, options=None, service_log_path=None):
29+
remote=None, options=None, service_log_path=None, executable_path=None):
3030
driver = self._new_creator.create_driver(
3131
browser=browser, desired_capabilities=desired_capabilities, remote_url=remote,
32-
profile_dir=profile_dir, options=options, service_log_path=service_log_path)
32+
profile_dir=profile_dir, options=options, service_log_path=service_log_path, executable_path=executable_path)
3333
driver.set_script_timeout(self.ctx.timeout)
3434
driver.implicitly_wait(self.ctx.implicit_wait)
3535
if self.ctx.speed:
@@ -40,7 +40,7 @@ def _make_driver(self, browser, desired_capabilities=None, profile_dir=None,
4040
class NewWebDriverCreator(WebDriverCreator):
4141

4242
def create_driver(self, browser, desired_capabilities, remote_url,
43-
profile_dir=None, options=None, service_log_path=None):
43+
profile_dir=None, options=None, service_log_path=None, executable_path=None):
4444
self.browser_names['seleniumwire'] = 'seleniumwire'
4545
browser = self._normalise_browser_name(browser)
4646
creation_method = self._get_creator_method(browser)

atest/acceptance/multiple_browsers_executable_path.robot

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ Documentation Creating test which would work on all browser is not possible.
1010
1111
*** Test Cases ***
1212
Chrome Browser With executable_path Argument
13+
[Tags] NoGrid
1314
Run Keyword And Expect Error
1415
... WebDriverException: Message: 'exist' executable needs to be in PATH.*
1516
... Open Browser ${FRONT PAGE} ${BROWSER} remote_url=${REMOTE_URL}

0 commit comments

Comments
 (0)