Add value converter of percent-output_val to led_on()

Author: JeongJun-Lee

neobot/neosoco.py

@@ -333,23 +333,6 @@ def _notify_sensory_device_data_changed(self):
     def _notify_motoring_device_data_changed(self):
         self._roboid._notify_motoring_device_data_changed()
 
-    def led_on(self, port: str, brightness: str):
-        if isinstance(port, str) and isinstance(brightness, int):
-            if port.lower() =='out1':
-                self.write(Neosoco.OUTPUT_1, Util.round(brightness)) 
-            elif port.lower() =='out2':
-                self.write(Neosoco.OUTPUT_2, Util.round(brightness)) 
-            elif port.lower() =='out3':
-                self.write(Neosoco.OUTPUT_3, Util.round(brightness)) 
-            elif port.lower() =='all':
-                self.write(Neosoco.OUTPUT_1, Util.round(brightness)) 
-                self.write(Neosoco.OUTPUT_2, Util.round(brightness)) 
-                self.write(Neosoco.OUTPUT_3, Util.round(brightness))
-            else:
-                raise ValueError
-        else:
-            raise TypeError
-
     def get_value(self, port: str):
         if isinstance(port, str):
             if port.lower() =='in1':
@@ -363,6 +346,42 @@ def get_value(self, port: str):
             elif port.lower() =='bat':
                 return self.read(Neosoco.BATTERY)
             else:
+                Util.print_error('Wrong value of port')
+                raise ValueError
+        else:
+            raise TypeError
+
+    def led_on(self, port: str, brightness: str):
+        try:
+            cvt_dic = { 
+                '100': 255,
+                '90': 230,
+                '80': 204,
+                '70': 179,
+                '60': 153,
+                '50': 128,
+                '40': 102,
+                '30': 77,
+                '20': 51,
+                '10': 26
+            }
+            cvt_val = cvt_dic[brightness]
+        except KeyError:
+            Util.print_error('Wrong value of percentage')
+            raise ValueError
+        if isinstance(port, str):
+            if port.lower() =='out1':
+                self.write(Neosoco.OUTPUT_1, cvt_val) 
+            elif port.lower() =='out2':
+                self.write(Neosoco.OUTPUT_2, cvt_val) 
+            elif port.lower() =='out3':
+                self.write(Neosoco.OUTPUT_3, cvt_val) 
+            elif port.lower() =='all':
+                self.write(Neosoco.OUTPUT_1, cvt_val) 
+                self.write(Neosoco.OUTPUT_2, cvt_val) 
+                self.write(Neosoco.OUTPUT_3, cvt_val)
+            else:
+                Util.print_error('Wrong value of port')
                 raise ValueError
         else:
             raise TypeError

neobot/util.py

@@ -16,6 +16,7 @@
 # Free Software Foundation, Inc., 59 Temple Place, Suite 330,
 # Boston, MA  02111-1307  USA
 
+import sys
 
 class Util(object):
     @staticmethod
@@ -26,4 +27,11 @@ def round(value):
             else:
                 return int(0.5 + value)
         else:
-            return 0
+            return 0
+    @staticmethod
+    def print_message(message):
+        sys.stdout.write("{}: {}\n".format('Debug', message))
+
+    @staticmethod
+    def print_error(message):
+        sys.stderr.write("{}: {}\n".format('Error', message))

test.py

@@ -2,13 +2,13 @@
 
 n =  Neosoco()
 
-# case1) Turn on LED during 1s
-# n.led_on("out1", 255)
-# wait(1000)
+# case1) Turn on LED with 100% brightness during 1s
+n.led_on("out1", '100')
+wait(1000)
 
 # case2) Turn on LED when the distance is under 10cm
-while True:
-  if n.get_value('in1') < 10:
-    n.led_on("out1", 255)
-  else:
-    n.led_on("out1", 0)
+# while True:
+#   if n.get_value('in1') < 10:
+#     n.led_on("out1", 255)
+#   else:
+#     n.led_on("out1", 0)