Skip to content

Fix HAL dependencies #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2025
Merged

Fix HAL dependencies #185

merged 1 commit into from
Jul 29, 2025

Conversation

@pjreiniger
Copy link
Contributor

Found during my bazel bringup. This line depends = ["wpiutil", "ntcore"] was happening with no explicit dependency on pyntcore. The build script builds them in an order such that ntcore gets built and installed first so it gets missed. Also unlikely that someone would just do a pip install pip install robotpy-hal==2027.0.0a2 instead of all of wpilib, but if you do, you get this

(.venv) pjreiniger@BOOK-86GHH7D7KK: pip install robotpy-hal==2027.0.0a2


(.venv) pjreiniger@BOOK-86GHH7D7KK:~/git/robotpy$ python
Python 3.12.3 (main, Jun 18 2025, 17:59:45) [GCC 13.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import hal
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/pjreiniger/git/robotpy/.venv/lib/python3.12/site-packages/hal/__init__.py", line 4, in <module>
    from . import _initialize
  File "/home/pjreiniger/git/robotpy/.venv/lib/python3.12/site-packages/hal/_initialize.py", line 1, in <module>
    from . import exceptions, _init__wpiHal, _wpiHal
  File "/home/pjreiniger/git/robotpy/.venv/lib/python3.12/site-packages/hal/_init__wpiHal.py", line 6, in <module>
    import ntcore._init__ntcore
ModuleNotFoundError: No module named 'ntcore'

@virtuald virtuald merged commit 919fd81 into robotpy:2027 Jul 29, 2025
41 checks passed
@pjreiniger pjreiniger mentioned this pull request Aug 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pjreiniger @virtuald