Skip to content

Commit f8912e0

Browse files
authored
Merge pull request #24 from auscompgeek/fix-docs
Fix docs
2 parents fc5e2db + 205b7c5 commit f8912e0

File tree

3 files changed

+27
-15
lines changed

3 files changed

+27
-15
lines changed

.travis.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,11 @@ language: python
33
services:
44
- docker
55

6+
install:
7+
- pip install sphinx sphinx-rtd-theme
8+
69
script:
10+
- make -C docs html
711
- ./build_exe.sh
812

913
deploy:
@@ -27,4 +31,4 @@ notifications:
2731
- https://webhooks.gitter.im/e/2fb1c026e64fdd70d27b
2832
on_success: change
2933
on_failure: always
30-
on_start: never
34+
on_start: never

README.rst

Lines changed: 20 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
pynetworktables2js
22
==================
33

4-
A cross platform library that forwards NetworkTables key/values over a Websocket,
4+
A cross platform library that forwards NetworkTables key/values over a WebSocket,
55
so that you can easily write a Driver Station Dashboard for your robot in HTML5 +
66
JavaScript.
77

88
This library does not provide a full dashboard solution, but is intended to
99
provide the necessary plumbing for one to create one with only knowledge
10-
of HTML/Javascript. Because the communications layer uses NetworkTables, you
10+
of HTML/JavaScript. Because the communications layer uses NetworkTables, you
1111
can connect to all FRC languages (C++, Java, LabVIEW, Python).
1212

1313
.. note:: NetworkTables is a protocol used for robot communication in the
@@ -26,15 +26,15 @@ Installation
2626
Easy install (Windows only)
2727
---------------------------
2828

29-
1. Download the latest pynetworktables2js.exe from github at
29+
1. Download the latest pynetworktables2js.exe from GitHub at
3030
https://github.com/robotpy/pynetworktables2js/releases .
3131
2. Extract the exe from the zipfile, and copy it to your directory of HTML/JS
3232
files.
3333
3. Double click the exe to run it!
3434

3535
.. note:: By default, it will connect to 127.0.0.1. To connect to a robot,
3636
you will need to pass the exe arguments to tell it where the robot is.
37-
Use --help to see the available options.
37+
Use ``--help`` to see the available options.
3838

3939
Manual install
4040
--------------
@@ -76,15 +76,22 @@ You can just distribute your HTML files, and run a pynetworktables server
7676
using the following command from inside the directory::
7777

7878
python -m pynetworktables2js
79-
79+
8080
Or on Windows::
8181

8282
py -m pynetworktables2js
83-
83+
8484
This will start a pynetworktables2js server using Tornado (which is installed
8585
by default) and it will serve the current directory. You can navigate your
8686
browser (I recommend Chrome) to http://127.0.0.1:8888 and see your website.
8787

88+
You will want to also pass either the ``--robot`` or ``--team`` switch::
89+
90+
py -m pynetworktables2js --robot roborio-XXXX-frc.local
91+
py -m pynetworktables2js --team XXXX
92+
93+
Dashboard mode currently doesn't work, as the underlying support in
94+
pynetworktables hasn't been implemented yet for the newer FRC Driver Station.
8895

8996
Customized python server
9097
------------------------
@@ -103,9 +110,9 @@ If you want to try this out with your current robot, you can do::
103110
104111
If you are running pynetworktables2js on your driver station laptop, you can
105112
receive robot IP information directly from the Driver Station (handy during
106-
actual competitions):
113+
actual competitions)::
107114

108-
python tornado_server.py --dashboard
115+
python tornado_server.py --dashboard
109116

110117
If you navigate your browser (I recommend Chrome) to http://127.0.0.1:8888, all
111118
of the current NetworkTables values will be shown as they change.
@@ -120,18 +127,19 @@ dashboard. Just add your custom files to the www directory.
120127
Contributing new changes
121128
========================
122129

123-
pynetworktables2js is intended to be a project that all members of the FIRST
130+
pynetworktables2js is intended to be a project that all members of the `FIRST`
124131
community can quickly and easily contribute to. If you find a bug, or have an
125132
idea that you think others can use:
126133

127-
1. `Fork this git repository <https://github.com/robotpy/pynetworktables2js/fork>`_ to your github account
134+
1. `Fork this git repository <https://github.com/robotpy/pynetworktables2js/fork>`_
135+
to your GitHub account
128136
2. Create your feature branch (``git checkout -b my-new-feature``)
129137
3. Commit your changes (``git commit -am 'Add some feature'``)
130138
4. Push to the branch (``git push -u origin my-new-feature``)
131-
5. Create new Pull Request on github
139+
5. Create new Pull Request on GitHub
132140

133141
One place in particular I would love to see contributions is in adding useful
134-
javascript functions/objects that make creating dashboards even easier!
142+
JavaScript functions/objects that make creating dashboards even easier!
135143

136144
Authors
137145
=======

docs/conf.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
from os.path import abspath, join, dirname
1717

18-
sys.path.insert(0, abspath(join(dirname(__file__), '..', 'pynetworktables2js')))
18+
sys.path.insert(0, abspath(join(dirname(__file__), '..')))
1919

2020
import pynetworktables2js
2121

@@ -54,7 +54,7 @@
5454
# built documents.
5555
#
5656
# The short X.Y version.
57-
version = pynetworktables2js.__version__.split('.')[:2]
57+
version = '.'.join(pynetworktables2js.__version__.split('.')[:2])
5858
# The full version, including alpha/beta/rc tags.
5959
release = pynetworktables2js.__version__
6060

0 commit comments

Comments
 (0)