Skip to content

Commit 19dd530

Browse files
committed
refactoring code + fixing log
1 parent f0840a3 commit 19dd530

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

robusta_krr/core/integrations/kubernetes/__init__.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -148,16 +148,14 @@ async def list_pods(self, object: K8sObjectData) -> list[PodData]:
148148
selector = f"batch.kubernetes.io/controller-uid in ({','.join(ownered_jobs_uids)})"
149149

150150
elif object.kind == "GroupedJob":
151-
# For GroupedJob, we need to get pods using the label+value filter
152-
if not hasattr(object._api_resource, '_label_filters') or not object._api_resource._label_filters:
151+
if not hasattr(object._api_resource, '_label_filter') or not object._api_resource._label_filter:
153152
return []
154153

155154
# Use the label+value filter to get pods
156-
label_selector = ",".join(object._api_resource._label_filters)
157155
ret: V1PodList = await loop.run_in_executor(
158156
self.executor,
159157
lambda: self.core.list_namespaced_pod(
160-
namespace=object.namespace, label_selector=label_selector
158+
namespace=object.namespace, label_selector=object._api_resource._label_filter
161159
),
162160
)
163161

@@ -536,12 +534,11 @@ async def _list_all_groupedjobs(self) -> list[K8sObjectData]:
536534
grouped_job.name = group_name
537535
grouped_job.namespace = namespace
538536
grouped_job._api_resource._grouped_jobs = namespace_jobs
539-
grouped_job._api_resource._label_filters = []
540-
grouped_job._api_resource._label_filters.append(group_name)
537+
grouped_job._api_resource._label_filter = group_name
541538

542539
result.append(grouped_job)
543540

544-
logger.debug(f"Found {len(result)} GroupedJob groups")
541+
logger.debug("Found %d GroupedJob groups", len(result))
545542
return result
546543

547544
async def __list_hpa_v1(self) -> dict[HPAKey, HPAData]:

0 commit comments

Comments
 (0)