v1.18.0 produces invalid YAML on long lines

[LukasPrediger]

Describe the bug

Take the version number with a grain of salt, we only noticed this due to the new feature of reporting labels and annotations

When producing a yaml report with KRR that contains very long lines (seems to be pretty exactly 81 columns), krr adds a line break, which often breaks the yaml format.

Example:
rewe-digital.com/scm-image-commit: <commit-hash> produces a line that's longer than 80 lines. This is being output to the yaml files as

rewe-digital.com/scm-image-commit: 
 <commit-hash>

Which is invalid yaml, so it breaks programs trying to parse the file

To Reproduce

1. create some kubernetes resource where label + value is longer than 80 columns
2. analyze this resource with krr and configure yaml output
3. check the produced yaml file

Workaround
For now simply downgrading to 1.17.0 fixes the issue since the labels and annotations are not being written to the output report

[aantn]

Hi @LukasPrediger, thanks for the bug report.
I haven't been able to reproduce when running krr with a long label and the command krr simple -f yaml --quiet > out.yaml
What command are you running krr with?

[sebastianserrano]

Running into the same issue here when trying to output to a file, whether its JSON or yaml in version v1.18.0.

Commands:

1. krr simple -p [URL] -f json --fileoutput report.json --kubeconfig [PATH]
2. krr simple -p [URL] -f yaml --fileoutput report.yaml --kubeconfig [PATH]

[sebastianserrano]

@aantn Doing it with the command you recommended

krr simple -p [URL] -f json --quiet --kubeconfig [PATH] > report.json

Did indeed get rid of the issue. It must be something related to how the file is being saved, more specifically with how the --fileoutput option is being handled

[aantn]

Thanks, I've added a fix for --fileoutput in #390
Can you confirm that works please?

[LukasPrediger]

Good Morning,
Sorry for the late reply, i was on holiday until now. Thanks a lot for the fix, i'll verify that this fixes the issue and report if anything else comes up.

❤️

[aantn]

Awesome, thanks.

On a separate note, we're gathering some general user feedback to inform our roadmap. Would you be interested in participating in a short session?

[LukasPrediger]

I just checked against our system and this change fixes the issue in the yaml format. I haven't tested json format explicitly but it looks to be the fix needed. Thanks again for your effort.

I talked to my team and we'd love to have a chat about our experience. Best to just send me an email to lukas.prediger@rewe-digital.com so we can schedule a session

[aantn]

Thanks, sent you an email right now.