fixed a CI problem with slack tests

Author: Sheeproid

tests/test_slack.py

@@ -23,8 +23,8 @@ def test_send_to_slack(slack_channel: SlackChannel):
     finding = Finding(title=msg, aggregation_key=msg)
     finding.add_enrichment([MarkdownBlock("testing")])
     slack_params = SlackSinkParams(name="test_slack", slack_channel=slack_channel.channel_name, api_key="")
-    slack_sender.send_finding_to_slack(finding, slack_params, False)
-    assert slack_channel.get_latest_message() == msg
+    ts = slack_sender.send_finding_to_slack(finding, slack_params, False)
+    assert slack_channel.get_message_by_ts(ts) == msg
 
 
 def test_long_slack_messages(slack_channel: SlackChannel):

tests/utils/slack_utils.py

@@ -18,10 +18,23 @@ def was_message_sent_recently(self, expected) -> bool:
         return False
 
     def get_latest_message(self):
+        # Note: Prefer get_message_by_ts() to avoid race conditions when tests share a channel
         results = self.client.conversations_history(channel=self.channel_id)
         messages = results["messages"]
         return messages[0]["text"]
 
+    def get_message_by_ts(self, ts: str) -> str:
+        """Get message by timestamp - avoids race conditions unlike get_latest_message()."""
+        results = self.client.conversations_history(
+            channel=self.channel_id,
+            latest=ts,
+            oldest=ts,
+            inclusive=True,
+            limit=1
+        )
+        messages = results["messages"]
+        return messages[0]["text"] if messages else None
+
     def get_complete_latest_message(self):
         results = self.client.conversations_history(channel=self.channel_id)
         messages = results["messages"]