Skip to content

Commit 7e52abb

Browse files
authored
Merge pull request #1558 from rocket-admin/backend_dashboards_properties-rework
feat: update SavedDbQueryEntity and migration for widget properties management
2 parents accd606 + 774aa5d commit 7e52abb

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

backend/src/entities/visualizations/saved-db-query/saved-db-query.entity.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export class SavedDbQueryEntity {
2727
@Column({ type: 'text', default: null, nullable: true })
2828
description: string | null;
2929

30-
@Column({ type: 'varchar' })
30+
@Column({ type: 'varchar', nullable: true, default: DashboardWidgetTypeEnum.Chart })
3131
widget_type: DashboardWidgetTypeEnum;
3232

3333
@Column({ type: 'varchar', default: null, nullable: true })
@@ -36,7 +36,7 @@ export class SavedDbQueryEntity {
3636
@Column('json', { default: null, nullable: true })
3737
widget_options: string | null;
3838

39-
@Column({ type: 'text' })
39+
@Column({ type: 'text', nullable: true, default: null })
4040
query_text: string;
4141

4242
@Column({ type: 'timestamp', default: () => 'CURRENT_TIMESTAMP' })

backend/src/migrations/1770116525022-MovedDashboardWidgetPropertiesToSavedQuery.ts renamed to backend/src/migrations/1770126075082-MovedDashboardWidgetPropertiesToSavedQuery.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,22 @@
11
import { MigrationInterface, QueryRunner } from 'typeorm';
22

3-
export class MovedDashboardWidgetPropertiesToSavedQuery1770116525022 implements MigrationInterface {
4-
name = 'MovedDashboardWidgetPropertiesToSavedQuery1770116525022';
3+
export class MovedDashboardWidgetPropertiesToSavedQuery1770126075082 implements MigrationInterface {
4+
name = 'MovedDashboardWidgetPropertiesToSavedQuery1770126075082';
55

66
public async up(queryRunner: QueryRunner): Promise<void> {
77
await queryRunner.query(`ALTER TABLE "dashboard_widget" DROP COLUMN "widget_options"`);
88
await queryRunner.query(`ALTER TABLE "dashboard_widget" DROP COLUMN "widget_type"`);
99
await queryRunner.query(`ALTER TABLE "dashboard_widget" DROP COLUMN "name"`);
1010
await queryRunner.query(`ALTER TABLE "dashboard_widget" DROP COLUMN "description"`);
1111
await queryRunner.query(`ALTER TABLE "dashboard_widget" DROP COLUMN "chart_type"`);
12-
await queryRunner.query(`ALTER TABLE "saved_db_query" ADD "widget_type" character varying NOT NULL`);
12+
await queryRunner.query(`ALTER TABLE "saved_db_query" ADD "widget_type" character varying DEFAULT 'chart'`);
1313
await queryRunner.query(`ALTER TABLE "saved_db_query" ADD "chart_type" character varying`);
1414
await queryRunner.query(`ALTER TABLE "saved_db_query" ADD "widget_options" json`);
15+
await queryRunner.query(`ALTER TABLE "saved_db_query" ALTER COLUMN "query_text" DROP NOT NULL`);
1516
}
1617

1718
public async down(queryRunner: QueryRunner): Promise<void> {
19+
await queryRunner.query(`ALTER TABLE "saved_db_query" ALTER COLUMN "query_text" SET NOT NULL`);
1820
await queryRunner.query(`ALTER TABLE "saved_db_query" DROP COLUMN "widget_options"`);
1921
await queryRunner.query(`ALTER TABLE "saved_db_query" DROP COLUMN "chart_type"`);
2022
await queryRunner.query(`ALTER TABLE "saved_db_query" DROP COLUMN "widget_type"`);

0 commit comments

Comments
 (0)