Add missing SC permission

kanewallmann · kanewallmann · commit 6c31f26e810b · 2025-10-03T09:26:46.000+10:00
diff --git a/contracts/contract/dao/protocol/settings/RocketDAOProtocolSettingsSecurity.sol b/contracts/contract/dao/protocol/settings/RocketDAOProtocolSettingsSecurity.sol
@@ -27,6 +27,7 @@ contract RocketDAOProtocolSettingsSecurity is RocketDAOProtocolSettings, RocketD
             setBool(keccak256(abi.encodePacked("dao.security.allowed.setting", "minipool", "minipool.bond.reduction.enabled")), true);
             setBool(keccak256(abi.encodePacked("dao.security.allowed.setting", "network", "network.submit.balances.enabled")), true);
             setBool(keccak256(abi.encodePacked("dao.security.allowed.setting", "network", "network.submit.prices.enabled")), true);
+            setBool(keccak256(abi.encodePacked("dao.security.allowed.setting", "network", "network.submit.rewards.enabled")), true);
             setBool(keccak256(abi.encodePacked("dao.security.allowed.setting", "node", "node.registration.enabled")), true);
             setBool(keccak256(abi.encodePacked("dao.security.allowed.setting", "node", "node.smoothing.pool.registration.enabled")), true);
             setBool(keccak256(abi.encodePacked("dao.security.allowed.setting", "node", "node.deposit.enabled")), true);
diff --git a/contracts/contract/upgrade/RocketUpgradeOneDotFour.sol b/contracts/contract/upgrade/RocketUpgradeOneDotFour.sol
@@ -90,6 +90,9 @@ contract RocketUpgradeOneDotFour is RocketBase {
         // Add new security council allowed parameter
         setBool(keccak256(abi.encodePacked("dao.security.allowed.setting", "network", "network.node.commission.share.security.council.adder")), true);
 
+        // Add missing security council permission for rewards submission enabled
+        setBool(keccak256(abi.encodePacked("dao.security.allowed.setting", "network", "network.submit.rewards.enabled")), true);
+
         // Deposit settings
         {
             bytes32 settingNameSpace = keccak256(abi.encodePacked("dao.protocol.setting.", "deposit"));

Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,9 @@ contract RocketUpgradeOneDotFour is RocketBase {`
`90`	`90`	`// Add new security council allowed parameter`
`91`	`91`	`setBool(keccak256(abi.encodePacked("dao.security.allowed.setting", "network", "network.node.commission.share.security.council.adder")), true);`
`92`	`92`
	`93`	`+ // Add missing security council permission for rewards submission enabled`
	`94`	`+ setBool(keccak256(abi.encodePacked("dao.security.allowed.setting", "network", "network.submit.rewards.enabled")), true);`
	`95`	`+`
`93`	`96`	`// Deposit settings`
`94`	`97`	`{`
`95`	`98`	`bytes32 settingNameSpace = keccak256(abi.encodePacked("dao.protocol.setting.", "deposit"));`