Fix unit in minipool penalty guardrail

kanewallmann · kanewallmann · commit 85cdf8d5dfbe · 2025-10-07T17:25:08.000+10:00
diff --git a/contracts/contract/dao/protocol/settings/RocketDAOProtocolSettingsMinipool.sol b/contracts/contract/dao/protocol/settings/RocketDAOProtocolSettingsMinipool.sol
@@ -39,7 +39,7 @@ contract RocketDAOProtocolSettingsMinipool is RocketDAOProtocolSettings, RocketD
                 require(_value >= (rocketDAONodeTrustedSettingsMinipool.getScrubPeriod() + 1 hours), "Launch timeout must be greater than scrub period");
                 require(_value >= 12 hours, "Launch timeout must be greater than 12 hours");
             } else if(settingKey == keccak256(abi.encodePacked("minipool.maximum.penalty.count"))) {
-                require(_value >= 1000 ether && _value <= 5000 ether, "Value must be >= 1000 ETH & <= 5000 ETH");
+                require(_value >= 1000 && _value <= 5000, "Value must be >= 1000 & <= 5000");
             }
         }
         // Update setting now

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ contract RocketDAOProtocolSettingsMinipool is RocketDAOProtocolSettings, RocketD`
`39`	`39`	`require(_value >= (rocketDAONodeTrustedSettingsMinipool.getScrubPeriod() + 1 hours), "Launch timeout must be greater than scrub period");`
`40`	`40`	`require(_value >= 12 hours, "Launch timeout must be greater than 12 hours");`
`41`	`41`	`} else if(settingKey == keccak256(abi.encodePacked("minipool.maximum.penalty.count"))) {`
`42`		`- require(_value >= 1000 ether && _value <= 5000 ether, "Value must be >= 1000 ETH & <= 5000 ETH");`
	`42`	`+ require(_value >= 1000 && _value <= 5000, "Value must be >= 1000 & <= 5000");`
`43`	`43`	`}`
`44`	`44`	`}`
`45`	`45`	`// Update setting now`