Make script/test more robust (#13)

* Make script/test more robust when dealing with different golang versions or golint not installed (e.g. in travis-ci)

Co-authored-by: Lucas Kacher <[email protected]>

* Use Go 1.11 in travis-ci since golint doesn't support old versions

* Rename to avoid shadowing existing variable

Author: flosell

.travis.yml

@@ -1,6 +1,6 @@
 sudo:     false
 language: go
-go:       1.6
+go:       1.11
 
 install: go get -t ./...
 script:  ./script/test

nodes.go

@@ -277,8 +277,8 @@ func encodeStruct(in reflect.Value) (ast.Node, []*ast.ObjectKey, error) {
 		itemKey := &ast.ObjectKey{Token: tkn}
 
 		// if the item is an object list, we need to flatten out the items
-		if val, ok := val.(*ast.ObjectList); ok {
-			for _, obj := range val.Items {
+		if objectList, ok := val.(*ast.ObjectList); ok {
+			for _, obj := range objectList.Items {
 				objectKeys := append([]*ast.ObjectKey{itemKey}, obj.Keys...)
 				list.Add(&ast.ObjectItem{
 					Keys: objectKeys,

script/test

@@ -4,11 +4,16 @@ set -e
 echo "go fmt..."
 test -z "$(gofmt -l -w . | tee /dev/stderr)"
 
+if ! [ -x "$(command -v golint)" ]; then
+  echo "installing golint..."
+  go get -u golang.org/x/lint/golint
+fi
+
 echo "go lint..."
 test -z "$(golint ./... | tee /dev/stderr)"
 
 echo "go vet..."
-test -z "$(go tool vet -test . 2>&1 | tee /dev/stderr)"
+test -z "$(go tool vet -all -shadow . 2>&1 | tee /dev/stderr)"
 
 echo "go test..."
 go test -race -cover ./...