Merge pull request #95 from rodneylab/fix__make_dependencies_optional

fix: 💫 make dependemcies in Cargo.toml optional

Author: rodneylab

.cargo/audit.toml

@@ -1,2 +1,2 @@
 [advisories]
-ignore = ["RUSTSEC-2025-0014"]
+ignore = []

Cargo.lock

@@ -18,7 +18,6 @@ opt-level = 3
 opt-level = 3
 
 [dependencies]
-ahash = "0.8.11"
 anyhow = "1.0.97"
 clap = { version = "4.5.35", features = ["derive"] }
 clap-verbosity-flag = "3.0.2"

Cargo.toml

@@ -71,7 +71,6 @@ feature-depth = 1
 # A list of advisory IDs to ignore. Note that ignored advisories will still
 # output a note when they are encountered.
 ignore = [
-  "RUSTSEC-2025-0014",
   # "RUSTSEC-0000-0000",
   # { id = "RUSTSEC-0000-0000", reason = "you can specify a reason the advisory is ignored" },
   # "[email protected]", # you can also ignore yanked crate versions if you wish
@@ -92,7 +91,6 @@ ignore = [
 # [possible values: any SPDX 3.11 short identifier (+ optional exception)].
 allow = [
   "Apache-2.0",
-  "BSD-2-Clause",
   "BSD-3-Clause",
   "ISC",
   "MIT",

deny.toml

@@ -1,3 +1,6 @@
+default:
+    just --list
+
 # find comments in Rust source
 comments:
     rg --pcre2 -t rust '(^|\s+)(\/\/|\/\*)\s+(?!(act|arrange|assert))' .

justfile

@@ -16,9 +16,12 @@ use super::SemverVersion;
 
 #[derive(Debug)]
 pub struct File {
-    dependencies: BTreeMap<String, CargoDependencyValue>,
+    dependencies: Option<BTreeMap<String, CargoDependencyValue>>,
     build_dependencies: Option<BTreeMap<String, CargoDependencyValue>>,
     dev_dependencies: Option<BTreeMap<String, CargoDependencyValue>>,
+
+    #[expect(dead_code)]
+    workspace_dependencies: Option<BTreeMap<String, CargoDependencyValue>>,
 }
 
 impl File {
@@ -31,6 +34,7 @@ impl File {
             dependencies,
             build_dependencies,
             dev_dependencies,
+            workspace_dependencies,
         } = current_cargo
             .try_deserialize::<CargoFile>()
             .with_context(|| format!("Error parsing `{path}`"))?;
@@ -42,6 +46,7 @@ impl File {
             dependencies,
             build_dependencies,
             dev_dependencies,
+            workspace_dependencies,
         })
     }
 
@@ -56,13 +61,15 @@ impl File {
             dependencies,
             build_dependencies,
             dev_dependencies,
+            workspace_dependencies,
         } = toml::from_str(toml_str).context("Creating `CargoFile` from str")?;
         log::trace!("Cargo: {dependencies:?}");
 
         Ok(Self {
             dependencies,
             build_dependencies,
             dev_dependencies,
+            workspace_dependencies,
         })
     }
 
@@ -285,9 +292,9 @@ impl File {
     pub fn print_changes_versus_previous_version(&self, previous: &Self) -> anyhow::Result<String> {
         let mut result: String = String::new();
 
-        Self::get_dependency_changes_versus_previous(
-            &self.dependencies,
-            &previous.dependencies,
+        Self::get_optional_dependency_changes_versus_previous(
+            self.dependencies.as_ref(),
+            previous.dependencies.as_ref(),
             None,
             &mut result,
         )?;
@@ -353,7 +360,8 @@ pub enum CargoDependencyValue {
 #[cfg_attr(test, derive(serde::Serialize))]
 #[serde(rename_all = "kebab-case")]
 pub struct CargoFile {
-    pub dependencies: BTreeMap<String, CargoDependencyValue>,
+    pub dependencies: Option<BTreeMap<String, CargoDependencyValue>>,
     pub build_dependencies: Option<BTreeMap<String, CargoDependencyValue>>,
     pub dev_dependencies: Option<BTreeMap<String, CargoDependencyValue>>,
+    pub workspace_dependencies: Option<BTreeMap<String, CargoDependencyValue>>,
 }

src/domain/cargo_toml/mod.rs

@@ -2,4 +2,4 @@
 source: src/domain/cargo_toml/tests.rs
 expression: "format!(\"{outcome:?}\")"
 ---
-File { dependencies: {"ahash": Simple("0.8.11"), "clap": Detailed(DetailedCargoDependency { version: "4.5.23", package: None }), "clap-verbosity-flag": Simple("3.0.1"), "config": Simple("0.14.1"), "env_logger": Simple("0.11.5"), "git2": Simple("0.19.0"), "log": Simple("0.4.22"), "serde": Detailed(DetailedCargoDependency { version: "1.0.215", package: None }), "sqlx": Detailed(DetailedCargoDependency { version: "0.8.2", package: None })}, build_dependencies: None, dev_dependencies: Some({"assert_fs": Simple("1.1.2"), "trycmd": Simple("0.15.8")}) }
+File { dependencies: Some({"ahash": Simple("0.8.11"), "clap": Detailed(DetailedCargoDependency { version: "4.5.23", package: None }), "clap-verbosity-flag": Simple("3.0.1"), "config": Simple("0.14.1"), "env_logger": Simple("0.11.5"), "git2": Simple("0.19.0"), "log": Simple("0.4.22"), "serde": Detailed(DetailedCargoDependency { version: "1.0.215", package: None }), "sqlx": Detailed(DetailedCargoDependency { version: "0.8.2", package: None })}), build_dependencies: None, dev_dependencies: Some({"assert_fs": Simple("1.1.2"), "trycmd": Simple("0.15.8")}), workspace_dependencies: None }

src/domain/cargo_toml/snapshots/rust_crate_diffs__domain__cargo_toml__tests__new_from_buffer_creates_expected_config.snap

@@ -53,28 +53,32 @@ fn new_successfully_parses_valid_cargo_toml_dependencies() {
     let File { dependencies, .. } = File::new(temporary_cargo_toml_path.to_str().unwrap()).unwrap();
 
     // assert
-    assert_eq!(dependencies.len(), 9);
+    assert!(dependencies.is_some());
+    let Some(dependencies_value) = dependencies else {
+        panic!("dependencies should be some");
+    };
+    assert_eq!(dependencies_value.len(), 9);
     assert_eq!(
-        dependencies.get("ahash"),
+        dependencies_value.get("ahash"),
         Some(CargoDependencyValue::Simple(String::from("0.8.11"))).as_ref()
     );
     assert_eq!(
-        dependencies.get("serde"),
+        dependencies_value.get("serde"),
         Some(CargoDependencyValue::Detailed(DetailedCargoDependency {
             version: String::from("1.0.215"),
             package: None
         }))
         .as_ref()
     );
     assert_eq!(
-        dependencies.get("sqlx"),
+        dependencies_value.get("sqlx"),
         Some(CargoDependencyValue::Detailed(DetailedCargoDependency {
             version: String::from("0.8.2"),
             package: None
         }))
         .as_ref()
     );
-    insta::assert_json_snapshot!(dependencies);
+    insta::assert_json_snapshot!(dependencies_value);
 }
 
 #[test]
@@ -112,7 +116,7 @@ fn new_handles_missing_cargo_toml() {
     assert!(chain.next().is_none());
 }
 #[test]
-fn new_handles_missing_dependencies_in_cargo_toml() {
+fn new_accetps_missing_dependencies_in_cargo_toml() {
     // arrange
     let temp_dir = assert_fs::TempDir::new().unwrap();
     let cargo_toml_content = r#"[package]
@@ -133,25 +137,10 @@ trycmd = "0.15.8"
     let temporary_cargo_toml_path = temp_dir.join("Cargo.toml");
 
     // act
-    let outcome = File::new(temporary_cargo_toml_path.to_str().unwrap()).unwrap_err();
+    let outcome = File::new(temporary_cargo_toml_path.to_str().unwrap());
 
     // assert
-    assert_eq!(
-        format!("{outcome}"),
-        format!("Error parsing `{}`", temporary_cargo_toml_path.display())
-    );
-    let mut chain = outcome.chain();
-    assert_eq!(
-        chain.next().map(|val| format!("{val}")),
-        Some(format!(
-            "Error parsing `{}`",
-            temporary_cargo_toml_path.display()
-        ))
-    );
-    assert_eq!(
-        chain.next().map(|val| format!("{val}")),
-        Some(String::from("missing field `dependencies`",))
-    );
+    assert!(outcome.is_ok());
 }
 
 #[test]