WIP NamingConventions/PrefixAllGlobals: improve prefix validation

Add a new error when validating prefixes if a prefix is not a string or is an empty string.

This is necessary in preparation for PHPCS 4.0. Starting with this version, array properties can have types other than string, and the sniff needs to be updated to handle non-string prefixes.

Using the same error when the string is empty made sense as before the sniff would generate an error complaining about the length of the prefix.

TODO: the value of the prefix is type casted to a string when displaying the error message. For example, `true` becomes `1`. I need to think if this is a problem or not.

Also, if `true` is passed as the first and only element of an array property there seems to be an error in PHPCS.

Check how PHPCSStandards/PHP_CodeSniffer#1172 and PHPCSStandards/PHP_CodeSniffer#1193 impact this commit.

Author: rodrigoprimo

WordPress/Sniffs/NamingConventions/PrefixAllGlobalsSniff.php

@@ -1221,6 +1221,16 @@ private function validate_prefixes() {
 		$prefixes    = array();
 		$ns_prefixes = array();
 		foreach ( $this->prefixes as $key => $prefix ) {
+            if ( is_string( $prefix ) === false || trim( $prefix ) === '' ) {
+                $this->phpcsFile->addError(
+                    'The prefix must be a non-empty string. Found: "%s".',
+                    0,
+                    'InvalidPrefixPassed',
+                    array( $prefix )
+                );
+                continue;
+            }
+
 			$prefixLC = strtolower( $prefix );
 
 			if ( isset( $this->prefix_blocklist[ $prefixLC ] ) ) {