WP/CapitalPDangit: add tests for namespaced names

Author: rodrigoprimo

WordPress/Tests/WP/CapitalPDangitUnitTest.1.inc

@@ -244,3 +244,12 @@ class TypeClassConstants {
 	// Ensures no false positives on incorrect casing in a class constant type name.
     public const (\Fully\Qualified\MyClass&wordPRESS)|string ANOTHER_WORDPRESS = 'wordpress';
 }
+
+/*
+ * Safeguard correct handling of all types of namespaced calls to the define() function.
+ */
+\DEFINE( 'WORDPRESS_SOMETHING', 'wordpress' ); // OK.
+MyNamespace\define( 'WORDPRESS_SOMETHING', 'wordpress' ); // Bad.
+\MyNamespace\Define( 'WORDPRESS_SOMETHING', 'wordpress' ); // Bad.
+namespace\Sub\define( 'WORDPRESS_SOMETHING', 'wordpress' ); // Bad.
+namespace\define( 'WORDPRESS_SOMETHING', 'wordpress' ); // The sniff should stop flagging this once it can resolve relative namespaces.

WordPress/Tests/WP/CapitalPDangitUnitTest.1.inc.fixed

@@ -244,3 +244,12 @@ class TypeClassConstants {
 	// Ensures no false positives on incorrect casing in a class constant type name.
     public const (\Fully\Qualified\MyClass&wordPRESS)|string ANOTHER_WORDPRESS = 'wordpress';
 }
+
+/*
+ * Safeguard correct handling of all types of namespaced calls to the define() function.
+ */
+\DEFINE( 'WORDPRESS_SOMETHING', 'wordpress' ); // OK.
+MyNamespace\define( 'WORDPRESS_SOMETHING', 'WordPress' ); // Bad.
+\MyNamespace\Define( 'WORDPRESS_SOMETHING', 'WordPress' ); // Bad.
+namespace\Sub\define( 'WORDPRESS_SOMETHING', 'WordPress' ); // Bad.
+namespace\define( 'WORDPRESS_SOMETHING', 'WordPress' ); // The sniff should stop flagging this once it can resolve relative namespaces.

WordPress/Tests/WP/CapitalPDangitUnitTest.php

@@ -69,6 +69,10 @@ public function getWarningList( $testFile = '' ) {
 					204 => 1,
 					205 => 1,
 					224 => 1,
+					252 => 1,
+					253 => 1,
+					254 => 1,
+					255 => 1,
 				);
 
 			case 'CapitalPDangitUnitTest.2.inc':