Arrays/ArrayDeclarationSpacing: replace "associative" with "keys"

Updates error messages and docblocks to use "arrays with keys" instead
of "associative arrays" to align with the PHP handbook terminology.

The sniff has always checked for arrays with explicit keys (whether
string or numeric), not just associative arrays with string keys.
This change aligns the wording with the actual behavior.

The public property `allow_single_item_single_line_associative_arrays`
and the error code `AssociativeArrayFound` are intentionally left
unchanged to avoid breaking changes for users who reference them in
their ruleset configurations.

Ref: wpcs-docs 156

Author: rodrigoprimo

WordPress/Sniffs/Arrays/ArrayDeclarationSpacingSniff.php

@@ -19,21 +19,21 @@
 /**
  * Enforces WordPress array spacing format.
  *
- * - Checks that associative arrays are multi-line.
+ * - Checks that arrays with keys are multi-line.
  * - Checks that each array item in a multi-line array starts on a new line.
  *
  * @link https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#indentation
  *
  * @since 0.11.0 - The WordPress specific additional checks have now been split off
  *                 from the `WordPress.Arrays.ArrayDeclaration` sniff into this sniff.
- *               - Added sniffing & fixing for associative arrays.
+ *               - Added sniffing & fixing for arrays with keys.
  * @since 0.12.0 Decoupled this sniff from the upstream sniff completely.
  *               This sniff now extends the WordPressCS native `Sniff` class instead.
  * @since 0.13.0 Added the last remaining checks from the `WordPress.Arrays.ArrayDeclaration`
  *               sniff which were not covered elsewhere.
  *               The `WordPress.Arrays.ArrayDeclaration` sniff has now been deprecated.
  * @since 0.13.0 Class name changed: this class is now namespaced.
- * @since 0.14.0 Single item associative arrays are now by default exempt from the
+ * @since 0.14.0 Single item arrays with keys are now by default exempt from the
  *               "must be multi-line" rule. This behavior can be changed using the
  *               `allow_single_item_single_line_associative_arrays` property.
  * @since 3.0.0  Removed various whitespace related checks and fixers in favor of the PHPCSExtra
@@ -42,7 +42,7 @@
 final class ArrayDeclarationSpacingSniff extends Sniff {
 
 	/**
-	 * Whether or not to allow single item associative arrays to be single line.
+	 * Whether or not to allow single item arrays with keys to be single line.
 	 *
 	 * @since 0.14.0
 	 *
@@ -102,7 +102,7 @@ public function process_token( $stackPtr ) {
 	}
 
 	/**
-	 * Check that associative arrays are always multi-line.
+	 * Check that arrays with keys are always multi-line.
 	 *
 	 * @since 0.13.0 The actual checks contained in this method used to
 	 *               be in the `process()` method.
@@ -137,9 +137,9 @@ protected function process_single_line_array( $stackPtr, $opener, $closer ) {
 		if ( false === $array_has_keys ) {
 			return;
 		}
-		$error = 'When an array uses associative keys, each value should start on %s.';
+		$error = 'When an array uses keys, each value should start on %s.';
 		if ( true === $this->allow_single_item_single_line_associative_arrays ) {
-			$error = 'When a multi-item array uses associative keys, each value should start on %s.';
+			$error = 'When a multi-item array uses keys, each value should start on %s.';
 		}
 
 		/*