WIP SanitizationHelperTrait: update for PHPCS 4.0

Need to check if this way is the best way to fix the problem and improve it (document, make more readable).

Author: rodrigoprimo

WordPress/Helpers/ArrayWalkingFunctionsHelper.php

@@ -71,7 +71,7 @@ public static function get_functions() {
 	 * @return bool
 	 */
 	public static function is_array_walking_function( $functionName ) {
-		return isset( self::$arrayWalkingFunctions[ strtolower( $functionName ) ] );
+		return isset( self::$arrayWalkingFunctions[ strtolower( ltrim( $functionName, '\\' ) ) ] );
 	}
 
 	/**
@@ -94,6 +94,11 @@ public static function get_callback_parameter( File $phpcsFile, $stackPtr ) {
 		}
 
 		$functionName = strtolower( $tokens[ $stackPtr ]['content'] );
+
+		if ( \T_NAME_FULLY_QUALIFIED === $tokens[ $stackPtr ]['code'] ) {
+			$functionName = ltrim( $functionName, '\\' );
+		}
+
 		if ( isset( self::$arrayWalkingFunctions[ $functionName ] ) === false ) {
 			return false;
 		}

WordPress/Helpers/SanitizationHelperTrait.php

@@ -239,7 +239,7 @@ final public function get_sanitizing_and_unslashing_functions() {
 	 * @return bool
 	 */
 	final public function is_sanitizing_function( $functionName ) {
-		return isset( $this->get_sanitizing_functions()[ strtolower( $functionName ) ] );
+		return isset( $this->get_sanitizing_functions()[ strtolower( ltrim( $functionName, '\\' ) ) ] );
 	}
 
 	/**
@@ -252,7 +252,7 @@ final public function is_sanitizing_function( $functionName ) {
 	 * @return bool
 	 */
 	final public function is_sanitizing_and_unslashing_function( $functionName ) {
-		return isset( $this->get_sanitizing_and_unslashing_functions()[ strtolower( $functionName ) ] );
+		return isset( $this->get_sanitizing_and_unslashing_functions()[ strtolower( ltrim( $functionName, '\\' ) ) ] );
 	}
 
 	/**

WordPress/Helpers/UnslashingFunctionsHelper.php

@@ -54,6 +54,6 @@ public static function get_functions() {
 	 * @return bool
 	 */
 	public static function is_unslashing_function( $functionName ) {
-		return isset( self::$unslashingFunctions[ strtolower( $functionName ) ] );
+		return isset( self::$unslashingFunctions[ strtolower( ltrim( $functionName, '\\' ) ) ] );
 	}
 }

WordPress/Tests/Helpers/SanitizationHelperTrait/IsSanitizedUnitTest.php

@@ -10,6 +10,7 @@
 namespace WordPressCS\WordPress\Tests\Helpers\SanitizationHelperTrait;
 
 use PHP_CodeSniffer\Files\File;
+use PHPCSUtils\BackCompat\Helper;
 use PHPCSUtils\TestUtils\UtilityMethodTestCase;
 use WordPressCS\WordPress\Helpers\SanitizationHelperTrait;
 
@@ -84,6 +85,9 @@ public function testIsSanitized( $testMarker, $expectedResult ) {
 	 * @see testIsSanitized()
 	 */
 	public static function dataIsSanitized() {
+		$phpcs_version = Helper::getVersion();
+		$is_phpcs_4    = version_compare( $phpcs_version, '3.99.99', '>' );
+
 		return array(
 			'not_sanitized_echo'                       => array(
 				'testMarker'     => '/* testNotSanitizedEcho */',
@@ -165,18 +169,21 @@ public static function dataIsSanitized() {
 				'testMarker'     => '/* testFullyQualifiedUnslashThenSanitized */',
 				'expectedResult' => true,
 			),
+
+			// These are false positives in PHPCS 3.x. See: https://github.com/WordPress/WordPress-Coding-Standards/issues/2665.
 			'namespaced_unslash_but_still_sanitized_1' => array(
 				'testMarker'     => '/* testNamespacedUnslashButStillSanitized1 */',
-				'expectedResult' => true,
+				'expectedResult' => ( true === $is_phpcs_4 ) ? false : true,
 			),
 			'namespaced_unslash_but_still_sanitized_2' => array(
 				'testMarker'     => '/* testNamespacedUnslashButStillSanitized2 */',
-				'expectedResult' => true,
+				'expectedResult' => ( true === $is_phpcs_4 ) ? false : true,
 			),
 			'namespaced_unslash_but_still_sanitized_3' => array(
 				'testMarker'     => '/* testNamespacedUnslashButStillSanitized3 */',
-				'expectedResult' => true,
+				'expectedResult' => ( true === $is_phpcs_4 ) ? false : true,
 			),
+
 			'int_cast'                                 => array(
 				'testMarker'     => '/* testIntCast */',
 				'expectedResult' => true,