reduced business process sleep functionality down to a single thread system instead of a thread per Sleep call.

Author: roger-castaldo

BpmEngine.csproj

@@ -4,16 +4,16 @@
     <TargetFrameworks>netstandard2.0;net452;net20</TargetFrameworks>
     <RootNamespace>Org.Reddragonit.BpmEngine</RootNamespace>
     <PackageId>Org.Reddragonit.BpmEngine</PackageId>
-    <Version>1.9.8</Version>
+    <Version>1.9.9</Version>
     <Authors>Roger Castaldo</Authors>
     <Description>A BPMN Engine written in .net. The engine attempts to read in a bpmn notation xml document defining both the process(s) as well as the diagrams. From here you can then load/unload the state, render the diagram in its current state or animated into a gif. Using the delegates for a process, you intercept and handle task and condition checking by reading additional xml held within flow and task objects.</Description>
     <PackageProjectUrl>https://github.com/roger-castaldo/BPMEngine</PackageProjectUrl>
     <PackageLicenseUrl>https://www.gnu.org/licenses/gpl-3.0.en.html</PackageLicenseUrl>
     <RepositoryUrl>https://github.com/roger-castaldo/BPMEngine</RepositoryUrl>
     <PackageTags>BPMN</PackageTags>
-    <PackageReleaseNotes>updated package to loosen up loading restrictions by not checking for xml prefix in valid documents</PackageReleaseNotes>
-    <AssemblyVersion>1.9.8.0</AssemblyVersion>
-    <FileVersion>1.9.8.0</FileVersion>
+    <PackageReleaseNotes>updated package to use a single control thread for the time delays in all business processes instead of multiple threads per process</PackageReleaseNotes>
+    <AssemblyVersion>1.9.9.0</AssemblyVersion>
+    <FileVersion>1.9.9.0</FileVersion>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
   </PropertyGroup>
 

BusinessProcess.cs

@@ -26,14 +26,15 @@ namespace Org.Reddragonit.BpmEngine
     /// the suspended state loaded and resumed.  It can also be cloned, including the current state and delegates in order to have more than once instance 
     /// of the given process executing.
     /// </summary>
-    public sealed class BusinessProcess
+    public sealed class BusinessProcess : IDisposable
     {
         private static readonly TimeSpan _ANIMATION_DELAY = new TimeSpan(0,0,1);
         private const int _DEFAULT_PADDING = 100;
         private const int _VARIABLE_NAME_WIDTH = 200;
         private const int _VARIABLE_VALUE_WIDTH = 300;
         private const int _VARIABLE_IMAGE_WIDTH = _VARIABLE_NAME_WIDTH+_VARIABLE_VALUE_WIDTH;
 
+        private Guid _id;
         private bool _isSuspended = false;
         private ManualResetEvent _mreSuspend;
         private List<object> _components;
@@ -470,6 +471,7 @@ public void ErrorManualTask(string taskID, Exception ex)
         #endregion
 
         private BusinessProcess() {
+            _id = Utility.NextRandomGuid();
             _processLock = new ManualResetEvent(false);
             _mreSuspend = new ManualResetEvent(false);
         }
@@ -541,6 +543,7 @@ public BusinessProcess(XmlDocument doc, LogLevels stateLogLevel, sProcessRuntime
         /// <param name="logLine">The LogLine delegate</param>
         public BusinessProcess(XmlDocument doc, LogLevels stateLogLevel,sProcessRuntimeConstant[] constants,LogLine logLine)
         {
+            _id = Utility.NextRandomGuid();
             _stateLogLevel = stateLogLevel;
             _constants = constants;
             _logLine = logLine;
@@ -676,8 +679,10 @@ public void Resume()
                 }
                 foreach (sStepSuspension ss in _state.SuspendedSteps)
                 {
-                    Thread th = new Thread(new ParameterizedThreadStart(_suspendEvent));
-                    th.Start((object)(new object[] { ss.id, ss.EndTime }));
+                    if (DateTime.Now.Ticks < ss.EndTime.Ticks)
+                        Utility.Sleep(ss.EndTime.Subtract(DateTime.Now), this, (AEvent)_GetElement(ss.id));
+                    else
+                        CompleteTimedEvent((AEvent)_GetElement(ss.id));
                 }
                 WriteLogLine(LogLevels.Info, new StackFrame(1, true), DateTime.Now, "Business Process Resume Complete");
             }
@@ -689,24 +694,6 @@ public void Resume()
             }
         }
 
-        private void _suspendEvent(object parameters)
-        {
-            _current = this;
-            string id = (string)((object[])parameters)[0];
-            DateTime release = (DateTime)((object[])parameters)[1];
-            TimeSpan ts = release.Subtract(DateTime.Now);
-            if (ts.TotalMilliseconds > 0)
-                Utility.Sleep(ts);
-            IElement elem = _GetElement(id);
-            if (elem != null)
-            {
-                AEvent evnt = (AEvent)elem;
-                lock (_state) { _state.Path.SucceedEvent(evnt); }
-                if (_onEventCompleted != null)
-                    _onEventCompleted(evnt, new ReadOnlyProcessVariablesContainer(evnt.id, _state, this));
-            }
-        }
-
         /// <summary>
         /// Called to render a PNG image of the process at its current state
         /// </summary>
@@ -1214,8 +1201,11 @@ private void _ProcessElement(string sourceID,IElement elem)
                                 _state.SuspendStep(evnt.id, ts.Value);
                             }
                             if (ts.Value.TotalMilliseconds > 0)
-                                Utility.Sleep(ts.Value);
-                            success = true;
+                            {
+                                Utility.Sleep(ts.Value, this, evnt);
+                                return;
+                            }else
+                                success = true;
                         }
                     }else if (_isEventStartValid != null && (evnt is IntermediateCatchEvent || evnt is StartEvent))
                     {
@@ -1341,6 +1331,13 @@ private void _ProcessElement(string sourceID,IElement elem)
             }
         }
 
+        internal void CompleteTimedEvent(AEvent evnt)
+        {
+            lock (_state) { _state.Path.SucceedEvent(evnt); }
+            if (_onEventCompleted != null)
+                _onEventCompleted(evnt, new ReadOnlyProcessVariablesContainer(evnt.id, _state, this));
+        }
+
         private void _MergeVariables(UserTask task, ProcessVariablesContainer variables, string completedByID)
         {
             _MergeVariables((ATask)task, variables, completedByID);
@@ -1450,5 +1447,17 @@ internal void WriteLogException(StackFrame sf, DateTime timestamp, Exception exc
                 _logException.Invoke(sf.GetMethod().DeclaringType.Assembly.GetName(), sf.GetFileName(), sf.GetFileLineNumber(), timestamp, exception);
         }
         #endregion
+
+        public void Dispose()
+        {
+            Utility.UnloadProcess(this);
+        }
+
+        public override bool Equals(object obj)
+        {
+            if (obj is BusinessProcess)
+                return ((BusinessProcess)obj)._id == _id;
+            return false;
+        }
     }
 }