SG-40929: Continued fixes based on QA. (AcademySoftwareFoundation#963)

### Summarize your change.

It turns out there were a few big holes in my previous PR for SG-40182.

* in rvui.mu and elsewhere, many bind() calls for keyboard events _(or
mouse inputs)_ that dont have equivalent menu item also needed
categorizations. There was a missing bind() overload in app_utils.mu. to
do this so it was added. This is by far the largest change.

* in app_utils.mu, calling the "compositeStateFunc()" could return
garbage (yet another mu bug, which I'm not fixing here) causing the
event func to be called even if the category was disabled. It was
replaced with a more straightforward check. (the bug seemed to happen
mostly if the handler func defined in menuItem() started with a leading
"~" before its name, eg, "~togglePlay")

* in mode_manager.mu, needed to add equivalent protections to
filterLiveReviewEvents() which got removed without an equivalent in the
shuffle.

* in annotate_mode.mu, needed to make disappear the paint tools if we
are in LR presenter mode (eg: annotate_categories is disabled)

* in scrub_offset.mu, needed to guard on scrubbing if playcontrol
category is disabled.

* more filterLiveReviewEvents were removed, and replaced with the
appropriate binding (or alternative to bind funcs)

---

Things to test, 

*_when in viewer mode:...._*

- fix: stepForward 1 or 100 frames is now blocked
- fix: stepBackward 1 or 100 frames is now blocked
- fix: motion scope popup menu is blocked
- fix: clicking and dragging in timeline/ motion scope is blocked
- fix: marking frames in timeline is blocked
- fix: setting point in timeline is blocked
- fix: annotate panel is closed 
- fix: cannot scrub in scrub_offset mode
- fix: rotate ibage is blocked
- fix: mousewheel to scrub is disabled
- fix: dragging in main view to scrub is blocked
- fix: doing space to play is blocked.


viewmode categories: 
ViewMode Categories were off in viewer mode before, but enabled now.
(toggle this category in live_review.py)

 viewmode key shortcuts:
- fix: kbd keys are blocked: M, alt-r, alt-l, shift-l, shift-r, ctrl-m,
down, p, pgup, pgdn.
- fix: kbd keys are blocked : aldkspmzvh,.<>OSorcR/

when in nudge mode...
- fix: kbd keys are blocked : left,right,up,down, control and shift
variations.
- fix: kbd keys are blocked : z, ctrl-z, alt-n, 



### Describe the reason for the change.

Stephen reported a few problems reported with being able to do some
things in LR that he shouldnt be able to do when in muc presenter mode.
(participant = viewer)

### Describe what you have tested and on which operating system.

macOS

### Add a list of changes, and note any that might need special
attention during the review.

### If possible, provide screenshots.

---------

Signed-off-by: Patrick Bergeron <patrick.bergeron@autodesk.com>

Author: pbergeron-adsk

src/lib/app/mu_rvui/app_utils.mu

@@ -25,6 +25,17 @@ MenuStateFunc   := (int;);
     \: (void; Event ignored) { f(); };
 }
 
+
+\: checkAndBlockEventCategory(bool; string category)
+{
+    if (!commands.isEventCategoryEnabled("category"))
+    {
+        sendInternalEvent("category-event-blocked", category);
+        return false;
+    }
+    return true;
+}
+
 \: makeCategoryEventFunc (EventFunc; string category, EventFunc f) {
     \: (void; Event ev) {
         if (!commands.isEventCategoryEnabled(category))
@@ -49,6 +60,11 @@ operator: ~ (EventFunc; VoidFunc f)
     bind(mode, table, event, makeCategoryEventFunc(category, makeEventFunc(F)), doc);
 }
 
+\: bind (void; string mode, string table, string event, string category, EventFunc F, string doc="")
+{
+    bind(mode, table, event, makeCategoryEventFunc(category, F), doc);
+}
+
 \: bind (void; string ev, VoidFunc F, string doc="") 
 { 
     bind("default", "global", ev, F, doc); 
@@ -209,7 +225,7 @@ operator: ~ (EventFunc; VoidFunc f)
 
     // create composite function that checks if the category is enabled and then calls the function
     let compositeFunc = \: (void; Event ev) {
-        if (compositeStateFunc() == DisabledMenuState)
+        if (!commands.isEventCategoryEnabled(category))
             sendInternalEvent("category-event-blocked", category);
         else
             func(ev);

src/lib/app/mu_rvui/extra_commands.mu

@@ -91,6 +91,7 @@ use glyph;
 use gl;
 use glu;
 use io;
+use app_utils;
 use mode_manager;
 require system;
 
@@ -384,20 +385,20 @@ require system;
 
 \: toggleForwardsBackwards (void;)
 {
-    if (filterLiveReviewEvents()) {
-        sendInternalEvent("live-review-blocked-event");
+    if (!checkAndBlockEventCategory("playcontrol_category"))
+    {
         return;
     }
+
     setInc(-inc());
     redraw();
 }
 
 \: toggleRealtime (void;)
 {
-    if (filterLiveReviewEvents()) {
-        sendInternalEvent("live-review-blocked-event");
+    if (!checkAndBlockEventCategory("playcontrol_category")) 
         return;
-    }
+
     State state = data();
 
     if (isRealtime())
@@ -462,10 +463,8 @@ require system;
 
 \: toggleFilter (void;)
 {
-    if (filterLiveReviewEvents()) {
-        sendInternalEvent("live-review-blocked-event");
+    if (!checkAndBlockEventCategory("viewmode_category")) 
         return;
-    }
 
     State state = data();
     setFiltering(if getFiltering() == GL_NEAREST then GL_LINEAR else GL_NEAREST);
@@ -487,10 +486,9 @@ require system;
 
 \: stepForward (void; int n)
 {
-    if (filterLiveReviewEvents()) {
-        sendInternalEvent("live-review-blocked-event");
+    if (!checkAndBlockEventCategory("playcontrol_category")) 
         return;
-    }
+
     let f = frame(),
         newFrame = frame() + n,
         inInOut = (inPoint() <= f && outPoint() >= f),
@@ -512,10 +510,9 @@ require system;
 
 \: stepBackward (void; int n)
 {
-    if (filterLiveReviewEvents()) {
-        sendInternalEvent("live-review-blocked-event");
+    if(!checkAndBlockEventCategory("playcontrol_category")) 
         return;
-    }
+
     let f = frame(),
         newFrame = frame() - n,
         inInOut = (inPoint() <= f && outPoint() >= f),

src/lib/app/mu_rvui/mode_manager.mu

@@ -213,13 +213,24 @@ class: ModeManagerMode : MinorMode
     {
         \: (int; )
         {
-            if (filterLiveReviewEvents())
-                then DisabledMenuState
-                else if entry.mode eq nil
-                     then UncheckedMenuState
-                     else if entry.mode._active
-                            then CheckedMenuState
-                            else UncheckedMenuState;
+            // Special handling of mode toggling if certain categories of actions are disabled.
+            if (!commands.isEventCategoryEnabled("annotate_category") && entry.name == "annotate_mode")
+            {
+                sendInternalEvent("category-event-blocked", "annotate_category");
+                return DisabledMenuState;
+            }
+    
+            if (!commands.isEventCategoryEnabled("media_category") && entry.name == "session_manager")
+            {
+                sendInternalEvent("category-event-blocked", "media_category");
+                return DisabledMenuState;
+            }
+    
+            if entry.mode eq nil
+                 then UncheckedMenuState
+                 else if entry.mode._active
+                        then CheckedMenuState
+                        else UncheckedMenuState;
         };
     }
 
@@ -426,6 +437,19 @@ class: ModeManagerMode : MinorMode
 
     \: toggleModeEntry (void; Event event, ModeEntry entry, ModeManagerMode mm)
     {
+        // Special handling of mode toggling if certain categories of actions are disabled.
+        if (!commands.isEventCategoryEnabled("annotate_category") && entry.name == "annotate_mode")
+        {
+            sendInternalEvent("category-event-blocked", "annotate_category");
+            return;
+        }
+
+        if (!commands.isEventCategoryEnabled("media_category") && entry.name == "session_manager")
+        {
+            sendInternalEvent("category-event-blocked", "media_category");
+            return;
+        }
+            
         mm.toggleEntry(entry);
     }
 

src/lib/app/mu_rvui/motion_scope.mu

@@ -376,10 +376,6 @@ class: MotionScope : Widget
 
     method: clickFunction (void; Event event, (void;int,int,int) F)
     {
-        if (filterLiveReviewEvents()) {
-            sendInternalEvent("live-review-blocked-event");
-            return;
-        }
         deb ("clickFunction");
 
         //   Disregard drag events if we didn't mouse-down in this widget.
@@ -704,11 +700,6 @@ class: MotionScope : Widget
 
     method: popupOpts (void; Event event)
     {
-        if (filterLiveReviewEvents()) {
-            sendInternalEvent("live-review-blocked-event");
-            return;
-        }
-
         if (isCurrentFrameIncomplete() ||!_pointerInMotionScope)
         {
             event.reject();
@@ -890,11 +881,11 @@ class: MotionScope : Widget
 
         _frameMap = int[]();
         init(name,
-             [ ("pointer-1--push", clickFunction(,setFrameOrNudge), "Set Frame On Magnifier"),
-               ("pointer-1--drag", clickFunction(,scrubSetFrame), "Drag Frame On Magnifier"),
-               ("pointer-1--shift--push", clickFunction(,setInOutPointDelayed("in",,,)), "Set In Point on Magnifier"),
-               ("pointer-1--shift--drag", clickFunction(,setInOutPointDelayed("out",,,)), "Select In/Out Region on Magnifier"),
-               ("pointer-3--push", popupOpts, "Popup Magnifier Options"),
+             [ ("pointer-1--push", makeCategoryEventFunc("playcontrol_category", clickFunction(,setFrameOrNudge)), "Set Frame On Magnifier"),
+               ("pointer-1--drag", makeCategoryEventFunc("playcontrol_category", clickFunction(,scrubSetFrame)), "Drag Frame On Magnifier"),
+               ("pointer-1--shift--push", makeCategoryEventFunc("playcontrol_category", clickFunction(,setInOutPointDelayed("in",,,))), "Set In Point on Magnifier"),
+               ("pointer-1--shift--drag", makeCategoryEventFunc("playcontrol_category", clickFunction(,setInOutPointDelayed("out",,,))), "Select In/Out Region on Magnifier"),
+               ("pointer-3--push", makeCategoryEventFunc("playcontrol_category", popupOpts), "Popup Magnifier Options"),
                ("pointer--move", handleMotion, ""),
                ("pointer--leave", handleLeave, "Track pointer leave"),
                ("pointer-1--shift--release", releaseDrag, ""),