Skip to content

Commit f53b991

Browse files
committed
CI: downgrade from macos-12, drop test-gotip
Per #200, macos-12 can cause sporadic `signal: killed` testscript failures, and we have started seeing them in some jobs within go-internal itself as well. Downgrade to macos-11 for now, like we've done in other projects, as we still don't know the cause. Also drop test-gotip; we haven't been keeping it up to date for a while now, so it's clearly not needed at the moment. If we want to ensure that go-internal works on new major versions of Go before they are released, using the beta or RC releases seems like a better and easier approach.
1 parent 00e5e28 commit f53b991

File tree

1 file changed

+1
-28
lines changed

1 file changed

+1
-28
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
- '1.19.x'
1717
os:
1818
- ubuntu-latest
19-
- macos-latest
19+
- macos-11
2020
- windows-latest
2121
runs-on: ${{ matrix.os }}
2222
steps:
@@ -38,30 +38,3 @@ jobs:
3838
3939
test -z "$(gofmt -d .)" || (gofmt -d . && false)
4040
test -z "$(git status --porcelain)" || (git status; git diff && false)
41-
42-
test-gotip:
43-
runs-on: ubuntu-latest
44-
continue-on-error: true # master breaks sometimes
45-
steps:
46-
- name: Install Go
47-
env:
48-
GO_COMMIT: 2cfbef438049fd4c3f73d1562773ad1f93900897 # 2022-06-09
49-
run: |
50-
cd $HOME
51-
mkdir $HOME/gotip
52-
cd $HOME/gotip
53-
54-
wget -O gotip.tar.gz https://go.googlesource.com/go/+archive/${GO_COMMIT}.tar.gz
55-
tar -xf gotip.tar.gz
56-
echo "devel go1.19-${GO_COMMIT}" >VERSION
57-
58-
cd src
59-
./make.bash
60-
echo "GOROOT=$HOME/gotip" >>$GITHUB_ENV
61-
echo "$HOME/gotip/bin" >>$GITHUB_PATH
62-
- name: Checkout code
63-
uses: actions/checkout@v3
64-
- name: Test
65-
run: |
66-
go version
67-
go test ./...

0 commit comments

Comments
 (0)