Revert "tests: BackgroundPsql: Fix potential for lost errors on windows"

This reverts commit 72a590b.

Author: anju15bharti

src/test/perl/PostgreSQL/Test/BackgroundPsql.pm

@@ -89,8 +89,7 @@ sub new
 		'stdin' => '',
 		'stdout' => '',
 		'stderr' => '',
-		'query_timer_restart' => undef,
-		'query_cnt' => 1,
+		'query_timer_restart' => undef
 	};
 	my $run;
 
@@ -152,25 +151,11 @@ sub wait_connect
 	# connection failures are caught here, relieving callers of the need to
 	# handle those.  (Right now, we have no particularly good handling for
 	# errors anyway, but that might be added later.)
-	#
-	# See query() for details about why/how the banner is used.
 	my $banner = "background_psql: ready";
-	my $banner_match = qr/(^|\n)$banner\r?\n/;
-	$self->{stdin} .= "\\echo $banner\n\\warn $banner\n";
+	$self->{stdin} .= "\\echo $banner\n";
 	$self->{run}->pump()
-	  until ($self->{stdout} =~ /$banner_match/
-		  && $self->{stderr} =~ /$banner\r?\n/)
-	  || $self->{timeout}->is_expired;
-
-	note "connect output:\n",
-	  explain {
-		stdout => $self->{stdout},
-		stderr => $self->{stderr},
-	  };
-
-	# clear out banners
-	$self->{stdout} = '';
-	$self->{stderr} = '';
+	  until $self->{stdout} =~ /$banner/ || $self->{timeout}->is_expired;
+	$self->{stdout} = '';    # clear out banner
 
 	die "psql startup timed out" if $self->{timeout}->is_expired;
 }
@@ -237,57 +222,27 @@ sub query
 	my ($self, $query) = @_;
 	my $ret;
 	my $output;
-	my $query_cnt = $self->{query_cnt}++;
-
 	local $Test::Builder::Level = $Test::Builder::Level + 1;
 
-	note "issuing query $query_cnt via background psql: $query";
+	note "issuing query via background psql: $query";
 
 	$self->{timeout}->start() if (defined($self->{query_timer_restart}));
 
 	# Feed the query to psql's stdin, followed by \n (so psql processes the
 	# line), by a ; (so that psql issues the query, if it doesn't include a ;
-	# itself), and a separator echoed both with \echo and \warn, that we can
-	# wait on.
-	#
-	# To avoid somehow confusing the separator from separately issued queries,
-	# and to make it easier to debug, we include a per-psql query counter in
-	# the separator.
-	#
-	# We need both \echo (printing to stdout) and \warn (printing to stderr),
-	# because on windows we can get data on stdout before seeing data on
-	# stderr (or vice versa), even if psql printed them in the opposite
-	# order. We therefore wait on both.
-	#
-	# We need to match for the newline, because we try to remove it below, and
-	# it's possible to consume just the input *without* the newline. In
-	# interactive psql we emit \r\n, so we need to allow for that. Also need
-	# to be careful that we don't e.g. match the echoed \echo command, rather
-	# than its output.
-	my $banner = "background_psql: QUERY_SEPARATOR $query_cnt:";
-	my $banner_match = qr/(^|\n)$banner\r?\n/;
-	$self->{stdin} .= "$query\n;\n\\echo $banner\n\\warn $banner\n";
-	pump_until(
-		$self->{run}, $self->{timeout},
-		\$self->{stdout}, qr/$banner_match/);
-	pump_until(
-		$self->{run}, $self->{timeout},
-		\$self->{stderr}, qr/$banner_match/);
+	# itself), and a separator echoed with \echo, that we can wait on.
+	my $banner = "background_psql: QUERY_SEPARATOR";
+	$self->{stdin} .= "$query\n;\n\\echo $banner\n";
 
-	die "psql query timed out" if $self->{timeout}->is_expired;
-
-	note "results query $query_cnt:\n",
-	  explain {
-		stdout => $self->{stdout},
-		stderr => $self->{stderr},
-	  };
+	pump_until($self->{run}, $self->{timeout}, \$self->{stdout}, qr/$banner/);
 
-	# Remove banner from stdout and stderr, our caller doesn't care.  The
-	# first newline is optional, as there would not be one if consuming an
-	# empty query result.
+	die "psql query timed out" if $self->{timeout}->is_expired;
 	$output = $self->{stdout};
-	$output =~ s/$banner_match//;
-	$self->{stderr} =~ s/$banner_match//;
+
+	# Remove banner again, our caller doesn't care.  The first newline is
+	# optional, as there would not be one if consuming an empty query
+	# result.
+	$output =~ s/\n?$banner\n$//s;
 
 	# clear out output for the next query
 	$self->{stdout} = '';