Skip to content

Update calculator.py #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rohitvinnakota-codecov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update calculator.py #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/calculator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,6 @@ def divide(x, y):
if y == 0:
return 'Cannot divide by 0'
return x * 1.0 / y

def zero(x, y):
return 0 + x + y - x + 2 * x + 3 * y
Comment on lines +18 to +19
Copy link
Owner Author

@rohitvinnakota-codecov rohitvinnakota-codecov Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function has an indentation issue. Based on the class structure, this should be a method of the Calculator class and needs proper indentation to align with other methods. Also, it's missing the self parameter that's required for instance methods.

Suggested change
def zero(x, y):
return 0 + x + y - x + 2 * x + 3 * y
def zero(self, x, y):
return 0 + x + y - x + 2 * x + 3 * y

Did we get this right? 👍 / 👎 to inform future reviews.