Skip to content

Commit 4df2d3c

Browse files
authored
Add actor, bindables and remotes to json_model_classes (#1199)
1 parent 4965165 commit 4df2d3c

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,14 @@ Making a new release? Simply add the new header with the version and date undern
3333

3434
* Fixed a bug caused by having reference properties (such as `ObjectValue.Value`) that point to an Instance not included in syncback. ([#1179])
3535
* Fixed instance replacement fallback failing when too many instances needed to be replaced. ([#1192])
36+
* Added actors and bindable/remote event/function variants to be synced back as JSON files. ([#1199])
3637
* Fixed a bug where MacOS paths weren't being handled correctly. ([#1201])
3738
* Fixed a bug where the notification timeout thread would fail to cancel on unmount ([#1211])
3839
* Added a "Forget" option to the sync reminder notification to avoid being reminded for that place in the future ([#1215])
3940

4041
[#1179]: https://github.com/rojo-rbx/rojo/pull/1179
4142
[#1192]: https://github.com/rojo-rbx/rojo/pull/1192
43+
[#1199]: https://github.com/rojo-rbx/rojo/pull/1199
4244
[#1201]: https://github.com/rojo-rbx/rojo/pull/1201
4345
[#1211]: https://github.com/rojo-rbx/rojo/pull/1211
4446
[#1215]: https://github.com/rojo-rbx/rojo/pull/1215

src/syncback/mod.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -301,6 +301,7 @@ pub fn get_best_middleware(snapshot: &SyncbackSnapshot) -> Middleware {
301301
static JSON_MODEL_CLASSES: OnceLock<HashSet<&str>> = OnceLock::new();
302302
let json_model_classes = JSON_MODEL_CLASSES.get_or_init(|| {
303303
[
304+
"Actor",
304305
"Sound",
305306
"SoundGroup",
306307
"Sky",
@@ -318,6 +319,11 @@ pub fn get_best_middleware(snapshot: &SyncbackSnapshot) -> Middleware {
318319
"ChatInputBarConfiguration",
319320
"BubbleChatConfiguration",
320321
"ChannelTabsConfiguration",
322+
"RemoteEvent",
323+
"UnreliableRemoteEvent",
324+
"RemoteFunction",
325+
"BindableEvent",
326+
"BindableFunction",
321327
]
322328
.into()
323329
});

0 commit comments

Comments
 (0)