Review feedback

Author: rok

cpp/src/arrow/compute/kernels/scalar_temporal_binary.cc

@@ -53,13 +53,13 @@ using chrono::weeks;
 using chrono::year_month_day;
 using chrono::year_month_weekday;
 using chrono::years;
-using chrono::literals::dec;
-using chrono::literals::jan;
-using chrono::literals::last;
-using chrono::literals::mon;
-using chrono::literals::sun;
-using chrono::literals::thu;
-using chrono::literals::wed;
+using chrono::dec;
+using chrono::jan;
+using chrono::last;
+using chrono::mon;
+using chrono::sun;
+using chrono::thu;
+using chrono::wed;
 using internal::applicator::ScalarBinaryNotNullStatefulEqualTypes;
 
 using DayOfWeekState = OptionsWrapper<DayOfWeekOptions>;

cpp/src/arrow/compute/kernels/scalar_temporal_test.cc

@@ -39,10 +39,6 @@ using internal::StringFormatter;
 
 namespace compute {
 
-TEST(ChronoConfig, LogChronoBackend) {
-  std::cout << "ARROW_USE_STD_CHRONO=" << ARROW_USE_STD_CHRONO << std::endl;
-}
-
 class ScalarTemporalTest : public ::testing::Test {
  public:
   const char* date32s =

cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc

@@ -60,13 +60,13 @@ using chrono::year;
 using chrono::year_month_day;
 using chrono::year_month_weekday;
 using chrono::years;
-using chrono::literals::dec;
-using chrono::literals::jan;
-using chrono::literals::last;
-using chrono::literals::mon;
-using chrono::literals::sun;
-using chrono::literals::thu;
-using chrono::literals::wed;
+using chrono::dec;
+using chrono::jan;
+using chrono::last;
+using chrono::mon;
+using chrono::sun;
+using chrono::thu;
+using chrono::wed;
 using std::chrono::duration_cast;
 using std::chrono::hours;
 using std::chrono::minutes;

cpp/src/arrow/util/chrono_internal.h

@@ -156,21 +156,15 @@ std::string format(const char* fmt, const Duration& d) {
   return std::vformat(std::string("{:") + fmt + "}", std::make_format_args(d));
 }
 
-// Literals namespace
-namespace literals {
-// Month literals
 inline constexpr std::chrono::month jan = std::chrono::January;
 inline constexpr std::chrono::month dec = std::chrono::December;
 
-// Weekday literals
 inline constexpr std::chrono::weekday sun = std::chrono::Sunday;
 inline constexpr std::chrono::weekday mon = std::chrono::Monday;
 inline constexpr std::chrono::weekday wed = std::chrono::Wednesday;
 inline constexpr std::chrono::weekday thu = std::chrono::Thursday;
 
-// last specifier
 inline constexpr std::chrono::last_spec last = std::chrono::last;
-}  // namespace literals
 
 #else  // !ARROW_USE_STD_CHRONO
 
@@ -251,8 +245,6 @@ std::basic_ostream<CharT, Traits>& to_stream(
   return vendored::to_stream(os, fmt, zt);
 }
 
-// Literals namespace
-namespace literals {
 inline constexpr vendored::month jan = vendored::jan;
 inline constexpr vendored::month dec = vendored::dec;
 
@@ -262,7 +254,6 @@ inline constexpr vendored::weekday wed = vendored::wed;
 inline constexpr vendored::weekday thu = vendored::thu;
 
 inline constexpr vendored::last_spec last = vendored::last;
-}  // namespace literals
 
 #endif  // ARROW_USE_STD_CHRONO