Skip to content

Commit c5d1df2

Browse files
committed
Fix R's tzdb
1 parent adadc8f commit c5d1df2

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

cpp/src/arrow/config.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
#include "arrow/util/config.h"
2323
#include "arrow/util/config_internal.h"
2424
#include "arrow/util/cpu_info.h"
25-
#include "arrow/vendored/datetime.h"
2625

2726
namespace arrow {
2827

cpp/src/arrow/util/chrono_internal.h

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,17 +33,18 @@
3333
#include <string_view>
3434

3535
// Feature detection for C++20 chrono timezone support
36-
// We only enable for compilers with FULL support (not partial)
3736
// https://en.cppreference.com/w/cpp/compiler_support/20.html#cpp_lib_chrono_201907L
3837
//
38+
// On Windows with MSVC: std::chrono uses Windows' internal timezone database,
39+
// eliminating the need for users to install IANA tzdata separately.
40+
//
41+
// On Windows with MinGW/GCC: libstdc++ reads tzdata files via TZDIR env var.
42+
// The tzdata files must be provided (e.g., via the tzdb R package).
43+
//
3944
// On non-Windows: GCC libstdc++ has a bug where DST state is incorrectly reset when
4045
// a timezone transitions between rule sets (e.g., Australia/Broken_Hill around
4146
// 2000-02-29). Until this is fixed, we use the vendored date.h library.
4247
// See: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116110
43-
//
44-
// On Windows: Use std::chrono which accesses Windows' internal timezone database,
45-
// eliminating the need for users to install IANA tzdata separately. We tolerate
46-
// the GCC bug here since Windows users are less likely to be using GCC.
4748

4849
#if defined(_WIN32) && defined(__cpp_lib_chrono) && __cpp_lib_chrono >= 201907L
4950
# define ARROW_USE_STD_CHRONO 1

0 commit comments

Comments
 (0)