Skip to content

Commit 9e7e9c1

Browse files
lovepoemchickenlj
authored andcommitted
Merge pull request apache#780, fix dubbo admin console display error
1 parent 4523795 commit 9e7e9c1

File tree

4 files changed

+31
-9
lines changed

4 files changed

+31
-9
lines changed

dubbo-admin/src/main/java/com/alibaba/dubbo/governance/web/governance/module/screen/Providers.java

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,10 @@
2323
import javax.servlet.http.HttpServletResponse;
2424
import java.util.ArrayList;
2525
import java.util.HashMap;
26+
import java.util.HashSet;
2627
import java.util.List;
2728
import java.util.Map;
29+
import java.util.Set;
2830

2931
/**
3032
* <p>Providers.</p>
@@ -107,11 +109,35 @@ else if (application != null && application.length() > 0) {
107109
}
108110

109111
context.put("providers", providers);
112+
context.put("serviceAppMap", getServiceAppMap(providers));
110113

111114
// 设置搜索结果到cookie中
112115
setSearchHistroy(context, value);
113116
}
114117

118+
/**
119+
* @author WangXin
120+
* 计算各个服务对应的应用列表,方便页面对"重复"的提示
121+
* @param providers app services
122+
*/
123+
private Map<String, Set<String>> getServiceAppMap(List<Provider> providers) {
124+
Map<String, Set<String>> serviceAppMap = new HashMap<String, Set<String>>();
125+
if (providers != null && providers.size() >= 0) {
126+
for (Provider provider : providers) {
127+
Set<String> appSet;
128+
String service = provider.getService();
129+
if (serviceAppMap.get(service) == null) {
130+
appSet = new HashSet<String>();
131+
} else {
132+
appSet = serviceAppMap.get(service);
133+
}
134+
appSet.add(provider.getApplication());
135+
serviceAppMap.put(service, appSet);
136+
}
137+
}
138+
return serviceAppMap;
139+
}
140+
115141
/**
116142
* 设置search记录到cookie中,操作步骤:
117143
* 检查加入的记录是否已经存在cookie中,如果存在,则更新列表次序;如果不存在,则插入到最前面

dubbo-admin/src/main/webapp/WEB-INF/i18n/message_zh.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -456,7 +456,7 @@ confirm.batch.tostatic=\u786e\u5b9a\u8f6c\u4e3a\u9759\u6001\u6240\u9009\u9879?
456456
confirm.batch.todynamic=\u786e\u5b9a\u8f6c\u4e3a\u52a8\u6001\u6240\u9009\u9879?
457457
current.user=\u5f53\u524d\u7528\u6237
458458
CheckProviderLocalAddress={0}\u4E0D\u662F\u6709\u6548\u7684\u8FDC\u7A0B\u670D\u52A1\u5730\u5740\uFF0C\u8BF7\u68C0\u67E5\u63D0\u4F9B\u65B9/etc/hosts\u6620\u5C04\u662F\u5426\u6B63\u786E\u3002
459-
CheckProviderApplicationDifferent=\u591a\u4e2a\u4e0d\u540c\u5e94\u7528\u6ce8\u518c\u4e86\u76f8\u540c\u670d\u52a1\uFF0C\u8BF7\u68C0\u67E5{0}\u548C{1}\u4E2D\u662F\u5426\u6709\u8BEF\u66B4\u9732\u3002
459+
CheckProviderApplicationDifferent=\u591a\u4e2a\u4e0d\u540c\u5e94\u7528\u6ce8\u518c\u4e86\u76f8\u540c\u670d\u52a1\uff0c\u8bf7\u68c0\u67e5{0}\u4e2d\u662f\u5426\u6709\u8bef\u66b4\u9732\u3002
460460
CheckProviderAddressMismatch=\u670d\u52a1URL\u4e0a\u7684IP\u4e0e\u8fde\u63a5\u6ce8\u518c\u4e2d\u5fc3\u7684IP\u4e0d\u76f8\u540c
461461
CheckConnectionDisconnected=\u8be5\u8fde\u63a5\u5df2\u65ad\u5f00\uff0c\u6570\u636e\u5e93\u810f\u6570\u636e\uff0c\u8bf7\u70b9\u51fb\u201c\u91cd\u8fde\u201d
462462
CheckConnectionExpired=\u8be5\u8fde\u63a5\u6240\u5728\u6ce8\u518c\u4e2d\u5fc3\u5df2\u4e0d\u5b58\u5728\uff08\u6570\u636e\u4f1a\u81ea\u52a8\u5b9a\u671f\u6e05\u7406\uff09

dubbo-admin/src/main/webapp/WEB-INF/i18n/message_zh_TW.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,7 @@ confirm.batch.tostatic=\u78ba\u5b9a\u8f49\u70ba\u975c\u614b\u6240\u9078\u9805?
424424
confirm.batch.todynamic=\u78ba\u5b9a\u8f49\u70ba\u52d5\u614b\u6240\u9078\u9805?
425425
current.user=\u7576\u524d\u7528\u6236
426426
CheckProviderAddressMismatch=\u670d\u52d9URL\u4e0a\u7684IP\u8207\u9023\u63a5\u8a3b\u518a\u4e2d\u5fc3\u7684IP\u4e0d\u76f8\u540c
427-
CheckProviderApplicationDifferent=\u591a\u500b\u4e0d\u540c\u61c9\u7528\u8a3b\u518a\u4e86\u76f8\u540c\u670d\u52d9
427+
CheckProviderApplicationDifferent=\u591a\u500b\u4e0d\u540c\u61c9\u7528\u8a3b\u518a\u4e86\u76f8\u540c\u670d\u52d9\uff0c\u8acb\u6aa2\u67e5{0}\u4e2d\u662f\u5426\u6709\u8aa4\u66b4\u9732\u3002
428428
CheckConnectionDisconnected=\u8a72\u9023\u63a5\u5df2\u65b7\u958b\uff0c\u8cc7\u6599\u5eab\u9ad2\u8cc7\u6599\uff0c\u8acb\u9ede\u64ca\u201c\u91cd\u9023\u201d
429429
CheckConnectionExpired=\u8a72\u9023\u63a5\u6240\u5728\u8a3b\u518a\u4e2d\u5fc3\u5df2\u4e0d\u5b58\u5728\uff08\u8cc7\u6599\u6703\u81ea\u52d5\u5b9a\u671f\u6e05\u7406\uff09
430430
CheckDatabaseMiss=\u8cc7\u6599\u5eab\u8cc7\u6599\u610f\u5916\u4e1f\u5931\u6b64\u8cc7\u6599\uff0c\u8acb\u9ede\u64ca\u201c\u6062\u5fa9\u201d

dubbo-admin/src/main/webapp/WEB-INF/templates/governance/screen/providers/index.vm

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -88,15 +88,11 @@
8888
<td>
8989
#set($errorLevel = "ok")
9090
#set($errorMessage = "")
91-
92-
#if ($providerApplication == "")
93-
#set($providerApplication = $provider.application)
94-
#end
95-
96-
#if($providerApplication != $provider.application)
91+
#set($appList = $!serviceAppMap.get($provider.service))
92+
#if($appList.size()>1)
9793
#if ($errorLevel != "error") #set($errorLevel = "warn") #end
9894
#set($errorMessage ="$errorMessage<br>$i18n.get('warn'): $i18n.get(
99-
'CheckProviderApplicationDifferent', $providerApplication, $provider.application)")
95+
'CheckProviderApplicationDifferent', $appList)")
10096
#end
10197

10298
#if($provider.address.startsWith("127.") || $provider.address.startsWith(

0 commit comments

Comments
 (0)