|
1 | 1 | # Recent commits data for Jekyll |
2 | 2 | # Auto-generated by GitHub Actions |
3 | 3 | commits: |
| 4 | +- sha: "41d42b01a633bfd991afef31f08cdef13b780265" |
| 5 | + date: "July 31, 2025" |
| 6 | + author: "Rolfe Dlugy-Hegwer" |
| 7 | + subject: "Based on my analysis of the upstream commits from Vale issue #98, I've successfully implemented the following improvements to our EntityReference rule:" |
| 8 | + body: " 1. Support for +normal Substitution Pattern |
| 9 | +
|
| 10 | + The upstream commits showed that Vale now recognizes subs="+normal" as enabling entity replacements. I've updated our _parse_subs_value method to handle this |
| 11 | + pattern correctly, where +normal adds all normal substitutions (including replacements) to the code block. |
| 12 | + |
| 13 | + 2. Proper Handling of -replacements Modifier |
| 14 | + |
| 15 | + The upstream implementation checks for explicit disabling of replacements with -replacements. Our implementation already supported this through the modifier |
| 16 | + parsing logic, and I've added a specific test case to verify it works correctly. |
| 17 | + |
| 18 | + 3. Enhanced Test Coverage |
| 19 | + |
| 20 | + I've added two new test cases: |
| 21 | + - test_subs_plus_normal_fixes: Verifies that subs="+normal" enables entity fixing |
| 22 | + - test_subs_minus_replacements_no_fix: Verifies that subs="normal,-replacements" disables entity fixing |
| 23 | + |
| 24 | + 4. Updated Documentation |
| 25 | + |
| 26 | + I've enhanced the documentation in ENTITY_REFERENCE_HANDLING.md to include examples of: |
| 27 | + - The +normal pattern |
| 28 | + - The -replacements modifier pattern |
| 29 | + - Clear explanations of when entities are processed vs. remain literal |
| 30 | + |
| 31 | + Key Improvements Summary: |
| 32 | + |
| 33 | + - ✅ Entities in code blocks with subs="+normal" are now correctly converted |
| 34 | + - ✅ Entities in code blocks with subs="normal,-replacements" remain literal |
| 35 | + - ✅ The rule respects AsciiDoc's substitution model more accurately |
| 36 | + - ✅ 13 out of 14 tests pass (nested code blocks remain a known limitation) |
| 37 | + |
| 38 | + The implementation now aligns more closely with the upstream Vale rules while maintaining our Aditi-specific logic for automatic fixing. |
| 39 | +" |
| 40 | +
|
| 41 | +- sha: "4d45a658bcad164cbb74f9f76199b69d2fff33ab" |
| 42 | + date: "August 01, 2025" |
| 43 | + author: "GitHub Action" |
| 44 | + subject: "Update recent commits data [skip ci]" |
| 45 | + body: "" |
| 46 | + |
4 | 47 | - sha: "eaaf3d280a1ba91816adaf8a2eb1d8ad71977505" |
5 | 48 | date: "July 31, 2025" |
6 | 49 | author: "Rolfe Dlugy-Hegwer" |
@@ -56,22 +99,3 @@ Fixes #18 |
56 | 99 |
|
57 | 100 | Co-Authored-By: Claude <noreply@anthropic.com> |
58 | 101 | " |
59 | | - |
60 | | -- sha: "763e92bf983a07aa6099d238bcfe200ac9c9e191" |
61 | | - date: "July 31, 2025" |
62 | | - author: "GitHub Action" |
63 | | - subject: "Update recent commits data [skip ci]" |
64 | | - body: "" |
65 | | - |
66 | | -- sha: "6228a73cb478e7359ec297a5418c109341b24e29" |
67 | | - date: "July 31, 2025" |
68 | | - author: "Rolfe Dlugy-Hegwer" |
69 | | - subject: "chore: Bump version to 0.1.7" |
70 | | - body: "- Fix typer[all] installation conflict issue |
71 | | -- Handle journey workflow when no violations exist |
72 | | -- Add troubleshooting documentation |
73 | | -
|
74 | | -🤖 Generated with [Claude Code](https://claude.ai/code) |
75 | | -
|
76 | | -Co-Authored-By: Claude <noreply@anthropic.com> |
77 | | -" |
|
0 commit comments