tweak eslint settings

Drop the complexity to 32 and use the string constants which are self
explanitory rather than the number constants when configuring eslintrc.

Author: terencehonles

.eslintrc

@@ -16,14 +16,14 @@
   ],
   "globals": { "Promise": true },
   "rules": {
-    "strict": 0,
-    "camelcase": [2, {"properties": "never"}],
-    "quotes": [2, "single", "avoid-escape"],
-    "no-underscore-dangle": 0,
-    "no-useless-escape": 0,
-    "complexity": [2, { "max": 35 }],
-    "no-use-before-define": [0, { "functions": false }],
-    "no-unused-vars": [2, { "argsIgnorePattern": "^_" }],
-    "no-prototype-builtins": 0
+    "strict": "off",
+    "camelcase": ["error", {"properties": "never"}],
+    "quotes": ["error", "single", "avoid-escape"],
+    "no-underscore-dangle": "off",
+    "no-useless-escape": "off",
+    "complexity": ["error", {"max": 32}],
+    "no-use-before-define": ["off", { "functions": false }],
+    "no-unused-vars": ["error", { "argsIgnorePattern": "^_" }],
+    "no-prototype-builtins": "off"
   }
 }

src/browser/shim.js

@@ -7,9 +7,8 @@ function _wrapInternalErr(f) {
       return f.apply(this, arguments);
     } catch (e) {
       try {
-        /* eslint-disable no-console */
+        /* eslint-disable-next-line no-console */
         console.error('[Rollbar]: Internal error', e);
-        /* eslint-enable no-console */
       } catch (e2) {
         // Ignore
       }

src/browser/telemetry.js

@@ -120,41 +120,46 @@ Instrumenter.prototype.configure = function(options) {
   }
 };
 
-// eslint-disable-next-line complexity
 Instrumenter.prototype.instrument = function(oldSettings) {
-  if (this.autoInstrument.network && !(oldSettings && oldSettings.network)) {
+  var network = oldSettings && oldSettings.network;
+  if (this.autoInstrument.network && !network) {
     this.instrumentNetwork();
-  } else if (!this.autoInstrument.network && oldSettings && oldSettings.network) {
+  } else if (!this.autoInstrument.network && network) {
     this.deinstrumentNetwork();
   }
 
-  if (this.autoInstrument.log && !(oldSettings && oldSettings.log)) {
+  var log = oldSettings && oldSettings.log;
+  if (this.autoInstrument.log && !log) {
     this.instrumentConsole();
-  } else if (!this.autoInstrument.log && oldSettings && oldSettings.log) {
+  } else if (!this.autoInstrument.log && log) {
     this.deinstrumentConsole();
   }
 
-  if (this.autoInstrument.dom && !(oldSettings && oldSettings.dom)) {
+  var dom = oldSettings && oldSettings.dom;
+  if (this.autoInstrument.dom && !dom) {
     this.instrumentDom();
-  } else if (!this.autoInstrument.dom && oldSettings && oldSettings.dom) {
+  } else if (!this.autoInstrument.dom && dom) {
     this.deinstrumentDom();
   }
 
-  if (this.autoInstrument.navigation && !(oldSettings && oldSettings.navigation)) {
+  var navigation = oldSettings && oldSettings.navigation;
+  if (this.autoInstrument.navigation && !navigation) {
     this.instrumentNavigation();
-  } else if (!this.autoInstrument.navigation && oldSettings && oldSettings.navigation) {
+  } else if (!this.autoInstrument.navigation && navigation) {
     this.deinstrumentNavigation();
   }
 
-  if (this.autoInstrument.connectivity && !(oldSettings && oldSettings.connectivity)) {
+  var connectivity = oldSettings && oldSettings.connectivity;
+  if (this.autoInstrument.connectivity && !connectivity) {
     this.instrumentConnectivity();
-  } else if (!this.autoInstrument.connectivity && oldSettings && oldSettings.connectivity) {
+  } else if (!this.autoInstrument.connectivity && connectivity) {
     this.deinstrumentConnectivity();
   }
 
-  if (this.autoInstrument.contentSecurityPolicy && !(oldSettings && oldSettings.contentSecurityPolicy)) {
+  var contentSecurityPolicy = oldSettings && oldSettings.contentSecurityPolicy;
+  if (this.autoInstrument.contentSecurityPolicy && !contentSecurityPolicy) {
     this.instrumentContentSecurityPolicy();
-  } else if (!this.autoInstrument.contentSecurityPolicy && oldSettings && oldSettings.contentSecurityPolicy) {
+  } else if (!this.autoInstrument.contentSecurityPolicy && contentSecurityPolicy) {
     this.deinstrumentContentSecurityPolicy();
   }
 };
@@ -222,9 +227,7 @@ Instrumenter.prototype.instrumentNetwork = function() {
     }, this.replacements, 'network');
 
     replace(xhrp, 'send', function(orig) {
-      /* eslint-disable no-unused-vars */
       return function(data) {
-      /* eslint-enable no-unused-vars */
         var xhr = this;
 
         function onreadystatechangeHandler() {
@@ -331,9 +334,8 @@ Instrumenter.prototype.instrumentNetwork = function() {
 
   if ('fetch' in this._window) {
     replace(this._window, 'fetch', function(orig) {
-      /* eslint-disable no-unused-vars */
+      /* eslint-disable-next-line no-unused-vars */
       return function(fn, t) {
-      /* eslint-enable no-unused-vars */
         var args = new Array(arguments.length);
         for (var i=0, len=args.length; i < len; i++) {
           args[i] = arguments[i];