Simplifies getting replay id attribute from data in queue (#1323)

Author: matux

src/queue.js

@@ -102,7 +102,10 @@ class Queue {
     }
 
     if (this.replayManager && data.body) {
-      const replayId = _.getItemAttribute(data, 'replay_id');
+      const replayId = data?.attributes?.find(
+        (a) => a.key === 'replay_id',
+      )?.value;
+
       if (replayId) {
         item.replayId = this.replayManager.add(replayId, data.uuid);
       }

src/utility.js

@@ -623,16 +623,6 @@ function addItemAttributes(itemData, attributes) {
   }
 }
 
-function getItemAttribute(itemData, key) {
-  const attributes = itemData.attributes || [];
-  for (let i = 0; i < attributes.length; ++i) {
-    if (attributes[i].key === key) {
-      return attributes[i].value;
-    }
-  }
-  return undefined;
-}
-
 /*
  * get - given an obj/array and a keypath, return the value at that keypath or
  *       undefined if not possible.
@@ -787,7 +777,6 @@ export {
   addErrorContext,
   createTelemetryEvent,
   addItemAttributes,
-  getItemAttribute,
   filterIp,
   formatArgsAsString,
   formatUrl,
@@ -814,5 +803,5 @@ export {
   stringify,
   maxByteSize,
   typeName,
-  uuid4
+  uuid4,
 };

test/utility.test.js

@@ -716,20 +716,3 @@ describe('addItemAttributes', function () {
     expect(item.data.attributes[0].value).to.equal('12345');
   });
 });
-
-describe('getItemAttribute', function () {
-  it('should skip undefined values', function () {
-    const item = {
-      data: {
-        attributes: [
-          { key: 'replay_id', value: '12345' },
-          { key: 'session_id', value: '67890' },
-        ],
-      },
-    };
-    let value = _.getItemAttribute(item.data, 'replay_id');
-    expect(value).to.equal('12345');
-    value = _.getItemAttribute(item.data, 'session_id');
-    expect(value).to.equal('67890');
-  });
-});