Base eslint configuration (#1408)

Author: matux

.eslintrc

@@ -49,7 +49,7 @@ jobs:
           prettier_extensions: js,cjs,mjs,md,json,yml,yaml
           eslint: true
           eslint_args: '--max-warnings 0'
-          eslint_extensions: js
+          eslint_extensions: js,mjs,cjs
 
       - name: Build
         run: npm run build

.github/workflows/ci.yml

@@ -32,7 +32,7 @@
   "editor.formatOnSaveMode": "file",
   "editor.tabSize": 2,
   "editor.codeActionsOnSave": {
-    "source.fixAll.eslint": "explicit"
+    "source.fixAll.eslint": "never"
   },
   "files.trimTrailingWhitespace": true,
   "prettier.useEditorConfig": false

.vscode/settings.json

@@ -0,0 +1,49 @@
+import js from '@eslint/js';
+import babelParser from '@babel/eslint-parser';
+import prettierRecommended from 'eslint-plugin-prettier/recommended';
+import { defineConfig } from 'eslint/config';
+
+export default defineConfig([
+  js.configs.recommended,
+  prettierRecommended,
+
+  {
+    languageOptions: {
+      ecmaVersion: 2021,
+    },
+  },
+
+  {
+    files: ['**/*.{js,mjs}'],
+    languageOptions: {
+      sourceType: 'module',
+      parser: babelParser,
+      parserOptions: {
+        ecmaVersion: 2021,
+      },
+    },
+    rules: {
+      strict: ['error', 'safe'],
+      complexity: ['error', { max: 35 }],
+      'no-prototype-builtins': 'off',
+      'no-redeclare': 'off',
+      'no-undef': 'off',
+      'no-unused-vars': 'off',
+      'no-useless-escape': 'off',
+    },
+  },
+
+  {
+    files: ['**/*.cjs'],
+    languageOptions: {
+      sourceType: 'commonjs',
+    },
+    rules: {
+      strict: 'off',
+      'no-undef': 'off',
+    },
+  },
+  {
+    ignores: ['dist', 'examples', 'node_modules', 'vendor', 'coverage'],
+  },
+]);

eslint.config.js

@@ -101,6 +101,8 @@
     "chai": "^5.3.3",
     "es-check": "^9.1.4",
     "eslint": "^9.24.0",
+    "eslint-config-prettier": "^10.1.8",
+    "eslint-plugin-prettier": "^5.5.4",
     "express": "^4.21.2",
     "glob": "^5.0.14",
     "mocha": "^11.1.0",
@@ -121,7 +123,7 @@
     "test:server": "mocha 'test/server.*.test.js' --reporter spec",
     "test:wtr": "web-test-runner",
     "test:wtr:watch": "web-test-runner --watch",
-    "lint": "./node_modules/.bin/eslint .",
+    "lint": "eslint",
     "format": "prettier --write \"**/*.{js,cjs,mjs,md,json,yml,yaml}\"",
     "format:check": "prettier --check \"**/*.{js,cjs,mjs,md,json,yml,yaml}\"",
     "pack": "node scripts/pack.js",

eslint.config.mjs

@@ -629,6 +629,7 @@ class Instrumenter {
     const c = this._window.console;
 
     function wrapConsole(method) {
+      // eslint-disable-next-line strict
       'use strict'; // See https://github.com/rollbar/rollbar.js/pull/778
 
       const orig = c[method];