Remove vendored json3 shim and polyfillJSON (#1257)

matux · web-flow · commit c93d44cf69a0 · 2025-07-22T12:40:57.000-03:00
diff --git a/index.d.ts b/index.d.ts
@@ -221,12 +221,10 @@ declare namespace Rollbar {
     handler?: any,
     shim?: any,
   ) => void;
-  export type PolyfillJSONType = (JSON: any) => any;
 
   export interface Components {
     telemeter?: TelemeterType;
     instrumenter?: InstrumenterType;
-    polyfillJSON?: PolyfillJSONType;
     wrapGlobals?: WrapGlobalsType;
     scrub?: ScrubType;
     truncation?: TruncationType;
diff --git a/src/browser/core.js b/src/browser/core.js
@@ -21,7 +21,6 @@ function Rollbar(options, client) {
   this.options._configuredOptions = options;
   const Telemeter = this.components.telemeter;
   const Instrumenter = this.components.instrumenter;
-  const polyfillJSON = this.components.polyfillJSON;
   this.wrapGlobals = this.components.wrapGlobals;
   this.scrub = this.components.scrub;
   const truncation = this.components.truncation;
@@ -80,7 +79,6 @@ function Rollbar(options, client) {
     );
     this.instrumenter.instrument();
   }
-  _.setupJSON(polyfillJSON);
 
   // Used with rollbar-react for rollbar-react-native compatibility.
   this.rollbar = this;
diff --git a/src/browser/rollbar.js b/src/browser/rollbar.js
@@ -1,7 +1,6 @@
 import Rollbar from './core.js';
 import Telemeter from '../telemetry.js';
 import Instrumenter from './telemetry.js';
-import polyfillJSON from '../utility/polyfillJSON.js';
 import wrapGlobals from './wrapGlobals.js';
 import scrub from '../scrub.js';
 import truncation from '../truncation.js';
@@ -11,7 +10,6 @@ import Recorder from './replay/recorder.js';
 Rollbar.setComponents({
   telemeter: Telemeter,
   instrumenter: Instrumenter,
-  polyfillJSON: polyfillJSON,
   wrapGlobals: wrapGlobals,
   scrub: scrub,
   truncation: truncation,
diff --git a/src/react-native/rollbar.js b/src/react-native/rollbar.js
@@ -13,7 +13,6 @@ import * as transforms from './transforms.js';
 import * as sharedTransforms from '../transforms.js';
 import * as sharedPredicates from '../predicates.js';
 import truncation from '../truncation.js';
-import polyfillJSON from '../../vendor/JSON-js/json3.js';
 
 function Rollbar(options, client) {
   if (_.isType(options, 'string')) {
@@ -43,7 +42,6 @@ function Rollbar(options, client) {
     );
   addTransformsToNotifier(this.client.notifier);
   addPredicatesToQueue(this.client.queue);
-  _.setupJSON(polyfillJSON);
 }
 
 var _instance = null;
diff --git a/src/server/rollbar.js b/src/server/rollbar.js
@@ -18,7 +18,6 @@ import * as transforms from './transforms.js';
 import * as sharedTransforms from '../transforms.js';
 import * as sharedPredicates from '../predicates.js';
 import truncation from '../truncation.js';
-import polyfillJSON from '../../vendor/JSON-js/json3.js';
 
 function Rollbar(options, client) {
   if (_.isType(options, 'string')) {
@@ -56,7 +55,6 @@ function Rollbar(options, client) {
   addTransformsToNotifier(this.client.notifier);
   addPredicatesToQueue(this.client.queue);
   this.setupUnhandledCapture();
-  _.setupJSON(polyfillJSON);
 }
 
 function initLocals(localsOptions, logger) {
diff --git a/src/utility.js b/src/utility.js
@@ -1,35 +1,5 @@
 import merge from './merge.js';
 
-var RollbarJSON = {};
-function setupJSON(polyfillJSON) {
-  if (isFunction(RollbarJSON.stringify) && isFunction(RollbarJSON.parse)) {
-    return;
-  }
-
-  if (isDefined(JSON)) {
-    // If polyfill is provided, prefer it over existing non-native shims.
-    if (polyfillJSON) {
-      if (isNativeFunction(JSON.stringify)) {
-        RollbarJSON.stringify = JSON.stringify;
-      }
-      if (isNativeFunction(JSON.parse)) {
-        RollbarJSON.parse = JSON.parse;
-      }
-    } else {
-      // else accept any interface that is present.
-      if (isFunction(JSON.stringify)) {
-        RollbarJSON.stringify = JSON.stringify;
-      }
-      if (isFunction(JSON.parse)) {
-        RollbarJSON.parse = JSON.parse;
-      }
-    }
-  }
-  if (!isFunction(RollbarJSON.stringify) || !isFunction(RollbarJSON.parse)) {
-    polyfillJSON && polyfillJSON(RollbarJSON);
-  }
-}
-
 /*
  * isType - Given a Javascript value and a string, returns true if the type of the value matches the
  * given string.
@@ -327,7 +297,7 @@ function formatUrl(u, protocol) {
 function stringify(obj, backup) {
   var value, error;
   try {
-    value = RollbarJSON.stringify(obj);
+    value = JSON.stringify(obj);
   } catch (jsonError) {
     if (backup && isFunction(backup)) {
       try {
@@ -375,7 +345,7 @@ function maxByteSize(string) {
 function jsonParse(s) {
   var value, error;
   try {
-    value = RollbarJSON.parse(s);
+    value = JSON.parse(s);
   } catch (e) {
     error = e;
   }
@@ -853,10 +823,8 @@ export {
   merge,
   now,
   redact,
-  RollbarJSON,
   sanitizeUrl,
   set,
-  setupJSON,
   stringify,
   maxByteSize,
   typeName,
diff --git a/src/utility/polyfillJSON.d.ts b/src/utility/polyfillJSON.d.ts
diff --git a/src/utility/polyfillJSON.js b/src/utility/polyfillJSON.js
diff --git a/test/api.test.js b/test/api.test.js
@@ -4,8 +4,6 @@
 /* globals sinon */
 
 import API from '../src/api.js';
-import * as utility from '../src/utility.js';
-utility.setupJSON();
 
 function TestTransportGenerator() {
   var TestTransport = function (callbackError, callbackResponse) {
diff --git a/test/apiUtility.test.js b/test/apiUtility.test.js
@@ -4,8 +4,6 @@
 /* globals sinon */
 
 import * as u from '../src/apiUtility.js';
-import * as utility from '../src/utility.js';
-utility.setupJSON();
 
 describe('buildPayload', function () {
   it('should package up the input into a payload', function () {
@@ -18,10 +16,7 @@ describe('buildPayload', function () {
   it('should stringify context', function () {
     var token = 'abc123';
     var context = { a: 1, b: 'other' };
-    var data = {
-      context: context,
-      other: 'stuff',
-    };
+    var data = { context: context, other: 'stuff' };
     var payload = u.buildPayload(data);
 
     expect(payload.data.context).to.not.eql(context);
@@ -33,10 +28,7 @@ describe('buildPayload', function () {
     for (var i = 0; i < 35; i++) {
       context[i] = i;
     }
-    var data = {
-      context: context,
-      other: 'stuff',
-    };
+    var data = { context: context, other: 'stuff' };
     var payload = u.buildPayload(data);
 
     expect(payload.data.context).to.not.eql(context);
@@ -48,17 +40,10 @@ describe('getTransportFromOptions', function () {
   it('should use defaults with not endpoint', function () {
     var options = {
       not: 'endpoint',
-      proxy: {
-        host: 'whatver.com',
-        port: 9090,
-      },
+      proxy: { host: 'whatver.com', port: 9090 },
       timeout: 3000,
     };
-    var defaults = {
-      hostname: 'api.com',
-      protocol: 'https:',
-      path: '/api/1',
-    };
+    var defaults = { hostname: 'api.com', protocol: 'https:', path: '/api/1' };
     var url = {
       parse: function () {
         expect(false).to.be.ok();
@@ -75,10 +60,7 @@ describe('getTransportFromOptions', function () {
   it('should parse the endpoint if given', function () {
     var options = {
       endpoint: 'http://whatever.com/api/42',
-      proxy: {
-        host: 'nope.com',
-        port: 9090,
-      },
+      proxy: { host: 'nope.com', port: 9090 },
     };
     var defaults = {
       hostname: 'api.com',
@@ -161,11 +143,7 @@ describe('getTransportFromOptions', function () {
 
 describe('transportOptions', function () {
   it('should use the given data if no proxy', function () {
-    var transport = {
-      hostname: 'a.com',
-      path: '/api/v1/item/',
-      port: 5000,
-    };
+    var transport = { hostname: 'a.com', path: '/api/v1/item/', port: 5000 };
     var method = 'GET';
 
     var o = u.transportOptions(transport, method);
@@ -181,10 +159,7 @@ describe('transportOptions', function () {
       hostname: 'a.com',
       path: '/api/v1/item/',
       port: 5000,
-      proxy: {
-        host: 'b.com',
-        port: 8080,
-      },
+      proxy: { host: 'b.com', port: 8080 },
       timeout: 3000,
     };
     var method = 'GET';
diff --git a/test/browser.transport.test.js b/test/browser.transport.test.js
@@ -6,8 +6,6 @@
 import truncation from '../src/truncation.js';
 import Transport from '../src/browser/transport.js';
 const t = new Transport(truncation);
-import * as utility from '../src/utility.js';
-utility.setupJSON();
 
 describe('post', function () {
   var accessToken = 'abc123';
@@ -17,10 +15,7 @@ describe('post', function () {
     path: '/api/1/item/',
     timeout: 2000,
   };
-  var payload = {
-    access_token: accessToken,
-    data: { a: 1 },
-  };
+  var payload = { access_token: accessToken, data: { a: 1 } };
   it('should handle a failure to make a request', function (done) {
     var requestFactory = function () {
       return null;
diff --git a/test/react-native.transport.test.js b/test/react-native.transport.test.js
@@ -6,8 +6,6 @@
 import truncation from '../src/truncation.js';
 import Transport from '../src/react-native/transport.js';
 var t = new Transport(truncation);
-import * as utility from '../src/utility.js';
-utility.setupJSON();
 
 describe('post', function () {
   var accessToken = 'abc123';
@@ -16,10 +14,7 @@ describe('post', function () {
     protocol: 'https',
     path: '/api/1/item/',
   };
-  var payload = {
-    access_token: accessToken,
-    data: { a: 1 },
-  };
+  var payload = { access_token: accessToken, data: { a: 1 } };
   var uuid = 'd4c7acef55bf4c9ea95e4fe9428a8287';
 
   before(function (done) {
diff --git a/test/truncation.test.js b/test/truncation.test.js
@@ -3,8 +3,6 @@
 /* globals it */
 
 import t from '../src/truncation.js';
-import * as utility from '../src/utility.js';
-utility.setupJSON();
 
 describe('truncate', function () {
   it('should not truncate something small enough', function () {
@@ -162,34 +160,22 @@ describe('maybeTruncateValue', function () {
 function messagePayload(message) {
   return {
     access_token: 'abc',
-    data: {
-      body: {
-        message: {
-          body: message,
-        },
-      },
-    },
+    data: { body: { message: { body: message } } },
   };
 }
 
 function tracePayload(frameCount, message) {
   message = typeof message !== 'undefined' ? message : 'EXCEPTION MESSAGE';
   var frames = [];
   for (var i = 0; i < frameCount; i++) {
-    frames.push({
-      filename: 'some/file/name',
-      lineno: i,
-    });
+    frames.push({ filename: 'some/file/name', lineno: i });
   }
   return {
     access_token: 'abc',
     data: {
       body: {
         trace: {
-          exception: {
-            description: 'ALL YOUR BASE',
-            message: message,
-          },
+          exception: { description: 'ALL YOUR BASE', message: message },
           frames: frames,
         },
       },
@@ -203,27 +189,14 @@ function traceChainPayload(traceCount, frameCount, message) {
   for (var c = 0; c < traceCount; c++) {
     var frames = [];
     for (var i = 0; i < frameCount; i++) {
-      frames.push({
-        filename: 'some/file/name::' + c,
-        lineno: i,
-      });
+      frames.push({ filename: 'some/file/name::' + c, lineno: i });
     }
     chain.push({
-      exception: {
-        description: 'ALL YOUR BASE :: ' + c,
-        message: message,
-      },
+      exception: { description: 'ALL YOUR BASE :: ' + c, message: message },
       frames: frames,
     });
   }
-  return {
-    access_token: 'abc',
-    data: {
-      body: {
-        trace_chain: chain,
-      },
-    },
-  };
+  return { access_token: 'abc', data: { body: { trace_chain: chain } } };
 }
 
 function repeat(s, n) {
diff --git a/test/utility.test.js b/test/utility.test.js
diff --git a/vendor/JSON-js/README b/vendor/JSON-js/README
diff --git a/vendor/JSON-js/json3.js b/vendor/JSON-js/json3.js
