Skip to content

Commit de9caec

Browse files
authored
use values in the payload key as session attributes (#1356)
1 parent 2d037fb commit de9caec

File tree

2 files changed

+28
-3
lines changed

2 files changed

+28
-3
lines changed

src/browser/core.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -450,13 +450,17 @@ class Rollbar {
450450
}
451451

452452
setSessionAttributesFromOptions(options) {
453-
if (options.person) {
454-
this.setSessionUser(options.person);
453+
const person = options.person || options.payload?.person;
454+
if (person) {
455+
this.setSessionUser(person);
455456
}
456457
const code_version =
457458
options.client?.javascript?.code_version ||
458459
options.codeVersion ||
459-
options.code_version;
460+
options.code_version ||
461+
options.payload?.client?.javascript?.code_version ||
462+
options.payload?.code_version ||
463+
options.payload?.codeVersion;
460464
this.setSessionAttributes({
461465
'rollbar.codeVersion': code_version,
462466
'rollbar.notifier.name': 'rollbar-browser-js',

test/browser.core.test.js

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,27 @@ describe('options', function () {
5858
expect(session.attributes['user.email']).to.equal('[email protected]');
5959
expect(session.attributes['rollbar.codeVersion']).to.equal('abc123');
6060
});
61+
62+
it('should set session attributes from payload key', function () {
63+
const rollbar = new Rollbar({
64+
accessToken: 'POST_CLIENT_ITEM_TOKEN',
65+
captureUnhandledRejections: false,
66+
payload: {
67+
person: {
68+
id: '12345',
69+
name: 'Test User',
70+
71+
},
72+
codeVersion: 'abc123',
73+
},
74+
});
75+
const session = rollbar.tracing.session;
76+
expect(session).to.exist;
77+
expect(session.attributes['user.id']).to.equal('12345');
78+
expect(session.attributes['user.name']).to.equal('Test User');
79+
expect(session.attributes['user.email']).to.equal('[email protected]');
80+
expect(session.attributes['rollbar.codeVersion']).to.equal('abc123');
81+
});
6182
});
6283

6384
describe('options.captureUncaught', function () {

0 commit comments

Comments
 (0)