feat(migrate): add monorepo support for tsup migration script

lauigi · lauigi · commit ebaf82c5b528 · 2025-12-21T00:27:29.000-05:00
Resolves #452
diff --git a/packages/migrate/package.json b/packages/migrate/package.json
@@ -50,6 +50,7 @@
   "dependencies": {
     "@antfu/ni": "catalog:migrate",
     "@ast-grep/napi": "catalog:migrate",
+    "@manypkg/get-packages": "catalog:migrate",
     "ansis": "catalog:prod",
     "cac": "catalog:prod",
     "consola": "catalog:migrate",
diff --git a/packages/migrate/src/index.ts b/packages/migrate/src/index.ts
@@ -1,6 +1,8 @@
+import path from 'node:path'
 import process from 'node:process'
 import { getCliCommand, parseNi, run } from '@antfu/ni'
-import { green, underline } from 'ansis'
+import { getPackagesSync } from '@manypkg/get-packages'
+import { green, greenBright, underline } from 'ansis'
 import consola from 'consola'
 import { migratePackageJson } from './helpers/package-json.ts'
 import { migrateTsupConfig } from './helpers/tsup-config.ts'
@@ -29,11 +31,53 @@ export async function migrate({ cwd, dryRun }: MigrateOptions): Promise<void> {
 
   if (cwd) process.chdir(cwd)
 
-  let migrated = await migratePackageJson(dryRun)
-  if (await migrateTsupConfig(dryRun)) {
-    migrated = true
+  const traverseStartCwd = process.cwd()
+  const { rootPackage, packages } = getPackagesSync(traverseStartCwd)
+  const cwds = new Set([traverseStartCwd])
+  // There are 3 possible cases here:
+  // 1. The current directory is a package root without a monorepo configuration.
+  //   In this case, `packages` will contain only the current directory. We use a
+  //   Set to avoid running it twice.
+  // 2. The current directory is not a package root, which means it is an internal
+  //   package within a monorepo. In this situation, we assume the user intentionally
+  //   specified the migration scope, so we operate only on the current directory.
+  // 3. The current directory is a package root and has a monorepo configuration.
+  //   In this case, `packages` contains only the discovered subpackage directories,
+  //   and we are going to include them.
+  if (rootPackage?.dir === traverseStartCwd) {
+    for (const { dir } of packages) {
+      cwds.add(dir)
+    }
+  }
+
+  let migratedAny = false
+
+  try {
+    for (const dir of cwds) {
+      process.chdir(dir)
+
+      const relativeDirLabel = greenBright(
+        path.relative(traverseStartCwd, dir) || 'the current directory',
+      )
+      consola.info(`Processing ${relativeDirLabel}`)
+
+      let migrated = await migratePackageJson(dryRun)
+      if (await migrateTsupConfig(dryRun)) {
+        migrated = true
+      }
+
+      if (!migrated) {
+        consola.info(`No migrations to apply in ${relativeDirLabel}.`)
+        continue
+      }
+
+      migratedAny = true
+    }
+  } finally {
+    process.chdir(traverseStartCwd)
   }
-  if (!migrated) {
+
+  if (!migratedAny) {
     consola.error('No migration performed.')
     process.exitCode = 1
     return
diff --git a/packages/migrate/tests/fixtures/issue-452/monorepo/package.json b/packages/migrate/tests/fixtures/issue-452/monorepo/package.json
@@ -0,0 +1,8 @@
+{
+  "name": "issue-452",
+  "version": "0.0.0",
+  "private": true,
+  "scripts": {
+    "build": "pnpm --filter \"*\" build"
+  }
+}
diff --git a/packages/migrate/tests/fixtures/issue-452/monorepo/packages/pkg1/package.json b/packages/migrate/tests/fixtures/issue-452/monorepo/packages/pkg1/package.json
@@ -0,0 +1,16 @@
+{
+  "name": "pkg-app",
+  "version": "1.0.0",
+  "private": true,
+  "type": "module",
+  "main": "./src/index.ts",
+  "dependencies": {
+    "pkg2": "workspace:*"
+  },
+  "devDependencies": {
+    "tsup": "catalog:"
+  },
+  "scripts": {
+    "build": "tsup"
+  }
+}
diff --git a/packages/migrate/tests/fixtures/issue-452/monorepo/packages/pkg1/src/index.ts b/packages/migrate/tests/fixtures/issue-452/monorepo/packages/pkg1/src/index.ts
@@ -0,0 +1,3 @@
+import { add } from 'pkg2'
+
+export const answer: number = add(40, 2)
diff --git a/packages/migrate/tests/fixtures/issue-452/monorepo/packages/pkg1/tsup.config.ts b/packages/migrate/tests/fixtures/issue-452/monorepo/packages/pkg1/tsup.config.ts
@@ -0,0 +1,7 @@
+import { defineConfig } from 'tsup'
+
+export default defineConfig({
+  entry: ['src/index.ts'],
+  format: ['esm'],
+  dts: true,
+})
diff --git a/packages/migrate/tests/fixtures/issue-452/monorepo/packages/pkg2/package.json b/packages/migrate/tests/fixtures/issue-452/monorepo/packages/pkg2/package.json
@@ -0,0 +1,21 @@
+{
+  "name": "pkg2",
+  "version": "1.0.0",
+  "private": true,
+  "type": "module",
+  "main": "./src/index.ts",
+  "exports": {
+    ".": "./src/index.ts"
+  },
+  "devDependencies": {
+    "tsup": "catalog:"
+  },
+  "scripts": {
+    "build": "tsup"
+  },
+  "tsup": {
+    "entry": [
+      "src/index.ts"
+    ]
+  }
+}
diff --git a/packages/migrate/tests/fixtures/issue-452/monorepo/packages/pkg2/src/index.ts b/packages/migrate/tests/fixtures/issue-452/monorepo/packages/pkg2/src/index.ts
@@ -0,0 +1 @@
+export const add = (a: number, b: number) => a + b
diff --git a/packages/migrate/tests/fixtures/issue-452/monorepo/pnpm-workspace.yaml b/packages/migrate/tests/fixtures/issue-452/monorepo/pnpm-workspace.yaml
@@ -0,0 +1,5 @@
+packages:
+  - packages/*
+
+catalog:
+  tsup: 8.5.1
diff --git a/packages/migrate/tests/fixtures/issue-452/standalone/package.json b/packages/migrate/tests/fixtures/issue-452/standalone/package.json
@@ -0,0 +1,12 @@
+{
+  "name": "standalone-pkg",
+  "version": "0.0.0",
+  "type": "module",
+  "packageManager": "pnpm@10.26.0",
+  "scripts": {
+    "build": "tsup src/index.ts"
+  },
+  "dependencies": {
+    "tsup": "^7.2.0"
+  }
+}
diff --git a/packages/migrate/tests/issues.test.ts b/packages/migrate/tests/issues.test.ts
@@ -0,0 +1,87 @@
+import { cpSync, mkdtempSync, realpathSync, rmSync } from 'node:fs'
+import { tmpdir } from 'node:os'
+import { join } from 'node:path'
+import process from 'node:process'
+import { fileURLToPath } from 'node:url'
+import { afterEach, describe, expect, test, vi } from 'vitest'
+
+const packageJsonCwds = vi.hoisted(() => [] as string[])
+const tsupConfigCwds = vi.hoisted(() => [] as string[])
+
+vi.mock('../src/helpers/package-json.ts', () => ({
+  migratePackageJson: vi.fn(() => {
+    packageJsonCwds.push(process.cwd())
+    return true
+  }),
+}))
+
+vi.mock('../src/helpers/tsup-config.ts', () => ({
+  migrateTsupConfig: vi.fn(() => {
+    tsupConfigCwds.push(process.cwd())
+    return true
+  }),
+}))
+
+describe('issue-452', () => {
+  const fixturesDir = fileURLToPath(new URL('.', import.meta.url))
+  const monorepoFixture = join(fixturesDir, 'fixtures/issue-452/monorepo')
+  const internalPackageFixture = join(
+    fixturesDir,
+    'fixtures/issue-452/monorepo/packages/pkg2',
+  )
+  const standaloneFixture = join(fixturesDir, 'fixtures/issue-452/standalone')
+  const originalCwd = process.cwd()
+
+  afterEach(() => {
+    packageJsonCwds.length = 0
+    tsupConfigCwds.length = 0
+    process.chdir(originalCwd)
+    vi.clearAllMocks()
+  })
+
+  test('migrates each package in a pnpm workspace', async () => {
+    vi.resetModules()
+    const { migrate } = await import('../src/index.ts')
+
+    await migrate({ cwd: monorepoFixture, dryRun: true })
+
+    const expectedCwds = [
+      monorepoFixture,
+      join(monorepoFixture, 'packages/pkg1'),
+      join(monorepoFixture, 'packages/pkg2'),
+    ]
+
+    expect(packageJsonCwds).toEqual(expectedCwds)
+    expect(tsupConfigCwds).toEqual(expectedCwds)
+  })
+
+  test('migrates only the current package when run inside a workspace package', async () => {
+    vi.resetModules()
+    const { migrate } = await import('../src/index.ts')
+
+    await migrate({ cwd: internalPackageFixture, dryRun: true })
+
+    expect(packageJsonCwds).toEqual([internalPackageFixture])
+    expect(tsupConfigCwds).toEqual([internalPackageFixture])
+  })
+
+  test('migrates a standalone package outside any workspace', async () => {
+    vi.resetModules()
+    const { migrate } = await import('../src/index.ts')
+
+    const tmpRoot = mkdtempSync(join(tmpdir(), 'tsdown-standalone-'))
+    const standaloneDir = join(tmpRoot, 'pkg')
+    cpSync(standaloneFixture, standaloneDir, { recursive: true })
+    const resolvedStandaloneDir = realpathSync(standaloneDir)
+
+    try {
+      await migrate({ cwd: resolvedStandaloneDir, dryRun: true })
+    } finally {
+      process.chdir(originalCwd)
+      rmSync(tmpRoot, { recursive: true, force: true })
+    }
+
+    expect(packageJsonCwds).toEqual([resolvedStandaloneDir])
+    expect(tsupConfigCwds).toEqual([resolvedStandaloneDir])
+  })
+})
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
@@ -48,6 +48,7 @@ catalogs:
   migrate:
     '@antfu/ni': ^28.0.0
     '@ast-grep/napi': ^0.40.3
+    '@manypkg/get-packages': ^3.1.0
     consola: ^3.4.2
     diff: ^8.0.2
   peer:

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+import { add } from 'pkg2'`
	`2`	`+`
	`3`	`+export const answer: number = add(40, 2)`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+export const add = (a: number, b: number) => a + b`