Allow route.name to be a string in Configuration

Author: sstok

.gush.yml

@@ -6,6 +6,13 @@ table-pr:
     deprecations: [Deprecations, 'no']
     fixed_tickets: ['Fixed Tickets', '']
     license: [License, MIT]
+pr_type:
+    - feature
+    - bug
+    - refactor
+    - style
+    - doc
+    - security
 repo_adapter: github
 issue_tracker: github
 repo_org: rollerworks

README.md

@@ -82,6 +82,7 @@ rollerworks_navigation:
                     label:             ~                            # Label of the menu-item, this will be translated with the translator_domain
                     translator_domain: Menus                        # translator domain for the label
                     route:             { name: ~, parameters: { } } # The route.name can not be empty, parameters is optional
+                                                                    # route can also be only a string (route name)
                     uri:               ~                            # Alternatively you can use a URI instead of a route
                     items:             []                           # Sub-level items, same as this example (unlimited depth nesting)
 
@@ -140,6 +141,7 @@ rollerworks_navigation:
             label:             ~                            # Label of the breadcrumb, this will be translated with the translator_domain
             translator_domain: Breadcrumbs                  # translator domain for the label
             route:             { name: ~, parameters: { } } # The route.name can not be empty, parameters is optional
+                                                            # route can also be only a string (route name)
             uri:               ~                            # Alternatively you can use a URI instead of a route
 
             # If your breadcrumb is to dynamic you may also use a dedicated service.

src/DependencyInjection/Configuration.php

@@ -67,6 +67,14 @@ public function getConfigTreeBuilder()
                             ->scalarNode('translator_domain')->defaultValue('Breadcrumbs')->end()
                             ->scalarNode('uri')->defaultNull()->end()
                             ->arrayNode('route')
+                                ->beforeNormalization()
+                                    ->ifString()
+                                    ->then(
+                                        function ($v) {
+                                            return array('name' => $v);
+                                        }
+                                    )
+                                ->end()
                                 ->children()
                                     ->scalarNode('name')->cannotBeEmpty()->end()
                                     ->booleanNode('absolute')->defaultFalse()->end()
@@ -107,6 +115,14 @@ final public function addItemConfig(ArrayNodeDefinition $rootNode)
                 ->scalarNode('translator_domain')->defaultValue('Menus')->end()
                 ->scalarNode('uri')->defaultNull()->end()
                 ->arrayNode('route')
+                    ->beforeNormalization()
+                        ->ifString()
+                        ->then(
+                            function ($v) {
+                                return array('name' => $v);
+                            }
+                        )
+                    ->end()
                     ->children()
                         ->scalarNode('name')->cannotBeEmpty()->end()
                         ->booleanNode('absolute')->defaultFalse()->end()

tests/DependencyInjection/ConfigurationTest.php

@@ -52,6 +52,44 @@ public function testBreadcrumbsWithDefaulted()
         );
     }
 
+    public function testBreadcrumbWithRouteNodeAsString()
+    {
+        $this->assertProcessedConfigurationEquals(
+            array(
+                array(
+                    'breadcrumbs' => array(
+                        'customers' => array(
+                            'parent' => null,
+                            'label' => null,
+                            'options' => array(),
+                            'translator_domain' => 'Breadcrumbs',
+                            'route' => 'app_homepage',
+                            'expression' => null,
+                        ),
+                    ),
+                ),
+            ),
+            array(
+                'menus' => array(),
+                'breadcrumbs' => array(
+                    'customers' => array(
+                        'parent' => null,
+                        'label' => null,
+                        'options' => array(),
+                        'translator_domain' => 'Breadcrumbs',
+                        'route' => array(
+                            'name' => 'app_homepage',
+                            'absolute' => false,
+                            'parameters' => array(),
+                        ),
+                        'uri' => null,
+                        'expression' => null,
+                    ),
+                ),
+            )
+        );
+    }
+
     public function testBreadcrumbAcceptsService()
     {
         $this->assertProcessedConfigurationEquals(