Skip to content

Commit d1650a3

Browse files
authored
feature #6 Add support for Symfony 8 (sstok)
This PR was merged into the 1.0-dev branch. Discussion ---------- | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Fixed tickets | | License | MIT Drop support for Symfony 5 and PHP 7 (End of maintenance) Commits ------- 9b3a3c8 Add support for Symfony 8
2 parents d5a1aa5 + 9b3a3c8 commit d1650a3

File tree

5 files changed

+14
-13
lines changed

5 files changed

+14
-13
lines changed

.github/workflows/ci.yaml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ jobs:
8989

9090
-
9191
name: 'Install dependencies'
92-
run: 'composer install --no-progress'
92+
run: 'composer update --no-progress --prefer-stable'
9393

9494
-
9595
name: 'Run PhpStan'
@@ -103,10 +103,6 @@ jobs:
103103
strategy:
104104
matrix:
105105
include:
106-
-
107-
php-version: '8.1'
108-
composer-options: '--prefer-stable'
109-
symfony-version: '6.3'
110106
-
111107
php-version: '8.2'
112108
composer-options: '--prefer-stable'
@@ -115,7 +111,12 @@ jobs:
115111
-
116112
php-version: '8.2'
117113
composer-options: '--prefer-stable'
118-
symfony-version: '^7.0'
114+
symfony-version: '^7.4'
115+
116+
-
117+
php-version: '8.4'
118+
composer-options: '--prefer-stable'
119+
symfony-version: '^8.0'
119120

120121
steps:
121122
-

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ and install them for you.
2424

2525
## Requirements
2626

27-
You need at least PHP 7.4, mbstring is recommended but not required.
27+
You need at least PHP 8.0 and Symfony 6.4, mbstring is recommended but not required.
2828

2929
## Usage
3030

composer.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,17 @@
1919
}
2020
],
2121
"require": {
22-
"php": ">=7.4",
22+
"php": ">=8.0",
2323
"symfony/polyfill-mbstring": "^1.5.0",
24-
"symfony/validator": "^5.0 || ^6.0 || ^7.0"
24+
"symfony/validator": "^6.4 || ^7.4 || ^8.0"
2525
},
2626
"require-dev": {
2727
"phpstan/phpstan": "^1.10.39",
2828
"phpstan/phpstan-phpunit": "1.3.15",
2929
"phpunit/phpunit": "^9.5",
3030
"rollerscapes/standards": "^1.0",
31-
"symfony/framework-bundle": "^5.3 || ^6.0 || ^7.0",
32-
"symfony/phpunit-bridge": "^5.3 || ^6.0 || ^7.0"
31+
"symfony/framework-bundle": "^6.4 || ^7.4 || ^8.0",
32+
"symfony/phpunit-bridge": "^6.4 || ^7.4 || ^8.0"
3333
},
3434
"minimum-stability": "dev",
3535
"prefer-stable": true,

src/Constraints/NotInPasswordCommonList.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ final class NotInPasswordCommonList extends Constraint
2525
{
2626
public string $message = 'This Password was found among the 1,000,000 most common passwords. Please use another password.';
2727

28-
public function __construct(string $message = null, $options = null, array $groups = null, $payload = null)
28+
public function __construct(?string $message = null, ?array $options = null, ?array $groups = null, mixed $payload = null)
2929
{
3030
parent::__construct($options, $groups, $payload);
3131

tests/Constraints/NotInPasswordCommonListTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ public function __toString(): string
9696
}
9797

9898
/** @return iterable<int, array{0: string}> */
99-
public function provide_unsafe_passwords(): iterable
99+
public static function provide_unsafe_passwords(): iterable
100100
{
101101
yield ['hunter'];
102102
yield ['123qwe123'];

0 commit comments

Comments
 (0)