refactor(cli): 🚨 fix lint warnings

Author: romancitodev

src/config/helpers.rs

@@ -41,7 +41,7 @@ pub fn load_config(path: Option<PathBuf>, config: &mut SimpleCommitsConfig) -> C
 
     if let Ok(content) = std::fs::read_to_string(&global_path) {
         let mut global_config: SimpleCommitsConfig = toml::from_str(&content).unwrap();
-        config.config = global_path.clone();
+        config.config.clone_from(&global_path);
         config.scopes = Some(Scope::default());
         config.merge(&mut global_config);
     }
@@ -51,7 +51,7 @@ pub fn load_config(path: Option<PathBuf>, config: &mut SimpleCommitsConfig) -> C
     if let Ok(local_path_ok) = &local_path {
         if let Ok(content) = std::fs::read_to_string(local_path_ok) {
             let mut local_config: SimpleCommitsConfig = toml::from_str(&content).unwrap();
-            config.config = local_path_ok.clone();
+            config.config.clone_from(local_path_ok);
             config.scopes = Some(Scope::default());
             config.merge(&mut local_config);
         }

src/config/mod.rs

@@ -10,21 +10,18 @@ pub fn get_config() -> (cli::SimpleCommitsConfig, Option<Command>) {
     let mut args = cli::CliConfig::parse();
     let mut config = cli::SimpleCommitsConfig::default();
 
-    match args.mode {
-        Some(Command::Init(option)) => {
-            let path = helpers::create_config(option);
-            config.config = path;
-        }
-        _ => {
-            let (global_path, local_path) = helpers::load_config(args.config, &mut config);
+    if let Some(Command::Init(option)) = args.mode {
+        let path = helpers::create_config(option);
+        config.config = path;
+    } else {
+        let (global_path, local_path) = helpers::load_config(args.config, &mut config);
 
-            if let Some(local_path) = local_path {
-                config.config = local_path;
-            } else {
-                config.config = global_path;
-            }
-            config.merge(&mut args.sc_config);
+        if let Some(local_path) = local_path {
+            config.config = local_path;
+        } else {
+            config.config = global_path;
         }
+        config.merge(&mut args.sc_config);
     }
     (config, args.mode)
 }

src/gen/emojis.rs

@@ -2,11 +2,12 @@
 // This code is autogenerated by pipeline on GitHub Actions
 // Version of emoji based: v3.14.0
 // This generation is based from https://raw.githubusercontent.com/carloscuesta/gitmoji/v3.14.0/packages/gitmojis/src/gitmojis.json
-use colored::*;
+use colored::Colorize;
 use serde::Deserialize;
 
 #[derive(Deserialize, Clone)]
 pub struct Emoji {
+    #[allow(clippy::struct_field_names)]
     pub emoji: &'static str,
     pub description: &'static str,
     pub name: &'static str,
@@ -16,8 +17,8 @@ impl Emoji {
     const fn new(emoji: &'static str, name: &'static str, description: &'static str) -> Self {
         Self {
             emoji,
-            name,
             description,
+            name,
         }
     }
 }

src/tui/config_prompt/mod.rs

@@ -14,7 +14,7 @@ pub fn init(
 
     info("")?;
     info("Succesfully created.")?;
-    info(format!("Path: {config:?}"))?;
+    info(format!("Path: {}", config.display()))?;
     info("")?;
 
     outro(concat!(

src/tui/mod.rs

@@ -42,20 +42,20 @@ impl Action {
         match self {
             Self::DryRun(msg) => println!("{msg}"),
             Self::Commit(cmd, args) => {
-                std::process::Command::new(cmd)
+                let _ = std::process::Command::new(cmd)
                     .args(&args[..])
                     .spawn()
-                    .unwrap();
+                    .expect("The child failed for some reason")
+                    .wait();
             }
-            _ => {}
+            Self::None => {}
         }
     }
 }
 
 pub type StepResult = Result<(), AppError>;
 
 /// A trait to setup steps along the TUI app.
-
 pub trait Step {
     fn before_run(
         &mut self,
@@ -154,7 +154,7 @@ impl CommitBuilder {
         if r#type.is_none() {
             log::error!("Type of commit required");
             return Err(BuildError::TypeRequired);
-        };
+        }
 
         if title.is_none() {
             log::error!("Title of the commit required");
@@ -170,7 +170,7 @@ impl CommitBuilder {
         let exclamation = if let Some(true) = is_breaking_change {
             "!".to_owned()
         } else {
-            "".to_owned()
+            String::new()
         };
         let breaking_change_message = breaking_change_message.map_or(String::new(), |m| {
             format!("BREAKING CHANGE: {m}").trim().to_string()

src/tui/steps/breaking_change.rs

@@ -36,7 +36,7 @@ impl Step for Message {
     fn run(&mut self, state: &mut crate::tui::AppData, _: &mut SimpleCommitsConfig) -> StepResult {
         if !self.execute {
             return Ok(());
-        };
+        }
 
         let breaking_change_msg: String = input("Expand the breaking change description")
             .required(false)

src/tui/steps/content.rs

@@ -18,7 +18,7 @@ impl Step for Title {
         config: &mut SimpleCommitsConfig,
     ) -> StepResult {
         self.skip = config.message.as_ref().is_some();
-        self.title = config.message.clone();
+        self.title.clone_from(&config.message);
         Ok(())
     }
 

src/tui/steps/exec.rs

@@ -21,11 +21,7 @@ impl Step for Execute {
         state: &mut crate::tui::AppData,
         config: &mut SimpleCommitsConfig,
     ) -> StepResult {
-        self.skip = config
-            .git
-            .as_ref()
-            .map(|cfg| cfg.skip_preview)
-            .unwrap_or(false);
+        self.skip = config.git.as_ref().is_some_and(|cfg| cfg.skip_preview);
 
         let commit = state.commit.clone().build().unwrap();
 
@@ -66,14 +62,14 @@ impl Step for Execute {
         let execute = confirm("Do you want to execute this command?")
             .initial_value(true)
             .interact()?;
-        if !execute {
+        if execute {
+            let (head, tail) = self.cmd.split_first().unwrap();
+            self.action = Action::Commit(head.clone(), tail.to_vec());
+        } else {
             step("Commit preview")?;
             info(commit.0)?;
             info(BLANK_CHARACTER)?;
-        } else {
-            let (head, tail) = self.cmd.split_first().unwrap();
-            self.action = Action::Commit(head.clone(), tail.to_vec());
-        };
+        }
 
         Ok(())
     }

src/tui/steps/mod.rs

@@ -29,11 +29,11 @@ pub fn init(config: &mut SimpleCommitsConfig) -> Result<(), AppError> {
 
     intro("Simple Commit")?;
 
-    for step in steps.iter_mut() {
+    for step in &mut steps {
         let _before = step.before_run(&mut state, config);
         let res = step.run(&mut state, config);
         if let Err(err) = res {
-            let msg = format!("❌ Error: {:?}", err);
+            let msg = format!("❌ Error: {err:?}");
             error!(target: "tui::steps", "{}", msg.bright_red());
             return Err(AppError::Step(msg));
         }

src/tui/steps/scopes.rs

@@ -27,7 +27,7 @@ impl Step for Scope {
                 (
                     scope.name(),
                     scope.name(),
-                    scope.description().clone().unwrap_or_default(),
+                    scope.description().map_or(String::new(), Clone::clone),
                 )
             })
             .collect::<Vec<_>>();
@@ -49,7 +49,7 @@ impl Step for Scope {
             config
                 .update()
                 .inspect_err(|err| {
-                    error!(target: "step::scope", "error updating the scopes: {}", err);
+                    error!(target: "step::scope", "error updating the scopes: {err}");
                 })
                 .unwrap();
         }