Fix build, protect app updates crashing the app

Author: romannurik

app/assets/TrayIconTemplate.png

@@ -64,7 +64,11 @@ app.on('ready', () => {
   readPrefs();
   setupUiMode(uiMode, {firstRun: true});
   if (!DEV_MODE) {
-    checkForAppUpdates();
+    try {
+      checkForAppUpdates();
+    } catch (e){
+      console.error(e);
+    }
   }
 });
 

app/assets/TrayIconTemplate@2x.png

@@ -20,7 +20,6 @@ const gulp = require('gulp');
 const $ = require('gulp-load-plugins')();
 const del = require('del');
 const merge = require('merge-stream');
-const runSequence = require('run-sequence');
 const electronPackager = require('electron-packager');
 const electronOsxSignAsync = require('electron-osx-sign').signAsync;
 const argv = require('yargs').argv;
@@ -92,15 +91,15 @@ gulp.task('clean', cb => {
 
 gulp.task('build', gulp.series('clean', 'styles', 'scripts', 'copy'));
 
-gulp.task('install-packages', gulp.series('build', $.shell.task([
+gulp.task('install-packages', gulp.series($.shell.task([
   'npm install --production'
 ], { cwd: 'build' })));
 
-gulp.task('run-electron', gulp.series('build', $.shell.task([
+gulp.task('run-electron', gulp.series($.shell.task([
   'electron ./build/ --dev'
 ])));
 
-gulp.task('dist', gulp.series('build', 'install-packages', async cb => {
+gulp.task('dist', gulp.series('build', 'install-packages', async () => {
   let packageInfo = require('./build/package.json');
   let appPaths = await electronPackager({
     arch: 'x64',
@@ -135,24 +134,27 @@ gulp.task('dist', gulp.series('build', 'install-packages', async cb => {
   // https://developer.apple.com/library/content/qa/qa1940/_index.html
   execSync(`xattr -cr "${appFilePath}"`);
 
-  plistStream.on('end', async () => {
-    // Sign the app
-    await electronOsxSignAsync({
-      app: appFilePath,
-      identity: 'Developer ID Application: Roman NURIK (NLACF347G7)',
-      platform: 'darwin'
+  await new Promise((resolve, reject) => {
+    plistStream.on('end', async () => {
+      // Sign the app
+      await electronOsxSignAsync({
+        app: appFilePath,
+        identity: 'Developer ID Application: Roman NURIK (NLACF347G7)',
+        platform: 'darwin'
+      });
+
+      // zip up the directory
+      console.log('Zipping up the package');
+      let zipStream = fs.createWriteStream(`./dist/${packageInfo.version}.zip`)
+          .on('warning', err => { throw err; })
+          .on('error', err => { throw err; })
+          .on('close', () => resolve());
+      let archive = archiver('zip', {zlib: {level: 9}})
+      archive.pipe(zipStream);
+      archive.directory(appFilePath, `${packageInfo.appDisplayName}.app`);
+      archive.finalize();
     });
-
-    // zip up the directory
-    console.log('Zipping up the package');
-    let zipStream = fs.createWriteStream(`./dist/${packageInfo.version}.zip`)
-        .on('error', err => { throw err })
-        .on('end', () => cb());
-    let archive = archiver('zip', {zlib: {level: 9}})
-    archive.pipe(zipStream);
-    archive.directory(appFilePath, `${packageInfo.appDisplayName}.app`);
-    archive.finalize();
   });
 }));
 
-gulp.task('default', gulp.series('run-electron'));
+gulp.task('default', gulp.series('build', 'run-electron'));

app/main.js

@@ -3,13 +3,14 @@
   "appDisplayName": "Material Colors",
   "productName": "Material Colors",
   "appBundleId": "net.nurik.roman.materialcolors",
-  "version": "1.1.1",
+  "version": "2.0.0",
   "description": "A quick color palette for material design colors.",
   "main": "main.js",
   "author": "Roman Nurik",
   "private": true,
   "scripts": {
-    "start": "gulp"
+    "start": "gulp",
+    "build": "gulp dist"
   },
   "devDependencies": {
     "archiver": "^3.1.1",
@@ -25,8 +26,7 @@
     "gulp-rename": "^1.4.0",
     "gulp-sass": "^4.0.2",
     "gulp-shell": "^0.7.1",
-    "merge-stream": "^2.0.0",
-    "run-sequence": "^2.2.1"
+    "merge-stream": "^2.0.0"
   },
   "dependencies": {
     "electron-positioner": "^4.1.0",