Skip to content

[Bug] Flashpoint API filtering NSFW results #2808

@SenilePenguin

Description

@SenilePenguin

RomM version
4.5.0-beta.3 (additionally tested on all pre-release versions since 4.5.0-alpha.1)

Describe the bug
Metadata searches for games flagged "NSFW" failed due to omitted results.

To Reproduce
Obtain two games from the Flashpoint Archive and place them into the "browser" folder. In this case, I have used:
Geometry Dash - 0f5997cb-2b34-42d8-aee1-1a8cac72368f-1646433696514.zip
Toss the Turtle - 603fc848-1709-44c5-ac3f-6cf4dcf37fd3-1664775207860.zip

  1. Go to 'Scan'
  2. Filter Platform to "Browser (Flash/HTML5)"
  3. Select Metadata sources "Flashpoint Project"
  4. Select Scan options "Quick scan"
  5. Click 'Scan'
  6. After a moment, you will see Geometry dash be matched while Toss the Turtle fails.

Expected behaviorA clear and concise description of what you expected to happen.
We would expect both games to yield matches. Having tested locally, I have found that modifying line 351 in /backend/handler/metadata/flashpoint_handler.py to read as "filter": "false", causes all metadata to be found correctly (on the games I've tested).

There is an additional filter on line 175, though it did not appear to need changed in my local environment to yield results. I have not created a pull request due to not knowing what breaking changes (if any) this would cause. However, it may be relevant to implement some form of NSFW filtering on games should this change be implemented. Let me know if this is something I should open under a separate feature request.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions