fix: i18n.py hard code and debugging on the setting ui

Author: rookiestar28

i18n.py

@@ -5,8 +5,28 @@
 
 from typing import Dict, Optional
 
-# Current language setting
-_current_language = "zh_TW"
+# ═══════════════════════════════════════════════════════════════════════════
+# CRITICAL: Default Language Configuration
+# ═══════════════════════════════════════════════════════════════════════════
+# ⚠️ WARNING: DO NOT change this default to any language other than "en"
+#
+# This is the FALLBACK language used when:
+#   1. ComfyUI first loads (before user settings are applied)
+#   2. The frontend hasn't called /debugger/set_language yet
+#   3. Automatic error pattern matching (non-AI suggestions)
+#
+# WHY "en" (NOT "zh_TW" or other languages):
+#   - International users expect English as the default
+#   - Prevents confusion when users haven't configured language yet
+#   - Matches frontend DEFAULTS.LANGUAGE in web/doctor.js
+#
+# If you want to change the default language for YOUR installation:
+#   → Update the user's ComfyUI settings (Doctor.General.Language)
+#   → DO NOT modify this hardcoded value
+#
+# Last Modified: 2026-01-03 (Fixed from "zh_TW" to "en")
+# ═══════════════════════════════════════════════════════════════════════════
+_current_language = "en"
 
 # Supported languages
 SUPPORTED_LANGUAGES = ["en", "zh_TW", "zh_CN", "ja", "de", "fr", "it", "es", "ko"]

web/doctor.js

@@ -7,9 +7,30 @@ import { api } from "../../../scripts/api.js";
 import { DoctorUI } from "./doctor_ui.js";
 import { DoctorAPI } from "./doctor_api.js";
 
-// Default values
+// ═══════════════════════════════════════════════════════════════════════════
+// CRITICAL: Frontend Default Configuration
+// ═══════════════════════════════════════════════════════════════════════════
+// ⚠️ WARNING: LANGUAGE must always be "en" (English)
+//
+// This default is used when:
+//   1. User first installs ComfyUI-Doctor (no settings saved yet)
+//   2. ComfyUI settings are reset/corrupted
+//   3. DoctorUI constructor receives no language option
+//
+// MUST MATCH backend default in i18n.py (_current_language = "en")
+//
+// If these don't match:
+//   ❌ Backend suggestions will be in different language than UI
+//   ❌ Confusing experience for international users
+//
+// To change default for your installation:
+//   → Modify ComfyUI Settings → Doctor → Language
+//   → DO NOT change this hardcoded value
+//
+// Last Modified: 2026-01-03 (Fixed from "zh_TW" to "en")
+// ═══════════════════════════════════════════════════════════════════════════
 const DEFAULTS = {
-    LANGUAGE: "zh_TW",
+    LANGUAGE: "en",  // ⚠️ DO NOT CHANGE - Must match i18n.py backend default
     POLL_INTERVAL: 2000,
     AUTO_OPEN_ON_ERROR: false,
     ENABLE_NOTIFICATIONS: true,

web/doctor_ui.js

@@ -33,8 +33,19 @@ import { ChatPanel } from "./doctor_chat.js";
  */
 export class DoctorUI {
     constructor(options = {}) {
-        // Configuration from ComfyUI settings
-        this.language = options.language || 'zh_TW';
+        // ═══════════════════════════════════════════════════════════════
+        // CRITICAL: Language Fallback Configuration
+        // ═══════════════════════════════════════════════════════════════
+        // ⚠️ WARNING: Fallback must be 'en' (NOT 'zh_TW' or other languages)
+        //
+        // This fallback is used when options.language is undefined/null
+        // MUST MATCH:
+        //   - Backend: i18n.py (_current_language = "en")
+        //   - Frontend: doctor.js (DEFAULTS.LANGUAGE = "en")
+        //
+        // Last Modified: 2026-01-03 (Fixed from 'zh_TW' to 'en')
+        // ═══════════════════════════════════════════════════════════════
+        this.language = options.language || 'en';  // ⚠️ DO NOT CHANGE fallback
         this.pollInterval = options.pollInterval || 2000;
         this.autoOpenOnError = options.autoOpenOnError || false;
         this.enableNotifications = options.enableNotifications || true;
@@ -49,16 +60,41 @@ export class DoctorUI {
         this.lastErrorTimestamp = 0;
         this.ERROR_DEBOUNCE_MS = 1000;  // Ignore duplicate errors within 1 second
 
-        // UI text translations
-        // IMPORTANT: this.uiText starts as empty object {}
-        // loadUIText() is ASYNC and will populate it later
+        // ═══════════════════════════════════════════════════════════════
+        // CRITICAL: UI Text Loading Order
+        // ═══════════════════════════════════════════════════════════════
+        // ⚠️ WARNING: this.uiText MUST be loaded BEFORE createSidebar()
+        //
+        // Common Bug Pattern (INCORRECT):
+        //   this.uiText = {};
+        //   this.loadUIText();        // ❌ Async, doesn't wait
+        //   this.createSidebar();     // ❌ Creates UI before translations load
+        //   Result: All UI text shows "[Missing: key_name]"
+        //
+        // Correct Pattern (CURRENT):
+        //   this.uiText = {};
+        //   this.loadUIText().then(() => {  // ✅ Wait for translations
+        //       this.createSidebar();       // ✅ Create UI after load
+        //   });
+        //
+        // Why This Matters:
+        //   - Sidebar uses getUIText() extensively (save_settings_btn, etc.)
+        //   - If uiText is empty {}, getUIText() returns "[Missing: ...]"
+        //   - Users see broken UI with missing translations
+        //
+        // Last Modified: 2026-01-03 (Fixed race condition)
+        // ═══════════════════════════════════════════════════════════════
         this.uiText = {};
-        this.loadUIText();
 
         this.createStyles();
-        this.createSidebar();
         this.createMenuButton();
 
+        // ⚠️ CRITICAL: Load UI text FIRST, then create sidebar
+        // DO NOT move createSidebar() before loadUIText() completes!
+        this.loadUIText().then(() => {
+            this.createSidebar();
+        });
+
         // Subscribe to ComfyUI execution_error events (instant, more accurate)
         this.subscribeToExecutionErrors();