feat(ui): move Trust & Health + Anonymous Telemetry from Settings to Statistics and stabilize Playwright E2E routes

Author: rookiestar28

i18n.py

@@ -180,6 +180,7 @@
         "ai_provider_label": "AI Provider",
         "base_url_label": "Base URL",
         "api_key_label": "API Key",
+        "api_key_tip": "Tip: Prefer using Google AI Studio's free API quota for AI debugging. For more info, see:",
         "model_name_label": "Model Name",
         "loading_models": "Loading models...",
         "set_base_url_first": "Please set Base URL first",
@@ -335,6 +336,7 @@
         "ai_provider_label": "AI 供應商",
         "base_url_label": "基礎 URL",
         "api_key_label": "API 金鑰",
+        "api_key_tip": "小提示：建議優先使用 Google AI Studio 的免費 API 額度來進行 AI 除錯。更多說明請至：",
         "model_name_label": "模型名稱",
         "loading_models": "正在載入模型...",
         "set_base_url_first": "請先設定基礎 URL",
@@ -489,6 +491,7 @@
         "ai_provider_label": "AI 供应商",
         "base_url_label": "基础 URL",
         "api_key_label": "API 密钥",
+        "api_key_tip": "小提示：建议优先使用 Google AI Studio 的免费 API 额度进行 AI 调试。更多说明请访问：",
         "model_name_label": "模型名称",
         "loading_models": "正在加载模型...",
         "set_base_url_first": "请先设置基础 URL",
@@ -643,6 +646,7 @@
         "ai_provider_label": "AIプロバイダー",
         "base_url_label": "ベースURL",
         "api_key_label": "APIキー",
+        "api_key_tip": "ヒント：AI デバッグには、まず Google AI Studio の無料 API 枠の利用をおすすめします。詳しくは：",
         "model_name_label": "モデル名",
         "loading_models": "モデルを読み込み中...",
         "set_base_url_first": "最初にベースURLを設定してください",
@@ -795,6 +799,7 @@
         "ai_provider_label": "KI-Anbieter",
         "base_url_label": "Basis-URL",
         "api_key_label": "API-Schlüssel",
+        "api_key_tip": "Tipp: Nutze für AI-Debugging bevorzugt das kostenlose API-Kontingent von Google AI Studio. Mehr Infos:",
         "model_name_label": "Modellname",
         "loading_models": "Modelle werden geladen...",
         "set_base_url_first": "Bitte zuerst Basis-URL festlegen",
@@ -949,6 +954,7 @@
         "ai_provider_label": "Fournisseur d'IA",
         "base_url_label": "URL de base",
         "api_key_label": "Clé API",
+        "api_key_tip": "Astuce : pour le débogage IA, privilégiez d’abord le quota gratuit de Google AI Studio. Plus d’infos :",
         "model_name_label": "Nom du modèle",
         "loading_models": "Chargement des modèles...",
         "set_base_url_first": "Veuillez d'abord définir l'URL de base",
@@ -1103,6 +1109,7 @@
         "ai_provider_label": "Provider IA",
         "base_url_label": "URL Base",
         "api_key_label": "Chiave API",
+        "api_key_tip": "Suggerimento: per il debug con AI, usa prima la quota gratuita delle API di Google AI Studio. Maggiori info:",
         "model_name_label": "Nome del modello",
         "loading_models": "Caricamento modelli...",
         "set_base_url_first": "Imposta prima l'URL Base",
@@ -1257,6 +1264,7 @@
         "ai_provider_label": "Proveedor de IA",
         "base_url_label": "URL Base",
         "api_key_label": "Clave API",
+        "api_key_tip": "Consejo: para depurar con IA, prioriza el cupo gratuito de API de Google AI Studio. Más información:",
         "model_name_label": "Nombre del modelo",
         "loading_models": "Cargando modelos...",
         "set_base_url_first": "Por favor, establezca primero la URL Base",
@@ -1411,6 +1419,7 @@
         "ai_provider_label": "AI 공급자",
         "base_url_label": "기본 URL",
         "api_key_label": "API 키",
+        "api_key_tip": "팁: AI 디버깅에는 Google AI Studio의 무료 API 할당량을 우선 사용해 보세요. 자세히 보기:",
         "model_name_label": "모델 이름",
         "loading_models": "모델 로딩 중...",
         "set_base_url_first": "먼저 기본 URL을 설정하세요",

playwright.config.js

@@ -1,9 +1,12 @@
 // @ts-check
 const { defineConfig, devices } = require('@playwright/test');
+const path = require('node:path');
 
 const webServerPort = Number(process.env.PW_WEB_SERVER_PORT) || 3000;
 const baseURL = process.env.PW_BASE_URL || `http://127.0.0.1:${webServerPort}/tests/e2e/`;
 const pythonCmd = process.platform === 'win32' ? 'python' : (process.env.PW_PYTHON || 'python3');
+const testOutputDir = process.env.PW_TEST_OUTPUT_DIR || 'test-results';
+const htmlReportDir = process.env.PW_HTML_REPORT_DIR || 'playwright-report';
 
 /**
  * Playwright Configuration for ComfyUI-Doctor
@@ -17,6 +20,9 @@ module.exports = defineConfig({
   // Test directory
   testDir: './tests/e2e/specs',
 
+  // Test artifacts output
+  outputDir: path.resolve(testOutputDir),
+
   // Maximum time one test can run
   timeout: 30 * 1000,
 
@@ -39,7 +45,7 @@ module.exports = defineConfig({
 
   // Reporter to use
   reporter: [
-    ['html'],
+    ['html', { outputFolder: path.resolve(htmlReportDir), open: 'never' }],
     ['list'],
     ...(process.env.CI ? [['github']] : []),
   ],

pyproject.toml

@@ -1,7 +1,7 @@
 [project]
 name = "comfyui-doctor"
 description = "A real-time runtime diagnostics suite for ComfyUI, featuring interactive debugging chat, and 50+ fix patterns. Automatically intercepts terminal output from startup, and delivers prioritized fix suggestions with node-level context extraction. Now supports JSON-based pattern management with hot-reload and full i18n support for 9 languages."
-version = "1.5.2"
+version = "1.5.3"
 license = {text = "MIT"}
 readme = "README.md"
 requires-python = ">=3.10"

scripts/run-playwright.mjs

@@ -1,23 +1,52 @@
 import { spawnSync } from 'node:child_process';
 import fs from 'node:fs';
+import os from 'node:os';
 import path from 'node:path';
 import process from 'node:process';
 
 function ensureWritableTempDir() {
   if (process.platform === 'win32') return;
   if (process.env.TMPDIR && process.env.TMP && process.env.TEMP) return;
 
-  const repoRoot = process.cwd();
-  const tmpDir = path.join(repoRoot, '.tmp', 'playwright');
+  const tmpDir = (isWsl() && isDrvFsPath(process.cwd()))
+    ? path.join('/tmp', 'comfyui-doctor', 'playwright-tmp')
+    : path.join(process.cwd(), '.tmp', 'playwright');
   fs.mkdirSync(tmpDir, { recursive: true });
 
   process.env.TMPDIR = process.env.TMPDIR || tmpDir;
   process.env.TMP = process.env.TMP || tmpDir;
   process.env.TEMP = process.env.TEMP || tmpDir;
 }
 
+function isWsl() {
+  return !!process.env.WSL_DISTRO_NAME || fs.existsSync('/proc/sys/fs/binfmt_misc/WSLInterop');
+}
+
+function isDrvFsPath(p) {
+  return p.startsWith('/mnt/');
+}
+
 ensureWritableTempDir();
 
+function ensureWritablePlaywrightOutputDirs() {
+  if (process.platform === 'win32') return;
+  if (!isWsl()) return;
+  if (!isDrvFsPath(process.cwd())) return;
+
+  if (process.env.PW_TEST_OUTPUT_DIR && process.env.PW_HTML_REPORT_DIR) return;
+
+  const baseDir = path.join(os.tmpdir(), 'comfyui-doctor', 'playwright');
+  const testOutputDir = path.join(baseDir, 'test-results');
+  const htmlReportDir = path.join(baseDir, 'playwright-report');
+  fs.mkdirSync(testOutputDir, { recursive: true });
+  fs.mkdirSync(htmlReportDir, { recursive: true });
+
+  process.env.PW_TEST_OUTPUT_DIR = process.env.PW_TEST_OUTPUT_DIR || testOutputDir;
+  process.env.PW_HTML_REPORT_DIR = process.env.PW_HTML_REPORT_DIR || htmlReportDir;
+}
+
+ensureWritablePlaywrightOutputDirs();
+
 const args = ['test', ...process.argv.slice(2)];
 const result = spawnSync('playwright', args, {
   stdio: 'inherit',
@@ -26,4 +55,3 @@ const result = spawnSync('playwright', args, {
 });
 
 process.exit(result.status ?? 1);
-

tests/E2E_TESTING_SOP.md

@@ -34,6 +34,14 @@ Notes:
   Ensure `python` is available on PATH (WSL2 may only have `python3`).
 - If you use WSL and run from `/mnt/c/...`, set a writable temp directory to avoid
   Playwright transform cache permission errors (e.g. `.tmp/playwright` or `/tmp`).
+- If you use WSL and run from `/mnt/c/...`, Playwright may also fail to delete/write large
+  test artifacts (videos, HTML report) due to Windows/DrvFS permission semantics.
+  - Best: clone/move the repo into the WSL Linux filesystem (e.g. `~/src/ComfyUI-Doctor`).
+  - Alternative: redirect Playwright outputs using `PW_TEST_OUTPUT_DIR` and `PW_HTML_REPORT_DIR`.
+    `scripts/run-playwright.mjs` auto-defaults these to `/tmp/comfyui-doctor/playwright/...`
+    when it detects WSL + `/mnt/*`, so you usually don't need to set them manually.
+- If you run tests from a non-interactive shell (CI/automation/tools), `nvm` may not auto-load.
+  Run `source ~/.nvm/nvm.sh` and confirm `node -v` shows 18+ before `npm test`.
 
 ---
 
@@ -63,6 +71,7 @@ Expected result: `55 passed` with no failures.
 # From the repository root
 source ~/.nvm/nvm.sh
 nvm use 18
+node -v
 python3 --version
 
 # Provide `python` if only python3 exists (local shim)
@@ -115,6 +124,7 @@ npm test
 source ~/.nvm/nvm.sh
 nvm install 18
 nvm use 18
+node -v
 python3 --version
 ```
 

tests/e2e/mocks/ui-text.json

@@ -18,6 +18,7 @@
     "save_settings_btn": "Save Settings",
     "language_label": "Language",
     "api_key_label": "API Key",
+    "api_key_tip": "Tip: Prefer using Google AI Studio's free API quota for AI debugging. For more info, see:",
     "api_key_placeholder": "Enter API key",
     "model_label": "Model",
     "model_name_label": "Model",
@@ -69,8 +70,9 @@
     "tab_settings": "設定",
     "no_errors_detected": "エラーなし",
     "system_running_smoothly": "システムは正常に動作中",
+    "api_key_tip": "ヒント：AI デバッグには、まず Google AI Studio の無料 API 枠の利用をおすすめします。詳しくは：",
     "statistics_title": "エラー統計",
     "stats_total_errors": "合計 (30日)",
     "stats_last_24h": "過去24時間"
   }
-}
+}

tests/e2e/specs/error-boundaries.spec.js

@@ -138,7 +138,7 @@ test.describe('Error Boundaries', () => {
         await page.goto('test-harness.html');
 
         // Wait for Doctor UI to initialize
-        await page.waitForFunction(() => window.__doctorTestReady === true, { timeout: 15000 });
+        await page.waitForFunction(() => window.__doctorTestReady === true, null, { timeout: 15000 });
 
         // Wait for ErrorBoundary UI to appear
         await expect(page.locator('.error-boundary-container')).toBeVisible({ timeout: 5000 });
@@ -163,7 +163,7 @@ test.describe('Error Boundaries', () => {
         });
 
         await page.goto('test-harness.html');
-        await page.waitForFunction(() => window.__doctorTestReady === true, { timeout: 15000 });
+        await page.waitForFunction(() => window.__doctorTestReady === true, null, { timeout: 15000 });
 
         // Verify error UI appears
         await expect(page.locator('.error-boundary-container')).toBeVisible({ timeout: 5000 });
@@ -189,7 +189,7 @@ test.describe('Error Boundaries', () => {
         });
 
         await page.goto('test-harness.html');
-        await page.waitForFunction(() => window.__doctorTestReady === true, { timeout: 15000 });
+        await page.waitForFunction(() => window.__doctorTestReady === true, null, { timeout: 15000 });
 
         // Verify error UI appears
         await expect(page.locator('.error-boundary-container')).toBeVisible({ timeout: 5000 });
@@ -226,7 +226,7 @@ test.describe('Error Boundaries', () => {
         });
 
         await page.goto('test-harness.html');
-        await page.waitForFunction(() => window.__doctorTestReady === true, { timeout: 15000 });
+        await page.waitForFunction(() => window.__doctorTestReady === true, null, { timeout: 15000 });
 
         // Wait for error UI
         await expect(page.locator('.error-boundary-container')).toBeVisible({ timeout: 5000 });
@@ -256,7 +256,7 @@ test.describe('Error Boundaries', () => {
         });
 
         await page.goto('test-harness.html');
-        await page.waitForFunction(() => window.__doctorTestReady === true, { timeout: 15000 });
+        await page.waitForFunction(() => window.__doctorTestReady === true, null, { timeout: 15000 });
 
         // Chat should show error
         await expect(page.locator('.error-boundary-container')).toBeVisible({ timeout: 5000 });
@@ -294,7 +294,7 @@ test.describe('Error Boundaries', () => {
         });
 
         await page.goto('test-harness.html');
-        await page.waitForFunction(() => window.__doctorTestReady === true, { timeout: 15000 });
+        await page.waitForFunction(() => window.__doctorTestReady === true, null, { timeout: 15000 });
 
         // Wait for error and logging
         await expect(page.locator('.error-boundary-container')).toBeVisible({ timeout: 5000 });
@@ -310,7 +310,7 @@ test.describe('Error Boundaries', () => {
     test('normal operation without error injection', async ({ page }) => {
         // No error injection - normal operation
         await page.goto('test-harness.html');
-        await page.waitForFunction(() => window.__doctorTestReady === true, { timeout: 15000 });
+        await page.waitForFunction(() => window.__doctorTestReady === true, null, { timeout: 15000 });
 
         // Error boundary should NOT appear
         await page.waitForTimeout(1000);
@@ -333,7 +333,7 @@ test.describe('Error Boundaries', () => {
         });
 
         await page.goto('test-harness.html');
-        await page.waitForFunction(() => window.__doctorTestReady === true, { timeout: 15000 });
+        await page.waitForFunction(() => window.__doctorTestReady === true, null, { timeout: 15000 });
 
         // Wait for error boundary to appear and logs to be captured
         await expect(page.locator('.error-boundary-container')).toBeVisible({ timeout: 5000 });

tests/e2e/specs/preact-loader.spec.js

@@ -33,7 +33,7 @@ test.describe('Preact Loader', () => {
         await page.goto('test-harness.html');
 
         // Wait for Doctor UI to be ready (can be slower on /mnt/c + sandboxed environments)
-        await page.waitForFunction(() => window.__doctorTestReady === true, { timeout: 20000 });
+        await page.waitForFunction(() => window.__doctorTestReady === true, null, { timeout: 20000 });
     });
 
     test.describe('Module Loading', () => {
@@ -104,7 +104,7 @@ test.describe('Preact Loader', () => {
 
             // Reload to apply the flag
             await page.reload();
-            await page.waitForFunction(() => window.__doctorTestReady === true, { timeout: 10000 });
+            await page.waitForFunction(() => window.__doctorTestReady === true, null, { timeout: 10000 });
 
             const isEnabled = await page.evaluate(async () => {
                 const { isPreactEnabled } = await import('/web/preact-loader.js');
@@ -143,7 +143,7 @@ test.describe('Preact Loader', () => {
 
 	            // Re-navigate so the blocking routes apply before any module imports happen.
 	            await page.goto('test-harness.html');
-	            await page.waitForFunction(() => window.__doctorTestReady === true, { timeout: 20000 });
+	            await page.waitForFunction(() => window.__doctorTestReady === true, null, { timeout: 20000 });
 	        });
 
 	        test('should handle complete load failure gracefully', async ({ page }) => {
@@ -225,7 +225,7 @@ test.describe('Preact Loader', () => {
 
             // Navigate to test harness (Preact will fail to load)
             await page.goto('test-harness.html');
-            await page.waitForFunction(() => window.__doctorTestReady === true, { timeout: 15000 });
+            await page.waitForFunction(() => window.__doctorTestReady === true, null, { timeout: 15000 });
 
             // Verify Chat UI still renders (vanilla fallback)
             const chatMessages = page.locator('#doctor-messages');
@@ -261,7 +261,7 @@ test.describe('Preact Loader', () => {
 
             // Navigate to test harness
             await page.goto('test-harness.html');
-            await page.waitForFunction(() => window.__doctorTestReady === true, { timeout: 15000 });
+            await page.waitForFunction(() => window.__doctorTestReady === true, null, { timeout: 15000 });
 
             // Switch to Stats tab
             await page.click('.doctor-tab-button[data-tab-id="stats"]');
@@ -280,7 +280,7 @@ test.describe('Preact Loader', () => {
             await simulateVendorLoadFailure(page);
 
             await page.goto('test-harness.html');
-            await page.waitForFunction(() => window.__doctorTestReady === true, { timeout: 15000 });
+            await page.waitForFunction(() => window.__doctorTestReady === true, null, { timeout: 15000 });
 
             // Use shared helper from helpers.js
             await assertChatFallbackUI(page);
@@ -291,7 +291,7 @@ test.describe('Preact Loader', () => {
             await disablePreact(page);
 
             await page.goto('test-harness.html');
-            await page.waitForFunction(() => window.__doctorTestReady === true, { timeout: 15000 });
+            await page.waitForFunction(() => window.__doctorTestReady === true, null, { timeout: 15000 });
 
             // Use shared helper from helpers.js
             await assertChatFallbackUI(page);
@@ -306,7 +306,7 @@ test.describe('Preact Loader', () => {
 
         test('should record error when island render function throws', async ({ page }) => {
             await page.goto('test-harness.html');
-            await page.waitForFunction(() => window.__doctorTestReady === true, { timeout: 15000 });
+            await page.waitForFunction(() => window.__doctorTestReady === true, null, { timeout: 15000 });
 
             // Register a test island that throws on render, then mount it
             const result = await page.evaluate(async () => {
@@ -362,7 +362,7 @@ test.describe('Preact Loader', () => {
             await simulateVendorLoadFailure(page);
 
             await page.goto('test-harness.html');
-            await page.waitForFunction(() => window.__doctorTestReady === true, { timeout: 15000 });
+            await page.waitForFunction(() => window.__doctorTestReady === true, null, { timeout: 15000 });
 
             // Verify input is fully functional
             const input = page.locator('#doctor-input');