Skip to content

Commit 48f803a

Browse files
authored
Merge pull request #40 from kethinov/2.0.2
2.0.2
2 parents 3b8681a + 162373b commit 48f803a

File tree

5 files changed

+14
-13
lines changed

5 files changed

+14
-13
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## 2.0.2
2+
3+
- Fixed regression that caused middleware support to break routes without middleware.
4+
- Updated dependencies.
5+
16
## 2.0.1
27

38
- Added support for middleware on routes.

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
[![npm](https://img.shields.io/npm/v/single-page-express.svg)](https://www.npmjs.com/package/single-page-express) 📄 **single-page-express**
1+
📄 **single-page-express** [![npm](https://img.shields.io/npm/v/single-page-express.svg)](https://www.npmjs.com/package/single-page-express)
22

33
A client-side implementation of the [Express](http://expressjs.com) route API. It works by hijacking links and form submits, then providing a direct imitation of the Express route API to handle "requests" (click or submit events) and issue "responses" in the form of DOM updates.
44

package-lock.json

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"url": "https://github.com/rooseveltframework/single-page-express/graphs/contributors"
99
}
1010
],
11-
"version": "2.0.1",
11+
"version": "2.0.2",
1212
"files": [
1313
"dist",
1414
"*.md"

single-page-express.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,12 +85,8 @@ function singlePageExpress (options) {
8585

8686
// registers a route and handles middleware
8787
function routeHandler (method, middleware, route, callback) {
88-
let callbackWithMiddlewareExecutingFirst = callback // by default no middleware executes
89-
if (!callback) {
90-
// handle 2 args; this is when no middleware is supplied
91-
callback = route
92-
route = middleware
93-
} else callbackWithMiddlewareExecutingFirst = (req, res) => middleware(req, res, () => callback(req, res)) // handle 3 args; this is when middleware is supplied
88+
let callbackWithMiddlewareExecutingFirst = middleware
89+
if (callback) callbackWithMiddlewareExecutingFirst = (req, res) => middleware(req, res, () => callback(req, res))
9490
registerRoute(method, route, callbackWithMiddlewareExecutingFirst)
9591
}
9692

0 commit comments

Comments
 (0)