Skip to content

Commit 5e79d6f

Browse files
committed
Handle force_saved for functions again
Only if force_saved configured evaluation will not be performed
1 parent 3126863 commit 5e79d6f

File tree

3 files changed

+14
-11
lines changed

3 files changed

+14
-11
lines changed

modules/hist/TF1Painter.mjs

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,19 +29,22 @@ function produceTAxisLogScale(axis, num, min, max) {
2929

3030
function scanTF1Options(opt) {
3131
if (!isStr(opt)) opt = '';
32-
let p = opt.indexOf(';webcanv_hist'), webcanv_hist = false, prefer_saved = false;
32+
let p = opt.indexOf(';webcanv_hist'), webcanv_hist = false, use_saved = 0;
3333
if (p >= 0) {
3434
webcanv_hist = true;
3535
opt = opt.slice(0, p);
3636
}
37-
p = opt.indexOf(';force_saved'); // only to support old JSON files from TWebCanvas
38-
if (p < 0)
39-
p = opt.indexOf(';prefer_saved');
37+
p = opt.indexOf(';force_saved');
4038
if (p >= 0) {
41-
prefer_saved = true;
39+
use_saved = 2;
4240
opt = opt.slice(0, p);
4341
}
44-
return { opt, webcanv_hist, prefer_saved };
42+
p = opt.indexOf(';prefer_saved');
43+
if (p >= 0) {
44+
use_saved = 1;
45+
opt = opt.slice(0, p);
46+
}
47+
return { opt, webcanv_hist, use_saved };
4548
}
4649

4750

@@ -107,7 +110,7 @@ class TF1Painter extends TH1Painter {
107110
xmax = Math.max(xmax, gr.zoom_xmax);
108111
}
109112

110-
this._use_saved_points = (tf1.fSave.length > 3) && (settings.PreferSavedPoints || this.prefer_saved);
113+
this._use_saved_points = (tf1.fSave.length > 3) && (settings.PreferSavedPoints || (this.use_saved > 1));
111114

112115
const ensureBins = num => {
113116
if (hist.fNcells !== num + 2) {
@@ -319,7 +322,7 @@ class TF1Painter extends TH1Painter {
319322
* @desc Used to inform webcanvas when evaluation failed
320323
* @private */
321324
fillWebObjectOptions(opt) {
322-
opt.fcust = this._fail_eval && !this.prefer_saved ? 'func_fail' : '';
325+
opt.fcust = this._fail_eval && !this.use_saved ? 'func_fail' : '';
323326
}
324327

325328
/** @summary draw TF1 object */

modules/hist/TF2Painter.mjs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ class TF2Painter extends TH2Painter {
6262
if ((nsave > 0) && (nsave !== (func.fSave[nsave+4]+1) * (func.fSave[nsave+5]+1)))
6363
nsave = 0;
6464

65-
this._use_saved_points = (nsave > 0) && (settings.PreferSavedPoints || this.prefer_saved);
65+
this._use_saved_points = (nsave > 0) && (settings.PreferSavedPoints || (this.use_saved > 1));
6666

6767
const fp = this.getFramePainter(),
6868
pad = this.getPadPainter()?.getRootPad(true),
@@ -284,7 +284,7 @@ class TF2Painter extends TH2Painter {
284284
* @desc Used to inform webcanvas when evaluation failed
285285
* @private */
286286
fillWebObjectOptions(opt) {
287-
opt.fcust = this._fail_eval && !this.prefer_saved ? 'func_fail' : '';
287+
opt.fcust = this._fail_eval && !this.use_saved ? 'func_fail' : '';
288288
}
289289

290290
/** @summary draw TF2 object */

modules/hist/TF3Painter.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ class TF3Painter extends TH2Painter {
7474
createTF3Histogram(func, hist) {
7575
const nsave = func.fSave.length - 9;
7676

77-
this._use_saved_points = (nsave > 0) && (settings.PreferSavedPoints || this.prefer_saved);
77+
this._use_saved_points = (nsave > 0) && (settings.PreferSavedPoints || (this.use_saved > 1));
7878

7979
const fp = this.getFramePainter(),
8080
pad = this.getPadPainter()?.getRootPad(true),

0 commit comments

Comments
 (0)