Skip to content

Commit 6c14cb1

Browse files
committed
Fix - do not draw negative bins in 2d/3d scatter plots
1 parent e474d9c commit 6c14cb1

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

scripts/JSRoot3DPainter.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3297,13 +3297,14 @@
32973297
if ((i2<=i1) || (j2<=j1) || (k2<=k1)) return true;
32983298

32993299
// scale down factor if too large values
3300-
var coef = (this.gmaxbin > 1000) ? 1000/this.gmaxbin : 1, numpixels = 0;
3300+
var coef = (this.gmaxbin > 1000) ? 1000/this.gmaxbin : 1,
3301+
numpixels = 0, content_lmt = Math.max(0, this.gminbin);
33013302

33023303
for (i = i1; i < i2; ++i) {
33033304
for (j = j1; j < j2; ++j) {
33043305
for (k = k1; k < k2; ++k) {
33053306
bin_content = histo.getBinContent(i+1, j+1, k+1);
3306-
if (bin_content <= this.gminbin) continue;
3307+
if (bin_content <= content_lmt) continue;
33073308
numpixels += Math.round(bin_content*coef);
33083309
}
33093310
}
@@ -3319,7 +3320,7 @@
33193320
for (j = j1; j < j2; ++j) {
33203321
for (k = k1; k < k2; ++k) {
33213322
bin_content = histo.getBinContent(i+1, j+1, k+1);
3322-
if (bin_content <= this.gminbin) continue;
3323+
if (bin_content <= content_lmt) continue;
33233324
var num = Math.round(bin_content*coef);
33243325

33253326
for (var n=0;n<num;++n) {

scripts/JSRootPainter.more.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4338,7 +4338,7 @@
43384338
for (i = handle.i1; i < handle.i2; ++i) {
43394339
for (j = handle.j1; j < handle.j2; ++j) {
43404340
binz = histo.getBinContent(i + 1, j + 1);
4341-
if ((binz == 0) || (binz < this.minbin)) continue;
4341+
if ((binz <= 0) || (binz < this.minbin)) continue;
43424342

43434343
cw = handle.grx[i+1] - handle.grx[i];
43444344
ch = handle.gry[j] - handle.gry[j+1];

0 commit comments

Comments
 (0)