f

Author: ferdymercury

math/mathcore/inc/Math/LFSR.h

@@ -53,7 +53,7 @@ static bool NextLFSR(std::bitset<k> &lfsr, std::array<uint16_t, nTaps> taps, boo
    static_assert(nTaps > 0, "At least one tap is needed for the LFSR.");
    static_assert(nTaps <= k, "Cannot use more taps than polynomial order");
    for (uint16_t j = 0; j < nTaps; ++j) {
-      static_assert((taps[j] - 1) <= k && (taps[j] - 1) > 0, "Tap value is out of range [1,k]");
+      assert((taps[j] - 1) <= k && (taps[j] - 1) > 0 && "Tap value is out of range [1,k]");
    }
 
    // First, calculate the XOR (^) of all selected bits (marked by the taps)
@@ -101,7 +101,7 @@ template <size_t k, size_t nTaps, typename Output = unsigned char>
 static std::vector<Output> GenerateSequence(std::bitset<k> start, std::array<uint16_t, nTaps> taps, bool left = true,
                                             bool wrapping = false, bool oppositeBit = false)
 {
-   std::vector<bool> result; // Store result here
+   std::vector<Output> result; // Store result here
 
    // Sanity-checks
    static_assert(k <= 32, "For the moment, only supported until k == 32.");
@@ -155,7 +155,7 @@ static std::vector<Output> GenerateSequence(std::bitset<k> start, std::array<uin
 
    result.shrink_to_fit(); // only some special taps will lead to the maxPeriod, others will stop earlier
 
-   return;
+   return result;
 }
 }