Skip to content

Commit 0f82690

Browse files
Apply suggestions from code review
Co-authored-by: Jonas Rembser <jonas.rembser@cern.ch>
1 parent 03c4a03 commit 0f82690

File tree

11 files changed

+12
-13
lines changed

11 files changed

+12
-13
lines changed

graf2d/cocoa/inc/TGQuartz.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ class TGQuartz : public TGCocoa {
9696
void AlignTTFString();
9797
Bool_t IsTTFStringVisible(Int_t x, Int_t y, UInt_t w, UInt_t h);
9898
void RenderTTFString(Int_t x, Int_t y, ETextMode mode);
99-
//TODO: use void * instead of QuartzPixmap *
99+
//TODO: move internal headers like TGQuartz.h out of the public ROOT user interface. Then we can also use XQuartz types like QuartzPixmap* instead of void * in functions like these
100100
void DrawFTGlyphIntoPixmap(void *pixmap, FT_Bitmap *source, ULong_t fore, ULong_t back, Int_t bx, Int_t by);
101101

102102
void SetAA();

graf2d/fitsio/src/TFITS.cxx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
///
4343
/// Please have a look to the tutorials ($ROOTSYS/tutorials/fitsio/) to see
4444
/// some examples. IMPORTANT: to run tutorials it is required that
45-
/// you change the current working directory of ROOT (Cling) shell to the
45+
/// you change the current working directory of the ROOT shell to the
4646
/// tutorials directory. Example:
4747
/// ~~~ {.cpp}
4848
/// root [1] gSystem->ChangeDirectory("tutorials/fitsio")

graf2d/win32gdk/inc/TGWin32ProxyDefs.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
#ifndef ROOT_TGWin32ProxyDefs
1414
#define ROOT_TGWin32ProxyDefs
1515

16-
#include "Rtypes.h" // Cling headers
16+
#include "Rtypes.h"
1717

1818

1919
#define _NAME4_(name1,name2,name3,name4) _NAME3_(name1,name2,name3)name4

graf3d/eve/src/TEveBrowser.cxx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -463,7 +463,7 @@ Specialization of TRootBrowser for Eve.
463463

464464

465465
////////////////////////////////////////////////////////////////////////////////
466-
/// Add "Export to CINT" (now Cling) into context-menu for class cl.
466+
/// Add "Export to CINT" into context-menu for class cl.
467467

468468
void TEveBrowser::SetupCintExport(TClass* cl)
469469
{

graf3d/eve/src/TEveElement.cxx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -512,7 +512,7 @@ void TEveElement::SaveVizParams(std::ostream& out, const TString& tag, const TSt
512512
/// Write-out visual parameters for this object.
513513
/// This is a virtual function and all sub-classes are required to
514514
/// first call the base-element version.
515-
/// The name of the element pointer is 'x%03d', due to historial CINT limitations.
515+
/// The name of the element pointer is 'x%03d', due to historical CINT limitations.
516516
/// Three spaces should be used for indentation, same as in
517517
/// SavePrimitive() methods.
518518

graf3d/gl/inc/TGLParametric.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ class TGLParametricEquation : public TNamed {
4949
Bool_t fModified;
5050

5151
typedef std::unique_ptr<TGLHistPainter> Painter_t;
52-
//C++ compiler do not need TGLhHstPainter definition here, but I'm not sure about Cling,
5352
//so I've included TGLHistPainter definition.
5453
Painter_t fPainter;
5554

gui/ged/src/TStyleManager.cxx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ style is removed from the list of all available styles for the
7878
current ROOT session. WARNING: it will be lost if you didn't saved
7979
it in a C++ macro file before its deletion. Also, you cannot delete
8080
the selected style if it is set to gStyle. A message 'Can not delete
81-
gStyle' will be displayed on the Cling prompt.
81+
gStyle' will be displayed on the ROOT prompt.
8282
8383
Editor's buttons:
8484
Open / close the style editor:

io/io/src/TStreamerInfo.cxx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1108,7 +1108,7 @@ void TStreamerInfo::BuildCheck(TFile *file /* = 0 */, Bool_t load /* = kTRUE */)
11081108
// match in the 'current' in memory TStreamerInfo for
11091109
// a non foreign class (we can not get here if this is
11101110
// a foreign class so we do not need to test it),
1111-
// we need to add this one more test since the Cling behaviour
1111+
// we need to add this one more test since the interpreter behaviour
11121112
// with enums changed over time, so verify the checksum ignoring
11131113
// members of type enum. We also used to not count the //[xyz] comment
11141114
// in the checksum, so test for that too.
@@ -1158,7 +1158,7 @@ void TStreamerInfo::BuildCheck(TFile *file /* = 0 */, Bool_t load /* = kTRUE */)
11581158
// match in the 'current' in memory TStreamerInfo for
11591159
// a non foreign class (we can not get here if this is
11601160
// a foreign class so we do not need to test it),
1161-
// we need to add this one more test since the Cling behaviour
1161+
// we need to add this one more test since the interpreter behaviour
11621162
// with enums changed over time, so verify the checksum ignoring
11631163
// members of type enum. We also used to not count the //[xyz] comment
11641164
// in the checksum, so test for that too.

io/xml/src/TXMLFile.cxx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
// The XML file is built in memory before being dumped to disk.
2525
//
2626
// Like for normal ROOT files, XML files use the same I/O mechanism
27-
// exploiting the ROOT/Cling dictionary. Any class having a dictionary
27+
// exploiting the I/O dictionary. Any class having a dictionary
2828
// can be saved in XML format.
2929
//
3030
// This first implementation does not support subdirectories

tree/treeplayer/inc/TBranchProxyDirector.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ namespace Internal{
4747
public:
4848

4949
TBranchProxyDirector(TTree* tree, Long64_t i);
50-
TBranchProxyDirector(TTree* tree, Int_t i); // Historial: CINT had a problem casting int to long long
50+
TBranchProxyDirector(TTree* tree, Int_t i); // Historical: CINT had a problem casting int to long long
5151

5252
void Attach(Detail::TBranchProxy* p);
5353
void Attach(TFriendProxy* f);

0 commit comments

Comments
 (0)