Skip to content

Commit 172e220

Browse files
committed
fix wsp compilation
1 parent c3f7019 commit 172e220

File tree

4 files changed

+14
-13
lines changed

4 files changed

+14
-13
lines changed

CMakeLists.txt

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -514,22 +514,22 @@ else()
514514
${CMAKE_SOURCE_DIR} . ${pyroot_legacy} ${__cling_pch}
515515
COMMAND
516516
${CMAKE_COMMAND} -E env ROOTIGNOREPREFIX=1 ${Python3_EXECUTABLE}
517-
${CMAKE_SOURCE_DIR}/etc/dictpch/makepch.py etc/allDict.cxx.pch
518-
${__allIncludes} -I${CMAKE_BINARY_DIR}/include -I${CMAKE_SOURCE_DIR}/core
517+
"${CMAKE_SOURCE_DIR}/etc/dictpch/makepch.py" etc/allDict.cxx.pch
518+
${__allIncludes} -I"${CMAKE_BINARY_DIR}/include" -I"${CMAKE_SOURCE_DIR}/core"
519519
DEPENDS
520520
rootcling ${__pch_dependencies} ${__pch_dictionaries}
521-
${CMAKE_SOURCE_DIR}/cmake/unix/makepchinput.py
522-
${CMAKE_SOURCE_DIR}/etc/dictpch/makepch.py
521+
"${CMAKE_SOURCE_DIR}/cmake/unix/makepchinput.py"
522+
"${CMAKE_SOURCE_DIR}/etc/dictpch/makepch.py"
523523
)
524524
add_custom_target(onepcm ALL DEPENDS etc/allDict.cxx.pch)
525-
install(FILES ${CMAKE_BINARY_DIR}/etc/allDict.cxx.pch DESTINATION ${CMAKE_INSTALL_SYSCONFDIR})
526-
install(DIRECTORY ${CMAKE_BINARY_DIR}/etc/dictpch DESTINATION ${CMAKE_INSTALL_SYSCONFDIR})
525+
install(FILES "${CMAKE_BINARY_DIR}/etc/allDict.cxx.pch" DESTINATION ${CMAKE_INSTALL_SYSCONFDIR})
526+
install(DIRECTORY "${CMAKE_BINARY_DIR}/etc/dictpch" DESTINATION ${CMAKE_INSTALL_SYSCONFDIR})
527527
endif()
528528

529529
# FIXME: move installation of PCMS in ROOT_GENERATE_DICTIONARY().
530530
# We are excluding directories, which are accidentaly copied via unxpected behaviour of install(DIRECTORY ..)
531531
install(
532-
DIRECTORY ${CMAKE_BINARY_DIR}/lib/
532+
DIRECTORY "${CMAKE_BINARY_DIR}/lib/"
533533
DESTINATION ${CMAKE_INSTALL_LIBDIR}
534534
FILES_MATCHING
535535
PATTERN "*.pcm"
@@ -553,7 +553,8 @@ if(runtime_cxxmodules)
553553
set(modules_idx_cmd COMMAND ${CMAKE_COMMAND} -E env PATH="${library_output_dir}\\\;%PATH%"
554554
ROOTIGNOREPREFIX=1 ROOT_HIST=0 $<TARGET_FILE:root.exe> -l -q -b)
555555
else()
556-
set(modules_idx_cmd COMMAND ${ld_library_path}=${library_output_dir}:$ENV{${ld_library_path}}
556+
cmake_path(CONVERT ${library_output_dir} TO_NATIVE_PATH_LIST library_output_dir)
557+
set(modules_idx_cmd COMMAND ${CMAKE_COMMAND} -E env ${ld_library_path}=${library_output_dir}:$ENV{${ld_library_path}}
557558
ROOTIGNOREPREFIX=1 ROOT_HIST=0 $<TARGET_FILE:root.exe> -l -q -b)
558559
endif()
559560
add_custom_command(OUTPUT ${library_output_dir}/modules.idx
@@ -577,7 +578,7 @@ if(WIN32)
577578
set(hsimple_cmd COMMAND ${CMAKE_COMMAND} -E env PATH="${CMAKE_RUNTIME_OUTPUT_DIRECTORY}\\\;%PATH%"
578579
ROOTIGNOREPREFIX=1 ROOT_HIST=0 $<TARGET_FILE:root.exe> -l -q -b -n -x ${CMAKE_SOURCE_DIR}/tutorials/hsimple.C -e return)
579580
else()
580-
set(hsimple_cmd COMMAND ${MODULES_ROOT_INCPATH} ${ld_library_path}=${CMAKE_LIBRARY_OUTPUT_DIRECTORY}:$ENV{${ld_library_path}}
581+
set(hsimple_cmd COMMAND ${CMAKE_COMMAND} -E env ${ld_library_path}=${CMAKE_LIBRARY_OUTPUT_DIRECTORY}:$ENV{${ld_library_path}}
581582
ROOTIGNOREPREFIX=1 ROOT_HIST=0 $<TARGET_FILE:root.exe> -l -q -b -n -x ${CMAKE_SOURCE_DIR}/tutorials/hsimple.C -e return)
582583
endif()
583584
add_custom_command(OUTPUT tutorials/hsimple.root

core/thread/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ target_include_directories(Thread PUBLIC
8181

8282
# keep include directory for ROOT/RSha256.hxx private
8383
set_source_files_properties(src/RConcurrentHashColl.cxx
84-
PROPERTIES COMPILE_FLAGS -I${CMAKE_SOURCE_DIR}/core/foundation/res)
84+
PROPERTIES COMPILE_FLAGS -I"${CMAKE_SOURCE_DIR}/core/foundation/res")
8585

8686
if((tbb OR builtin_tbb) AND NOT MSVC)
8787
target_include_directories(Thread PRIVATE ${TBB_INCLUDE_DIRS})

graf2d/asimage/src/libAfterImage/Makefile.in

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ mkdir:
143143
)
144144

145145
install.static: mkdir
146-
$(INSTALL_SCRIPT) afterimage-libs afterimage-config $(AFTER_BIN_DIR)
146+
$(INSTALL_SCRIPT) afterimage-libs afterimage-config "$(AFTER_BIN_DIR)"
147147
@(if [ -d $(LIBDIR) ] && [ -w $(LIBDIR) ]; then \
148148
echo "$(INSTALL_LIB) $(LIB_STATIC) $(LIBDIR)"; \
149149
$(INSTALL_LIB) $(LIB_STATIC) $(LIBDIR); \
@@ -155,7 +155,7 @@ install.script:
155155
install.dyn: mkdir
156156
@( echo "$(INSTALL_LIB) $(LIB_SHARED).$(LIBVER) $(LIBDIR)"; \
157157
$(INSTALL_LIB) $(LIB_SHARED).$(LIBVER) $(LIBDIR); \
158-
$(INSTALL_SCRIPT) afterimage-libs afterimage-config $(AFTER_BIN_DIR); \
158+
$(INSTALL_SCRIPT) afterimage-libs afterimage-config "$(AFTER_BIN_DIR)"; \
159159
$(RM) -f $(LIBDIR)/$(LIB_SHARED).$(LIBVERMAJOR) $(LIBDIR)/$(LIB_SHARED); \
160160
$(LN_S) -f $(LIB_SHARED).$(LIBVER) $(LIBDIR)/$(LIB_SHARED).$(LIBVERMAJOR); \
161161
$(LN_S) -f $(LIB_SHARED).$(LIBVERMAJOR) $(LIBDIR)/$(LIB_SHARED); \

interpreter/llvm-project/llvm/cmake/modules/AddLLVM.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2392,7 +2392,7 @@ function(llvm_setup_rpath name)
23922392
if(LLVM_LINKER_IS_GNULD AND NOT ${LLVM_LIBRARY_OUTPUT_INTDIR} STREQUAL "")
23932393
# $ORIGIN is not interpreted at link time by ld.bfd
23942394
set_property(TARGET ${name} APPEND_STRING PROPERTY
2395-
LINK_FLAGS " -Wl,-rpath-link,${LLVM_LIBRARY_OUTPUT_INTDIR} ")
2395+
LINK_FLAGS " -Wl,-rpath-link,\"${LLVM_LIBRARY_OUTPUT_INTDIR}\" ")
23962396
endif()
23972397
else()
23982398
return()

0 commit comments

Comments
 (0)