[hist] Fix casts in TH[123]L::SetBinContent

Author: hahnjo

hist/hist/inc/TH1.h

@@ -862,7 +862,7 @@ class TH1L: public TH1, public TArrayL64 {
 
 protected:
    Double_t RetrieveBinContent(Int_t bin) const override { return Double_t (fArray[bin]); }
-   void     UpdateBinContent(Int_t bin, Double_t content) override { fArray[bin] = Int_t (content); }
+   void     UpdateBinContent(Int_t bin, Double_t content) override { fArray[bin] = Long64_t (content); }
 };
 
 TH1L operator*(Double_t c1, const TH1L &h1);

hist/hist/inc/TH2.h

@@ -325,7 +325,7 @@ class TH2L : public TH2, public TArrayL64 {
 
 protected:
    Double_t RetrieveBinContent(Int_t bin) const override { return Double_t (fArray[bin]); }
-   void     UpdateBinContent(Int_t bin, Double_t content) override { fArray[bin] = Int_t (content); }
+   void     UpdateBinContent(Int_t bin, Double_t content) override { fArray[bin] = Long64_t (content); }
 
    ClassDefOverride(TH2L,0)  //2-Dim histograms (one 64 bit integer per channel)
 };

hist/hist/inc/TH3.h

@@ -343,7 +343,7 @@ class TH3L : public TH3, public TArrayL64 {
 
 protected:
    Double_t RetrieveBinContent(Int_t bin) const override { return Double_t (fArray[bin]); }
-   void     UpdateBinContent(Int_t bin, Double_t content) override { fArray[bin] = Int_t (content); }
+   void     UpdateBinContent(Int_t bin, Double_t content) override { fArray[bin] = Long64_t (content); }
 
    ClassDefOverride(TH3L,0)  //3-Dim histograms (one 64 bit integer per channel)
 };

hist/hist/test/CMakeLists.txt

@@ -11,6 +11,7 @@ ROOT_ADD_GTEST(testTH2PolyAdd test_TH2Poly_Add.cxx LIBRARIES Hist Matrix MathCor
 ROOT_ADD_GTEST(testTH2PolyGetNumberOfBins test_TH2Poly_GetNumberOfBins.cxx LIBRARIES Hist Matrix MathCore RIO)
 ROOT_ADD_GTEST(testTHn THn.cxx LIBRARIES Hist Matrix MathCore RIO)
 ROOT_ADD_GTEST(testTH1 test_TH1.cxx LIBRARIES Hist)
+ROOT_ADD_GTEST(testTH2 test_TH2.cxx LIBRARIES Hist)
 ROOT_ADD_GTEST(testTH3 test_TH3.cxx LIBRARIES Hist)
 ROOT_ADD_GTEST(testTHStack test_THStack.cxx LIBRARIES Hist)
 ROOT_ADD_GTEST(testProject3Dname test_Project3D_name.cxx LIBRARIES Hist)

hist/hist/test/test_TH1.cxx

@@ -320,3 +320,12 @@ TEST(TAxis, EqualBinEdges)
 {
    ROOT_EXPECT_ERROR(TAxis _({1, 1}), "TAxis::Set", "bins must be in increasing order");
 }
+
+TEST(TH1L, SetBinContent)
+{
+   TH1L h("", "", 1, 0, 1);
+   // Something that does not fit into Int_t, but is exactly representable in Double_t
+   static constexpr long long Large = 1LL << 42;
+   h.SetBinContent(1, Large);
+   EXPECT_EQ(h.GetBinContent(1), Large);
+}

hist/hist/test/test_TH2.cxx

@@ -0,0 +1,12 @@
+#include "gtest/gtest.h"
+
+#include "TH2.h"
+
+TEST(TH2L, SetBinContent)
+{
+   TH2L h("", "", 1, 0, 1, 1, 0, 1);
+   // Something that does not fit into Int_t, but is exactly representable in Double_t
+   static constexpr long long Large = 1LL << 42;
+   h.SetBinContent(1, 1, Large);
+   EXPECT_EQ(h.GetBinContent(1, 1), Large);
+}

hist/hist/test/test_TH3.cxx

@@ -5,6 +5,15 @@
 #include <random>
 #include <thread>
 
+TEST(TH3L, SetBinContent)
+{
+   TH3L h("", "", 1, 0, 1, 1, 0, 1, 1, 0, 1);
+   // Something that does not fit into Int_t, but is exactly representable in Double_t
+   static constexpr long long Large = 1LL << 42;
+   h.SetBinContent(1, 1, 1, Large);
+   EXPECT_EQ(h.GetBinContent(1, 1, 1), Large);
+}
+
 #ifdef __cpp_lib_atomic_ref
 
 TEST(TH3D, FillThreadSafe)
@@ -64,4 +73,4 @@ TEST(TH3D, FillAtomicNoSumW2)
    EXPECT_THROW(ROOT::Internal::FillThreadSafe(h0, 1., 2., 3., 4.), std::logic_error);
 }
 
-#endif
+#endif