[cmake] remove superseded to_path commands

See https://cmake.org/cmake/help/latest/command/file.html

Author: ferdymercury

CMakeLists.txt

@@ -426,8 +426,8 @@ if(MSVC)
 else()
   set(_os_cat "cat")
 endif()
-file(TO_NATIVE_PATH "${CMAKE_BINARY_DIR}/include/module.modulemap.extra" _from_native)
-file(TO_NATIVE_PATH "${CMAKE_BINARY_DIR}/include/ROOT.modulemap" _to_native)
+cmake_path(CONVERT "${CMAKE_BINARY_DIR}/include/module.modulemap.extra" TO_NATIVE_PATH_LIST _from_native)
+cmake_path(CONVERT "${CMAKE_BINARY_DIR}/include/ROOT.modulemap" TO_NATIVE_PATH_LIST _to_native)
 
 add_custom_target(copymodulemap DEPENDS "${CMAKE_BINARY_DIR}/include/ROOT.modulemap")
 add_custom_command(

cmake/modules/FindArrow.cmake

@@ -358,7 +358,7 @@ function(arrow_find_package
 endfunction()
 
 if(NOT "$ENV{ARROW_HOME}" STREQUAL "")
-  file(TO_CMAKE_PATH "$ENV{ARROW_HOME}" ARROW_HOME)
+  cmake_path(CONVERT "$ENV{ARROW_HOME}" TO_CMAKE_PATH_LIST ARROW_HOME)
 endif()
 arrow_find_package(ARROW
                    "${ARROW_HOME}"

cmake/modules/RootConfiguration.cmake

@@ -641,9 +641,9 @@ configure_file(${CMAKE_SOURCE_DIR}/cmake/scripts/RootUseFile.cmake.in
 
 #---To be used from the install tree--------------------------------------------------------------------------
 # Need to calculate actual relative paths from CMAKEDIR to other locations
-file(RELATIVE_PATH ROOT_CMAKE_TO_INCLUDE_DIR "${CMAKE_INSTALL_FULL_CMAKEDIR}" "${CMAKE_INSTALL_FULL_INCLUDEDIR}")
-file(RELATIVE_PATH ROOT_CMAKE_TO_LIB_DIR "${CMAKE_INSTALL_FULL_CMAKEDIR}" "${CMAKE_INSTALL_FULL_LIBDIR}")
-file(RELATIVE_PATH ROOT_CMAKE_TO_BIN_DIR "${CMAKE_INSTALL_FULL_CMAKEDIR}" "${CMAKE_INSTALL_FULL_BINDIR}")
+cmake_path(RELATIVE_PATH CMAKE_INSTALL_FULL_INCLUDEDIR BASE_DIRECTORY "${CMAKE_INSTALL_FULL_CMAKEDIR}" OUTPUT_VARIABLE ROOT_CMAKE_TO_INCLUDE_DIR)
+cmake_path(RELATIVE_PATH CMAKE_INSTALL_FULL_LIBDIR BASE_DIRECTORY "${CMAKE_INSTALL_FULL_CMAKEDIR}" OUTPUT_VARIABLE ROOT_CMAKE_TO_LIB_DIR)
+cmake_path(RELATIVE_PATH CMAKE_INSTALL_FULL_BINDIR BASE_DIRECTORY "${CMAKE_INSTALL_FULL_CMAKEDIR}" OUTPUT_VARIABLE ROOT_CMAKE_TO_BIN_DIR)
 
 # '_' prefixed variables are used to construct the paths,
 # while the normal variants evaluate to full paths at runtime

cmake/modules/RootMacros.cmake

@@ -1858,7 +1858,8 @@ endfunction()
 # ROOT_ADD_TEST_SUBDIRECTORY( <name> )
 #----------------------------------------------------------------------------
 function(ROOT_ADD_TEST_SUBDIRECTORY subdir)
-  file(RELATIVE_PATH subdir ${CMAKE_SOURCE_DIR} ${CMAKE_CURRENT_SOURCE_DIR}/${subdir})
+  set(fullsubdir ${CMAKE_CURRENT_SOURCE_DIR}/${subdir})
+  cmake_path(RELATIVE_PATH fullsubdir BASE_DIRECTORY ${CMAKE_SOURCE_DIR} OUTPUT_VARIABLE subdir)
   set_property(GLOBAL APPEND PROPERTY ROOT_TEST_SUBDIRS ${subdir})
 endfunction()
 
@@ -2089,7 +2090,7 @@ endfunction()
 #   install_dir  - The install subdirectory relative to CMAKE_INSTALL_PREFIX
 #----------------------------------------------------------------------------
 function(ROOT_APPEND_LIBDIR_TO_INSTALL_RPATH target install_dir)
-  file(RELATIVE_PATH to_libdir "${CMAKE_INSTALL_PREFIX}/${install_dir}" "${CMAKE_INSTALL_FULL_LIBDIR}")
+  cmake_path(RELATIVE_PATH CMAKE_INSTALL_FULL_LIBDIR BASE_DIRECTORY "${CMAKE_INSTALL_PREFIX}/${install_dir}" OUTPUT_VARIABLE to_libdir)
 
   # New path
   if(APPLE)
@@ -3056,7 +3057,7 @@ function(ROOTTEST_ADD_TEST testname)
         string(REPLACE ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR} fpath ${fpath})
         string(REPLACE ${fext} "" fpath ${fpath})
         string(REPLACE "." "" fext ${fext})
-        file(TO_NATIVE_PATH "${fpath}" fpath)
+        cmake_path(CONVERT "${fpath}" TO_NATIVE_PATH_LIST fpath)
         set(postcmd POSTCMD cmd /c if exist ${fpath}_${fext}.rootmap del ${fpath}_${fext}.rootmap)
       endif()
     endif()

cmake/modules/RootTestDriver.cmake

@@ -86,7 +86,7 @@ endif()
 
 if(SYS)
   if(WIN32)
-    file(TO_NATIVE_PATH ${SYS}/bin _path)
+    cmake_path(CONVERT "${SYS}/bin" TO_NATIVE_PATH_LIST _path)
     set(ENV{PATH} "${_path};$ENV{PATH}")
   elseif(APPLE)
     set(ENV{PATH} ${SYS}/bin:$ENV{PATH})

interpreter/cling/CMakeLists.txt

@@ -295,10 +295,7 @@ macro(add_cling_library name)
   set(srcs)
   if(MSVC_IDE OR XCODE)
     # Add public headers
-    file(RELATIVE_PATH lib_path
-      ${CLING_SOURCE_DIR}/lib/
-      ${CMAKE_CURRENT_SOURCE_DIR}
-    )
+    cmake_path(RELATIVE_PATH CMAKE_CURRENT_SOURCE_DIR BASE_DIRECTORY ${CLING_SOURCE_DIR}/lib/ OUTPUT_VARIABLE lib_path)
     if(NOT lib_path MATCHES "^[.][.]")
       file( GLOB_RECURSE headers
         ${CLING_SOURCE_DIR}/include/cling/${lib_path}/*.h

roottest/CMakeLists.txt

@@ -5,7 +5,7 @@ project(roottest)
 # If no explicit ROOTSYS is set, use ${ROOTSYS} environment variable to search
 # for ROOT. This may be set by sourcing thisroot.sh from an installation.
 if(NOT DEFINED ROOTSYS AND DEFINED ENV{ROOTSYS})
-  file(TO_CMAKE_PATH $ENV{ROOTSYS} ROOTSYS)
+  cmake_path(CONVERT "$ENV{ROOTSYS}" TO_CMAKE_PATH_LIST ROOTSYS)
   list(INSERT CMAKE_PREFIX_PATH 0 ${ROOTSYS})
 endif()
 
@@ -58,10 +58,10 @@ if(MSVC)
     # ROOT_BINDIR is set by ROOTConfig.cmake
     set(ROOT_CONFIG_EXECUTABLE ${ROOT_BINDIR}/root-config.bat)
     execute_process(COMMAND ${ROOT_CONFIG_EXECUTABLE} "--prefix" OUTPUT_VARIABLE ROOTSYS RESULT_VARIABLE RETVAR OUTPUT_STRIP_TRAILING_WHITESPACE)
-    file(TO_CMAKE_PATH ${ROOTSYS} ROOTSYS)
+    cmake_path(CONVERT "${ROOTSYS}" TO_CMAKE_PATH_LIST ROOTSYS)
     set(ROOTSYS ${ROOTSYS} CACHE INTERNAL "")
     execute_process(COMMAND ${ROOT_CONFIG_EXECUTABLE} "--tutdir" OUTPUT_VARIABLE ROOT_TUTORIALS_DIR OUTPUT_STRIP_TRAILING_WHITESPACE)
-    file(TO_CMAKE_PATH ${ROOT_TUTORIALS_DIR} ROOT_TUTORIALS_DIR)
+    cmake_path(CONVERT "${ROOT_TUTORIALS_DIR}" TO_CMAKE_PATH_LIST ROOT_TUTORIALS_DIR)
     set(ROOT_root_CMD ${ROOTSYS}/bin/root.exe)
     set(ROOT_hadd_CMD ${ROOTSYS}/bin/hadd.exe)
     set(ROOT_genreflex_CMD ${ROOTSYS}/bin/genreflex.exe)
@@ -76,12 +76,12 @@ if(MSVC)
     include(${ROOT_USE_FILE})
     set(ROOT_CONFIG_EXECUTABLE root-config.bat)
     execute_process(COMMAND ${ROOT_CONFIG_EXECUTABLE} "--prefix" OUTPUT_VARIABLE ROOTSYS RESULT_VARIABLE RETVAR OUTPUT_STRIP_TRAILING_WHITESPACE)
-    file(TO_CMAKE_PATH ${ROOTSYS} ROOTSYS)
+    cmake_path(CONVERT "${ROOTSYS}" TO_CMAKE_PATH_LIST ROOTSYS)
     set(ROOTSYS ${ROOTSYS} CACHE INTERNAL "")
     execute_process(COMMAND ${ROOT_CONFIG_EXECUTABLE} "--srcdir" OUTPUT_VARIABLE ROOT_SOURCE_DIR OUTPUT_STRIP_TRAILING_WHITESPACE)
-    file(TO_CMAKE_PATH ${ROOT_SOURCE_DIR} ROOT_SOURCE_DIR)
+    cmake_path(CONVERT "${ROOT_SOURCE_DIR}" TO_CMAKE_PATH_LIST ROOT_SOURCE_DIR)
     execute_process(COMMAND ${ROOT_CONFIG_EXECUTABLE} "--tutdir" OUTPUT_VARIABLE ROOT_TUTORIALS_DIR OUTPUT_STRIP_TRAILING_WHITESPACE)
-    file(TO_CMAKE_PATH ${ROOT_TUTORIALS_DIR} ROOT_TUTORIALS_DIR)
+    cmake_path(CONVERT "${ROOT_TUTORIALS_DIR}" TO_CMAKE_PATH_LIST ROOT_TUTORIALS_DIR)
     execute_process(COMMAND ${ROOT_CONFIG_EXECUTABLE} "--features" OUTPUT_VARIABLE ROOT_FEATURES RESULT_VARIABLE RETVAR OUTPUT_STRIP_TRAILING_WHITESPACE)
     separate_arguments(ROOT_FEATURES)
     foreach(item ${ROOT_FEATURES})

roottest/root/meta/genreflex/noStreamer_noInputOperator/CMakeLists.txt

@@ -21,7 +21,7 @@ ROOTTEST_ADD_TEST(customStreamer
 #   generated streamer
 ROOTTEST_GENERATE_REFLEX_DICTIONARY(noStreamer_false_rflx foo.h SELECTION noStreamer_false_selection.xml)
 
-file(TO_NATIVE_PATH "${CMAKE_CURRENT_BINARY_DIR}/noStreamer_false_rflx.cxx" NOSTREAMER_FALSE_RFLX)
+cmake_path(CONVERT "${CMAKE_CURRENT_BINARY_DIR}/noStreamer_false_rflx.cxx" TO_NATIVE_PATH_LIST NOSTREAMER_FALSE_RFLX)
 ROOTTEST_ADD_TEST(noStreamerFalseDict
                   COMMAND ${grep_cmd} "void Foo::Streamer(TBuffer &R__b)" ${NOSTREAMER_FALSE_RFLX}
                   WORKING_DIR ${CMAKE_CURRENT_SOURCE_DIR}