[Tree] Delete virtual copy and copy assignment methods in TTree

The `TTree` class already deletes the copy constructor and the copy
assignment, but users might still be tempted to use the virtual copy
constructor or copy assignment provided by `TObject::Clone()` and
`TObject::Copy()`. But these implementations also make no sense to the
TTree.

To avoid user confusion, this commit suggests to override these methods
in TTree such that they thow an exception and tell you what to use
instead.

Prevents reports this one in the future:

  * https://its.cern.ch/jira/browse/ROOT-9111

Author: guitargeek

bindings/pyroot/pythonizations/test/memory.py

@@ -49,7 +49,7 @@ def test_ttree_clone_in_file_context(self):
 
         ttree = ROOT.TTree("tree", "tree")
 
-        with ROOT.TFile(filename, "RECREATE") as infile:
+        with ROOT.TFile(filename, "RECREATE") as _:
             ttree_clone = ttree.CloneTree()
 
         os.remove(filename)
@@ -88,7 +88,6 @@ def test_objects_ownership_with_subdir(self):
             "TH1I": ("h", "h", 10, 0, 10),
             "TH1L": ("h", "h", 10, 0, 10),
             "TH1F": ("h", "h", 10, 0, 10),
-            "TH1D": ("h", "h", 10, 0, 10),
             "TH1K": ("h", "h", 10, 0, 10),
             "TProfile": ("h", "h", 10, 0, 10),
             "TH2C": ("h", "h", 10, 0, 10, 10, 0, 10),
@@ -112,8 +111,6 @@ def test_objects_ownership_with_subdir(self):
             "TGraph2D": (100,),
             "TEntryList": ("name", "title"),
             "TEventList": ("name", "title"),
-            "TTree": ("name", "title"),
-            "TNtuple": ("name", "title", "x:y:z"),
         }
         for klass, args in objs.items():
             with self.subTest(klass=klass):

io/io/src/TFileMerger.cxx

@@ -530,7 +530,7 @@ Bool_t TFileMerger::MergeOne(TDirectory *target, TList *sourcelist, Int_t type,
                  && !cl->InheritsFrom( TDirectory::Class() )) {
          R__ASSERT(cl->IsTObject());
          TDirectory::TContext ctxt(current_sourcedir);
-         obj = obj->Clone();
+         obj = gDirectory->CloneObject(obj);
          ownobj = kTRUE;
       }
    } else if (key) {

roofit/roofitcore/src/RooTreeDataStore.cxx

@@ -369,7 +369,7 @@ void RooTreeDataStore::loadValues(const TTree *t, const RooFormulaVar* select, c
   // We need a custom deleter, because if we don't deregister the Tree from the directory
   // of the original, it tears it down at destruction time!
   auto deleter = [](TTree* tree){tree->SetDirectory(nullptr); delete tree;};
-  std::unique_ptr<TTree, decltype(deleter)> tClone(static_cast<TTree*>(t->Clone()), deleter);
+  std::unique_ptr<TTree, decltype(deleter)> tClone{static_cast<TTree*>(gDirectory->CloneObject(t)), deleter};
   tClone->SetDirectory(t->GetDirectory());
 
   // Clone list of variables

tree/tree/inc/TTree.h

@@ -352,6 +352,9 @@ class TTree : public TNamed, public TAttLine, public TAttFill, public TAttMarker
    TTree(const TTree& tt) = delete;
    TTree& operator=(const TTree& tt) = delete;
 
+   TObject *Clone(const char *newname="") const override;
+   void     Copy(TObject &object) const override;
+
    virtual Int_t           AddBranchToCache(const char *bname, bool subbranches = false);
    virtual Int_t           AddBranchToCache(TBranch *branch,   bool subbranches = false);
    virtual Int_t           DropBranchFromCache(const char *bname, bool subbranches = false);

tree/tree/src/TTree.cxx

@@ -1060,6 +1060,17 @@ TTree::~TTree()
    }
 }
 
+TObject *TTree::Clone(const char *) const
+{
+   Error("Clone", "Not implemented, use TTree::CloneTree instead.");
+   return nullptr;
+}
+
+void TTree::Copy(TObject &) const
+{
+   Error("Copy", "Not implemented, use TTree::CopyTree or TTree::CopyEntries instead.");
+}
+
 ////////////////////////////////////////////////////////////////////////////////
 /// Returns the transient buffer currently used by this TTree for reading/writing baskets.
 
@@ -3205,7 +3216,7 @@ TTree* TTree::CloneTree(Long64_t nentries /* = -1 */, Option_t* option /* = "" *
 
    // Note: For a chain, the returned clone will be
    //       a clone of the chain's first tree.
-   TTree* newtree = (TTree*) thistree->Clone();
+   TTree* newtree = (TTree*) thistree->TNamed::Clone();
    if (!newtree) {
       return nullptr;
    }