[roottest] adjust root/hist tests

Remove unused rootlogon.C script
Better format cmake files
Adjust C++ formating in some tests

Author: linev

roottest/root/hist/CMakeLists.txt

@@ -5,6 +5,7 @@ ROOTTEST_ADD_TEST(mergeTH2Poly
 ROOTTEST_ADD_TEST(assertSparseToTHn
                   MACRO assertSparseToTHn.C
                   COPY_TO_BUILDDIR effectiveCorrection.root)
+
 if(fortran AND CMAKE_Fortran_COMPILER AND NOT CMAKE_Fortran_COMPILER_ID STREQUAL Intel)
   ROOTTEST_ADD_TEST(h2root
                     COMMAND h2root mb4i1.hbook

roottest/root/hist/division/CMakeLists.txt

@@ -1,2 +1,3 @@
-ROOTTEST_ADD_TEST(runtestTEfficiency MACRO runtestTEfficiency.C OUTREF testTEfficiency.ref)
-
+ROOTTEST_ADD_TEST(runtestTEfficiency
+                  MACRO runtestTEfficiency.C
+                  OUTREF testTEfficiency.ref)

roottest/root/hist/formula/CMakeLists.txt

@@ -1,7 +1,20 @@
-ROOTTEST_ADD_TEST(assertTernary MACRO assertTernary.C OUTREF assertTernary.ref)
-ROOTTEST_ADD_TEST(execGetExp MACRO execGetExp.C OUTREF execGetExp.ref)
+ROOTTEST_ADD_TEST(assertTernary
+                  MACRO assertTernary.C
+                  OUTREF assertTernary.ref)
+
+ROOTTEST_ADD_TEST(execGetExp
+                  MACRO execGetExp.C
+                  OUTREF execGetExp.ref)
+
 ROOTTEST_ADD_TEST(runformio
                   MACRO runformio.C
-                  COPY_TO_BUILDDIR result_30gev_sep05.root)
-ROOTTEST_ADD_TEST(runrecurse MACRO runrecurse.C OUTREF recurse.ref)
-ROOTTEST_ADD_TEST(runstring MACRO runstring.C OUTREF string.ref)
+                  COPY_TO_BUILDDIR result_30gev_sep05.root
+                  OUTREF formio.ref)
+
+ROOTTEST_ADD_TEST(runrecurse
+                  MACRO runrecurse.C
+                  OUTREF recurse.ref)
+
+ROOTTEST_ADD_TEST(runstring
+                  MACRO runstring.C
+                  OUTREF string.ref)

roottest/root/hist/misc/CMakeLists.txt

@@ -1,5 +1,11 @@
-ROOTTEST_ADD_TEST(runownership MACRO runownership.C+ OUTREF ownership.ref)
-ROOTTEST_ADD_TEST(testSparse MACRO testSparse.cxx OUTREF testSparse.ref)
+ROOTTEST_ADD_TEST(runownership
+                  MACRO runownership.C+
+                  OUTREF ownership.ref)
+
+ROOTTEST_ADD_TEST(testSparse
+                  MACRO testSparse.cxx
+                  OUTREF testSparse.ref)
+
 ROOT_ADD_GTEST(gh15874 test_gh15874.cxx
                COPY_TO_BUILDDIR ${CMAKE_CURRENT_SOURCE_DIR}/test_gh15874.root
                LIBRARIES ROOT::Core ROOT::Hist ROOT::RIO)

roottest/root/hist/operator/rootlogon.C

@@ -1,6 +1,6 @@
 {
-gErrorIgnoreLevel=1;
-if (!gSystem->CompileMacro("add.C","k")) {
-   gApplication->Terminate(1);
-}
+   gErrorIgnoreLevel = 1;
+   if (!gSystem->CompileMacro("add.C","k")) {
+      gApplication->Terminate(1);
+   }
 }

roottest/root/hist/operator/run.C

@@ -2,9 +2,9 @@
 #include "TDirectory.h"
 #include "TList.h"
 
-TH1F *h=0;
-TH1F *h2=0;
-TH1F *h3=0;
+TH1F *h = nullptr;
+TH1F *h2 = nullptr;
+TH1F *h3 = nullptr;
 
 void runcopy()
 {

roottest/root/hist/operator/runcopy.C

@@ -1 +1,3 @@
-ROOTTEST_ADD_TEST(runcopy MACRO runcopy.C OUTREF copy.ref)
+ROOTTEST_ADD_TEST(runcopy
+                  MACRO runcopy.C
+                  OUTREF copy.ref)

roottest/root/hist/profile/CMakeLists.txt

@@ -1,10 +1,15 @@
-void FillPoly(TH2Poly& th2p){
+#include <iostream>
+using namespace std;
+
+void FillPoly(TH2Poly& th2p)
+{
    for (auto i : ROOT::TSeqI(1000)){
       th2p.Fill(gRandom->Uniform(),gRandom->Uniform(),gRandom->Uniform());
    }
 }
 
-TH2Poly *CreatePoly() {
+TH2Poly *CreatePoly()
+{
    auto h2p = new TH2Poly();
    Double_t x1[] = {0, 5, 6};
    Double_t y1[] = {0, 0, 5};
@@ -19,7 +24,8 @@ TH2Poly *CreatePoly() {
    return h2p;
 }
 
-TH2Poly *CreatePolyDiffContour() {
+TH2Poly *CreatePolyDiffContour()
+{
    auto h2p = new TH2Poly();
    Double_t x1[] = {0, 5, 6};
    Double_t y1[] = {0, 0, 5};
@@ -34,8 +40,8 @@ TH2Poly *CreatePolyDiffContour() {
    return h2p;
 }
 
-int th2PolyMerge() {
-
+int th2PolyMerge()
+{
    cout << "We expect two warnings to be printed:\n"
            " 1) About different number of bins\n"
            " 2) About different contours\n";
@@ -68,6 +74,4 @@ int th2PolyMerge() {
    if (totEntries != 0) return 3;
 
    return 0;
-
-
 }